Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/821420/?format=api
{ "id": 821420, "url": "http://patchwork.ozlabs.org/api/patches/821420/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171004175839.28364-5-alan.brady@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171004175839.28364-5-alan.brady@intel.com>", "list_archive_url": null, "date": "2017-10-04T17:58:30", "name": "[04/13,net-next] i40e: fix clearing link masks in i40e_get_link_ksettings", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "9d236857b33d57d41b329745064a318922d4ead4", "submitter": { "id": 69551, "url": "http://patchwork.ozlabs.org/api/people/69551/?format=api", "name": "Alan Brady", "email": "alan.brady@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171004175839.28364-5-alan.brady@intel.com/mbox/", "series": [ { "id": 6427, "url": "http://patchwork.ozlabs.org/api/series/6427/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=6427", "date": "2017-10-04T17:58:26", "name": "i40e: refactor ethtool interface", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/6427/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/821420/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/821420/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6kHf2zx2z9t7n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 5 Oct 2017 05:01:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EDB5D87A50;\n\tWed, 4 Oct 2017 18:01:48 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tD5dlj5IxPM1; Wed, 4 Oct 2017 18:01:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6828A87A35;\n\tWed, 4 Oct 2017 18:01:48 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9C50B1C25C5\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 4 Oct 2017 18:01:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8E3C5822B4\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 4 Oct 2017 18:01:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4IAbw54aKK6B for <intel-wired-lan@osuosl.org>;\n\tWed, 4 Oct 2017 18:01:44 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 73E0482076\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 4 Oct 2017 18:01:44 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Oct 2017 11:01:43 -0700", "from dev1-atbrady.jf.intel.com ([10.165.248.38])\n\tby FMSMGA003.fm.intel.com with ESMTP; 04 Oct 2017 11:01:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,478,1500966000\"; d=\"scan'208\";a=\"906754389\"", "From": "Alan Brady <alan.brady@intel.com>", "To": "intel-wired-lan@osuosl.org", "Date": "Wed, 4 Oct 2017 10:58:30 -0700", "Message-Id": "<20171004175839.28364-5-alan.brady@intel.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20171004175839.28364-1-alan.brady@intel.com>", "References": "<20171004175839.28364-1-alan.brady@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 04/13 net-next] i40e: fix clearing link\n\tmasks in i40e_get_link_ksettings", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This fixes two issues in i40e_get_link_ksettings. It adds calls to\nethtool_link_ksettings_zero_link_mode to make sure advertising and\nsupported link masks are cleared before we start setting bits in them.\n\nThis also replaces some funky bit manipulations with a much nicer call\nto ethtool_link_ksettings_del_link_mode when removing link modes.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 43294b6567c2..f0cde09c0bd5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -600,7 +600,9 @@ static int i40e_get_link_ksettings(struct net_device *netdev,\n \tstruct i40e_hw *hw = &pf->hw;\n \tstruct i40e_link_status *hw_link_info = &hw->phy.link_info;\n \tbool link_up = hw_link_info->link_info & I40E_AQ_LINK_UP;\n-\tu32 advertising;\n+\n+\tethtool_link_ksettings_zero_link_mode(ks, supported);\n+\tethtool_link_ksettings_zero_link_mode(ks, advertising);\n \n \tif (link_up)\n \t\ti40e_get_settings_link_up(hw, ks, netdev, pf);\n@@ -664,13 +666,9 @@ static int i40e_get_link_ksettings(struct net_device *netdev,\n \t\t\t\t\t\t Asym_Pause);\n \t\tbreak;\n \tdefault:\n-\t\tethtool_convert_link_mode_to_legacy_u32(\n-\t\t\t&advertising, ks->link_modes.advertising);\n-\n-\t\tadvertising &= ~(ADVERTISED_Pause | ADVERTISED_Asym_Pause);\n-\n-\t\tethtool_convert_legacy_u32_to_link_mode(\n-\t\t\tks->link_modes.advertising, advertising);\n+\t\tethtool_link_ksettings_del_link_mode(ks, advertising, Pause);\n+\t\tethtool_link_ksettings_del_link_mode(ks, advertising,\n+\t\t\t\t\t\t Asym_Pause);\n \t\tbreak;\n \t}\n \n", "prefixes": [ "04/13", "net-next" ] }