Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/819336/?format=api
{ "id": 819336, "url": "http://patchwork.ozlabs.org/api/patches/819336/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-2-samuel.thibault@ens-lyon.org/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170927231742.9050-2-samuel.thibault@ens-lyon.org>", "list_archive_url": null, "date": "2017-09-27T23:17:39", "name": "[hurd,commited,1/4] hurd: Fix dirfd symbol exposition from ftw", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "16362a373d100d512c9c1eb78072c216a5a7299d", "submitter": { "id": 418, "url": "http://patchwork.ozlabs.org/api/people/418/?format=api", "name": "Samuel Thibault", "email": "samuel.thibault@ens-lyon.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-2-samuel.thibault@ens-lyon.org/mbox/", "series": [ { "id": 5459, "url": "http://patchwork.ozlabs.org/api/series/5459/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=5459", "date": "2017-09-27T23:17:38", "name": "Fixing symbol exposition.s", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/5459/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/819336/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/819336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-85050-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85050-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"HMCYNqHh\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Ydz5yDFz9t6B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 09:18:15 +1000 (AEST)", "(qmail 80065 invoked by alias); 27 Sep 2017 23:17:49 -0000", "(qmail 79928 invoked by uid 89); 27 Sep 2017 23:17:49 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=pvdN1RIDL8Y3p5atE8WVsnh5hecqwRr\n\tmIg3g2bAtbPfm4yP7q+VFVTtUIMSvx2Y6NiibpDkQH+Mrp3HpfECwCsu/AZBR2VJ\n\tTS6udgLgwPCFrmPGsJJtX1Z5q8E+aa+6ADOHq/I5x+dUNa57Rm/T3NuDDR19a9fy\n\toRdk/Ogljnh0=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=7B0JHBLhoJO2egVMpnw+C9KKZrQ=; b=HMCYN\n\tqHhAX0/4jp7T7fwYBcqvwt/J2frJ8Yv3CFxIbYMT+5N9BXcaVYDNaS7o69WjrX6w\n\tWGeZxpa6ZmSP9yQ7To8j/I+lhsFLoiD7YeRb5r15Q8TRdHE9Duq6W2KaMbbb8zqE\n\t9XjsoZde/K65uinjk+DV5u/mKRx1KOIkEvuDGM=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS,\n\tSPF_NEUTRAL autolearn=ham version=3.3.2 spammy=UD:stream", "X-HELO": "hera.aquilenet.fr", "From": "Samuel Thibault <samuel.thibault@ens-lyon.org>", "To": "libc-alpha@sourceware.org", "Cc": "Samuel Thibault <samuel.thibault@ens-lyon.org>", "Subject": "[hurd,commited 1/4] hurd: Fix dirfd symbol exposition from ftw", "Date": "Thu, 28 Sep 2017 01:17:39 +0200", "Message-Id": "<20170927231742.9050-2-samuel.thibault@ens-lyon.org>", "In-Reply-To": "<20170927231742.9050-1-samuel.thibault@ens-lyon.org>", "References": "<20170927231742.9050-1-samuel.thibault@ens-lyon.org>" }, "content": "dirfd is XOPEN2K8 only, it should not be exposed along ftw which is earlier.\n\n\t* include/dirent.h (__dirfd): New declaration.\n\t* dirent/dirfd.c (dirfd): Rename to __dirfd, and redefine as weak\n\talias.\n\t* sysdeps/posix/dirfd/dirfd.c (dirfd): Likewise.\n\t* sysdeps/mach/hurd/dirfd.c (dirfd): Likewise.\n\t* io/ftw.c (open_dir_stream, ftw_dir): Use __dirfd instead of dirfd.\n---\n ChangeLog | 9 +++++++++\n dirent/dirfd.c | 3 ++-\n include/dirent.h | 1 +\n io/ftw.c | 6 +++---\n sysdeps/mach/hurd/dirfd.c | 4 +++-\n sysdeps/posix/dirfd.c | 4 +++-\n 6 files changed, 21 insertions(+), 6 deletions(-)", "diff": "diff --git a/ChangeLog b/ChangeLog\nindex a731980f80..a535da875c 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -1,3 +1,12 @@\n+2017-09-27 Samuel Thibault <samuel.thibault@ens-lyon.org>\n+\n+\t* include/dirent.h (__dirfd): New declaration.\n+\t* dirent/dirfd.c (dirfd): Rename to __dirfd, and redefine as weak\n+\talias.\n+\t* sysdeps/posix/dirfd/dirfd.c (dirfd): Likewise.\n+\t* sysdeps/mach/hurd/dirfd.c (dirfd): Likewise.\n+\t* io/ftw.c (open_dir_stream, ftw_dir): Use __dirfd instead of dirfd.\n+\n 2017-09-26 H.J. Lu <hongjiu.lu@intel.com>\n \n \t[BZ #18822]\ndiff --git a/dirent/dirfd.c b/dirent/dirfd.c\nindex 7af77adf01..c1069ffb80 100644\n--- a/dirent/dirfd.c\n+++ b/dirent/dirfd.c\n@@ -21,10 +21,11 @@\n #include <errno.h>\n \n int\n-dirfd (DIR *dirp)\n+__dirfd (DIR *dirp)\n {\n __set_errno (ENOSYS);\n return -1;\n }\n \n+weak_alias (__dirfd, dirfd)\n stub_warning (dirfd)\ndiff --git a/include/dirent.h b/include/dirent.h\nindex bebcd52cdb..5720d589a2 100644\n--- a/include/dirent.h\n+++ b/include/dirent.h\n@@ -46,6 +46,7 @@ extern int __versionsort64 (const struct dirent64 **a,\n extern DIR *__alloc_dir (int fd, bool close_fd, int flags,\n \t\t\t const struct stat64 *statp) attribute_hidden;\n extern __typeof (rewinddir) __rewinddir;\n+extern __typeof (dirfd) __dirfd;\n \n extern void __scandir_cancel_handler (void *arg) attribute_hidden;\n extern int __scandir_tail (DIR *dp,\ndiff --git a/io/ftw.c b/io/ftw.c\nindex 63448e188a..6cca0e4cbc 100644\n--- a/io/ftw.c\n+++ b/io/ftw.c\n@@ -361,7 +361,7 @@ open_dir_stream (int *dfdp, struct ftw_data *data, struct dir_data *dirp)\n \tresult = -1;\n else\n \t{\n-\t dirp->streamfd = dirfd (dirp->stream);\n+\t dirp->streamfd = __dirfd (dirp->stream);\n \t dirp->content = NULL;\n \t data->dirstreams[data->actdir] = dirp;\n \n@@ -518,7 +518,7 @@ fail:\n /* If necessary, change to this directory. */\n if (data->flags & FTW_CHDIR)\n {\n- if (__fchdir (dirfd (dir.stream)) < 0)\n+ if (__fchdir (__dirfd (dir.stream)) < 0)\n \t{\n \t result = -1;\n \t goto fail;\n@@ -602,7 +602,7 @@ fail:\n /* Change back to the parent directory. */\n int done = 0;\n if (old_dir->stream != NULL)\n-\tif (__fchdir (dirfd (old_dir->stream)) == 0)\n+\tif (__fchdir (__dirfd (old_dir->stream)) == 0)\n \t done = 1;\n \n if (!done)\ndiff --git a/sysdeps/mach/hurd/dirfd.c b/sysdeps/mach/hurd/dirfd.c\nindex 0ad290d515..65673336e3 100644\n--- a/sysdeps/mach/hurd/dirfd.c\n+++ b/sysdeps/mach/hurd/dirfd.c\n@@ -22,7 +22,7 @@\n #include <errno.h>\n \n int\n-dirfd (DIR *dirp)\n+__dirfd (DIR *dirp)\n {\n int fd;\n \n@@ -41,3 +41,5 @@ dirfd (DIR *dirp)\n \n return fd;\n }\n+\n+weak_alias (__dirfd, dirfd)\ndiff --git a/sysdeps/posix/dirfd.c b/sysdeps/posix/dirfd.c\nindex fee8326d93..ce779c50ae 100644\n--- a/sysdeps/posix/dirfd.c\n+++ b/sysdeps/posix/dirfd.c\n@@ -22,7 +22,9 @@\n #undef dirfd\n \n int\n-dirfd (DIR *dirp)\n+__dirfd (DIR *dirp)\n {\n return dirp->fd;\n }\n+\n+weak_alias (__dirfd, dirfd)\n", "prefixes": [ "hurd", "commited", "1/4" ] }