Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/819290/?format=api
{ "id": 819290, "url": "http://patchwork.ozlabs.org/api/patches/819290/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927195635.16014-6-ehabkost@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170927195635.16014-6-ehabkost@redhat.com>", "list_archive_url": null, "date": "2017-09-27T19:56:35", "name": "[v2,5/5] pci: Validate interfaces on base_class_init", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cbf896a4b2d4e700db71c127d691655d0029278b", "submitter": { "id": 195, "url": "http://patchwork.ozlabs.org/api/people/195/?format=api", "name": "Eduardo Habkost", "email": "ehabkost@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927195635.16014-6-ehabkost@redhat.com/mbox/", "series": [ { "id": 5434, "url": "http://patchwork.ozlabs.org/api/series/5434/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5434", "date": "2017-09-27T19:56:30", "name": "Mark conventional/PCIe/hybrid PCI devices using interface names", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/5434/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/819290/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/819290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2TFy70Mtz9t4b\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 06:00:38 +1000 (AEST)", "from localhost ([::1]:56164 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dxIVZ-0000XK-3w\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 16:00:37 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47717)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dxISw-00073n-VB\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 15:57:55 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dxISt-0007Xd-UJ\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 15:57:55 -0400", "from mx1.redhat.com ([209.132.183.28]:44972)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <ehabkost@redhat.com>) id 1dxISt-0007XC-OS\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 15:57:51 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BAF9C108FAC;\n\tWed, 27 Sep 2017 19:57:50 +0000 (UTC)", "from localhost (ovpn-116-18.gru2.redhat.com [10.97.116.18])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 44A3188E19;\n\tWed, 27 Sep 2017 19:57:41 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com BAF9C108FAC", "From": "Eduardo Habkost <ehabkost@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 27 Sep 2017 16:56:35 -0300", "Message-Id": "<20170927195635.16014-6-ehabkost@redhat.com>", "In-Reply-To": "<20170927195635.16014-1-ehabkost@redhat.com>", "References": "<20170927195635.16014-1-ehabkost@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 27 Sep 2017 19:57:50 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v2 5/5] pci: Validate interfaces on\n\tbase_class_init", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tAlex Williamson <alex.williamson@redhat.com>,\n\tLaine Stump <laine@redhat.com>, Alistair Francis <alistair23@gmail.com>, \n\tMarcel Apfelbaum <marcel@redhat.com>, David Gibson <dgibson@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Make sure we don't forget to add the Conventional PCI or PCI\nExpress interface names on PCI device classes in the future.\n\nSigned-off-by: Eduardo Habkost <ehabkost@redhat.com>\n---\nChanges v1 -> v2:\n* s/legacy/conventional/\n * Suggested-by: Alex Williamson <alex.williamson@redhat.com>\n---\n hw/pci/pci.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/hw/pci/pci.c b/hw/pci/pci.c\nindex 1b08e18205..5ed3c8dca4 100644\n--- a/hw/pci/pci.c\n+++ b/hw/pci/pci.c\n@@ -2547,6 +2547,17 @@ static void pci_device_class_init(ObjectClass *klass, void *data)\n pc->realize = pci_default_realize;\n }\n \n+static void pci_device_class_base_init(ObjectClass *klass, void *data)\n+{\n+ if (!object_class_is_abstract(klass)) {\n+ ObjectClass *conventional =\n+ object_class_dynamic_cast(klass, INTERFACE_CONVENTIONAL_PCI_DEVICE);\n+ ObjectClass *pcie =\n+ object_class_dynamic_cast(klass, INTERFACE_PCIE_DEVICE);\n+ assert(conventional || pcie);\n+ }\n+}\n+\n AddressSpace *pci_device_iommu_address_space(PCIDevice *dev)\n {\n PCIBus *bus = PCI_BUS(dev->bus);\n@@ -2671,6 +2682,7 @@ static const TypeInfo pci_device_type_info = {\n .abstract = true,\n .class_size = sizeof(PCIDeviceClass),\n .class_init = pci_device_class_init,\n+ .class_base_init = pci_device_class_base_init,\n };\n \n static void pci_register_types(void)\n", "prefixes": [ "v2", "5/5" ] }