Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 818842,
    "url": "http://patchwork.ozlabs.org/api/patches/818842/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1506464764-12699-5-git-send-email-andrew@lunn.ch/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1506464764-12699-5-git-send-email-andrew@lunn.ch>",
    "list_archive_url": null,
    "date": "2017-09-26T22:26:01",
    "name": "[net-next,4/6] net: dsa: mv88e6xxx: Print offending port when vlan check fails",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2fae31dca561b48af52756b357d585c60a6ece54",
    "submitter": {
        "id": 13608,
        "url": "http://patchwork.ozlabs.org/api/people/13608/?format=api",
        "name": "Andrew Lunn",
        "email": "andrew@lunn.ch"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1506464764-12699-5-git-send-email-andrew@lunn.ch/mbox/",
    "series": [
        {
            "id": 5236,
            "url": "http://patchwork.ozlabs.org/api/series/5236/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=5236",
            "date": "2017-09-26T22:26:00",
            "name": "mv88e6xxx broadcast flooding in hardware",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/5236/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/818842/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/818842/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1wY00QnJz9s3T\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 08:26:44 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S968440AbdIZW0m (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 18:26:42 -0400",
            "from vps0.lunn.ch ([185.16.172.187]:57006 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S967343AbdIZW0l (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 18:26:41 -0400",
            "from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dwyIq-0003Ji-T8; Wed, 27 Sep 2017 00:26:08 +0200"
        ],
        "From": "Andrew Lunn <andrew@lunn.ch>",
        "To": "David Miller <davem@davemloft.net>",
        "Cc": "Vivien Didelot <vivien.didelot@savoirfairelinux.com>,\n\tnetdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>",
        "Subject": "[PATCH net-next 4/6] net: dsa: mv88e6xxx: Print offending port when\n\tvlan check fails",
        "Date": "Wed, 27 Sep 2017 00:26:01 +0200",
        "Message-Id": "<1506464764-12699-5-git-send-email-andrew@lunn.ch>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<1506464764-12699-1-git-send-email-andrew@lunn.ch>",
        "References": "<1506464764-12699-1-git-send-email-andrew@lunn.ch>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "When testing if a VLAN is one more than one bridge, we print an error\nmessage that the VLAN is already in use somewhere else. Print both the\nnew port which would like the VLAN, and the port which already has it,\nto aid debugging.\n\nSigned-off-by: Andrew Lunn <andrew@lunn.ch>\n---\n drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c\nindex 884f0507cf48..8a4756490a5a 100644\n--- a/drivers/net/dsa/mv88e6xxx/chip.c\n+++ b/drivers/net/dsa/mv88e6xxx/chip.c\n@@ -1134,8 +1134,8 @@ static int mv88e6xxx_port_check_hw_vlan(struct dsa_switch *ds, int port,\n \t\t\tif (!ds->ports[i].bridge_dev)\n \t\t\t\tcontinue;\n \n-\t\t\tdev_err(ds->dev, \"p%d: hw VLAN %d already used by %s\\n\",\n-\t\t\t\tport, vlan.vid,\n+\t\t\tdev_err(ds->dev, \"p%d: hw VLAN %d already used by port %d in %s\\n\",\n+\t\t\t\tport, vlan.vid, i,\n \t\t\t\tnetdev_name(ds->ports[i].bridge_dev));\n \t\t\terr = -EOPNOTSUPP;\n \t\t\tgoto unlock;\n",
    "prefixes": [
        "net-next",
        "4/6"
    ]
}