Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 818841,
    "url": "http://patchwork.ozlabs.org/api/patches/818841/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1506464764-12699-4-git-send-email-andrew@lunn.ch/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1506464764-12699-4-git-send-email-andrew@lunn.ch>",
    "list_archive_url": null,
    "date": "2017-09-26T22:26:00",
    "name": "[net-next,3/6] net: dsa: mv88e6xxx: Fixed port netdev check for VLANs",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f5ab170c834a587a317d2cfc0720a279a7bc6bb8",
    "submitter": {
        "id": 13608,
        "url": "http://patchwork.ozlabs.org/api/people/13608/?format=api",
        "name": "Andrew Lunn",
        "email": "andrew@lunn.ch"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1506464764-12699-4-git-send-email-andrew@lunn.ch/mbox/",
    "series": [
        {
            "id": 5236,
            "url": "http://patchwork.ozlabs.org/api/series/5236/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=5236",
            "date": "2017-09-26T22:26:00",
            "name": "mv88e6xxx broadcast flooding in hardware",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/5236/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/818841/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/818841/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1wXk2pCWz9s3T\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 08:26:30 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S968370AbdIZW02 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 18:26:28 -0400",
            "from vps0.lunn.ch ([185.16.172.187]:57002 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S967343AbdIZW00 (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 18:26:26 -0400",
            "from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dwyIq-0003Jd-SM; Wed, 27 Sep 2017 00:26:08 +0200"
        ],
        "From": "Andrew Lunn <andrew@lunn.ch>",
        "To": "David Miller <davem@davemloft.net>",
        "Cc": "Vivien Didelot <vivien.didelot@savoirfairelinux.com>,\n\tnetdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>",
        "Subject": "[PATCH net-next 3/6] net: dsa: mv88e6xxx: Fixed port netdev check\n\tfor VLANs",
        "Date": "Wed, 27 Sep 2017 00:26:00 +0200",
        "Message-Id": "<1506464764-12699-4-git-send-email-andrew@lunn.ch>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<1506464764-12699-1-git-send-email-andrew@lunn.ch>",
        "References": "<1506464764-12699-1-git-send-email-andrew@lunn.ch>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Having the same VLAN on multiple bridges is currently unsupported as\nan offload. mv88e6xxx_port_check_hw_vlan() is used to ensure that a\nVLAN is not on multiple bridges when adding a VLAN range to a port. It\nloops the ports and checks to see if there are ports in a different\nbridge with the same VLAN.\n\nWhile walking all switch ports, the code was checking if the new port\nhas a netdev attached to it. If not, skip checking the port being\nwalked. This seems like a typ0. If the new port does not have a\nnetdev, how has a VLAN been added to it in the first place, requiring\nthis check be performed at all? More likely, we should be checking if\nthe port being walked has a netdev. Without it having a netdev, it\ncannot have a VLAN on it, so there is no need to check further for\nthat particular port.\n\nSigned-off-by: Andrew Lunn <andrew@lunn.ch>\n---\n drivers/net/dsa/mv88e6xxx/chip.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c\nindex c6678aa9b4ef..884f0507cf48 100644\n--- a/drivers/net/dsa/mv88e6xxx/chip.c\n+++ b/drivers/net/dsa/mv88e6xxx/chip.c\n@@ -1120,7 +1120,7 @@ static int mv88e6xxx_port_check_hw_vlan(struct dsa_switch *ds, int port,\n \t\t\tif (dsa_is_dsa_port(ds, i) || dsa_is_cpu_port(ds, i))\n \t\t\t\tcontinue;\n \n-\t\t\tif (!ds->ports[port].netdev)\n+\t\t\tif (!ds->ports[i].netdev)\n \t\t\t\tcontinue;\n \n \t\t\tif (vlan.member[i] ==\n",
    "prefixes": [
        "net-next",
        "3/6"
    ]
}