Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/818819/?format=api
{ "id": 818819, "url": "http://patchwork.ozlabs.org/api/patches/818819/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926201427.2833-9-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170926201427.2833-9-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2017-09-26T20:14:26", "name": "[v3,8/9] disas: Remove monitor_disas_is_physical", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8e9a4654c714bcfec514145142734baba0e27b96", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926201427.2833-9-richard.henderson@linaro.org/mbox/", "series": [ { "id": 5223, "url": "http://patchwork.ozlabs.org/api/series/5223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5223", "date": "2017-09-26T20:14:18", "name": "Support the Capstone disassembler", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/5223/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/818819/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/818819/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"V2foSD8u\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1srr6N3yz9t3R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 06:25:16 +1000 (AEST)", "from localhost ([::1]:51030 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwwPr-0002hi-19\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 16:25:15 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:44062)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwwFg-0002yp-AN\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 16:14:45 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwwFf-0003Gm-Dq\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 16:14:44 -0400", "from mail-pg0-x22f.google.com ([2607:f8b0:400e:c05::22f]:48917)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dwwFf-0003Fw-7T\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 16:14:43 -0400", "by mail-pg0-x22f.google.com with SMTP id v23so6516393pgc.5\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 13:14:43 -0700 (PDT)", "from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tr138sm15582470pgr.12.2017.09.26.13.14.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 26 Sep 2017 13:14:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=iHGWhZ7FMiF/1t3mBnHk2VoW4xUvwNwin4py5V11uoo=;\n\tb=V2foSD8upKy8zHkZTTcI/X/T3o4ZgD3BR5f3N6SLpdGSGiyot553RG38IioqV2UFfm\n\tXzNz/vCnz4TWhn2qQwt/u3C/uWH97z+do9sPyyQJR93eigSMZhKnxu/tvVkrCqG+NEFw\n\t1AL14DeUKyeIZzS2nrTKAdbhCcjNZO7uyYT1s=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=iHGWhZ7FMiF/1t3mBnHk2VoW4xUvwNwin4py5V11uoo=;\n\tb=RzLeBGLnwbv7ADx9HvVh47bzKWTrnyOjzG2h+PcdyKWNcBN5kmWEEiCMHw9Qj80vT6\n\tCqdaNSpzc+4WGE+N0T2rC/K2NfTvLtdzrTY2s0l17GzAuYt319Gu9CFxQ8E1+Dkme1Lm\n\tySpV+OBFNzdsqol7pNYel3cncynZV5VicK6UzFJjBGZofiEu4wnX2SG/MvtyNFDStnID\n\ttMrkOJXjovQL1zR1W/nPqTeSd3qNhCG6Wvt2GkcpCcJM+Gon90mNNVnsOZNpEc7K4IeO\n\tLbU9xKXSIGautBwIXMoxQpgdP3W2KJUjdK5bKHZ5Y+arqJy9CUZMAI+fkdTFQL8Ymbp6\n\tTZCA==", "X-Gm-Message-State": "AHPjjUipbNmk1ls1rfRAxvtN6fcOt24kXMyKVVAJRyfYMdQSyCPomw7R\n\tXsZMBKjATlFmiFCsfgzqz/vSuHES2kk=", "X-Google-Smtp-Source": "AOwi7QCPO/T7YdbaUmE3sajSJEvwvC/Ikb62vMALuT7RXQ4Er70sNYMZad4vFiaAuWzbFyJ4/Zz2sQ==", "X-Received": "by 10.101.74.129 with SMTP id b1mr11968029pgu.272.1506456882139; \n\tTue, 26 Sep 2017 13:14:42 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 26 Sep 2017 13:14:26 -0700", "Message-Id": "<20170926201427.2833-9-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170926201427.2833-1-richard.henderson@linaro.org>", "References": "<20170926201427.2833-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400e:c05::22f", "Subject": "[Qemu-devel] [PATCH v3 8/9] disas: Remove monitor_disas_is_physical", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, qemu-ppc@nongnu.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Even though there is only one monitor, and thus no race on this\nglobal data object, there is also no point in having it. We can\njust as well record the decision in the read_memory_function that\nwe select.\n\nReviewed-by: Alex Bennée <alex.bennee@linaro.org>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n disas.c | 16 ++++------------\n 1 file changed, 4 insertions(+), 12 deletions(-)", "diff": "diff --git a/disas.c b/disas.c\nindex 0d212f2ac5..194c523885 100644\n--- a/disas.c\n+++ b/disas.c\n@@ -513,19 +513,11 @@ const char *lookup_symbol(target_ulong orig_addr)\n \n #include \"monitor/monitor.h\"\n \n-static int monitor_disas_is_physical;\n-\n static int\n-monitor_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length,\n+physical_read_memory(bfd_vma memaddr, bfd_byte *myaddr, int length,\n struct disassemble_info *info)\n {\n- CPUDebug *s = container_of(info, CPUDebug, info);\n-\n- if (monitor_disas_is_physical) {\n- cpu_physical_memory_read(memaddr, myaddr, length);\n- } else {\n- cpu_memory_rw_debug(s->cpu, memaddr, myaddr, length, 0);\n- }\n+ cpu_physical_memory_read(memaddr, myaddr, length);\n return 0;\n }\n \n@@ -540,8 +532,8 @@ void monitor_disas(Monitor *mon, CPUState *cpu,\n INIT_DISASSEMBLE_INFO(s.info, (FILE *)mon, monitor_fprintf);\n \n s.cpu = cpu;\n- monitor_disas_is_physical = is_physical;\n- s.info.read_memory_func = monitor_read_memory;\n+ s.info.read_memory_func\n+ = (is_physical ? physical_read_memory : target_read_memory);\n s.info.print_address_func = generic_print_address;\n s.info.buffer_vma = pc;\n s.info.cap_arch = -1;\n", "prefixes": [ "v3", "8/9" ] }