Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/818817/?format=api
{ "id": 818817, "url": "http://patchwork.ozlabs.org/api/patches/818817/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926201427.2833-10-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170926201427.2833-10-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2017-09-26T20:14:27", "name": "[v3,9/9] disas: Add capstone as submodule", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a616f4c193dfcc10cc91b58a55ecb18f5f48fc7c", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926201427.2833-10-richard.henderson@linaro.org/mbox/", "series": [ { "id": 5223, "url": "http://patchwork.ozlabs.org/api/series/5223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5223", "date": "2017-09-26T20:14:18", "name": "Support the Capstone disassembler", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/5223/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/818817/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/818817/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Pu2g9p0b\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1smb4nKYz9t3R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 06:21:35 +1000 (AEST)", "from localhost ([::1]:51013 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwwMH-0008Of-O3\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 16:21:33 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:44085)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwwFi-000315-6s\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 16:14:47 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwwFh-0003Hy-3r\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 16:14:46 -0400", "from mail-pg0-x22f.google.com ([2607:f8b0:400e:c05::22f]:57028)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dwwFg-0003HW-VY\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 16:14:45 -0400", "by mail-pg0-x22f.google.com with SMTP id 7so6503514pgd.13\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 13:14:44 -0700 (PDT)", "from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tr138sm15582470pgr.12.2017.09.26.13.14.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 26 Sep 2017 13:14:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=hZDT8cNI/9rhnMMwQw4AhrvAIrHkiQH4MRh280ZdV2M=;\n\tb=Pu2g9p0bK1/u++slvUhBPxZU9XF6joQc5nMHbrDwVv4NuQZWx7udIrQPhc8lJWexXC\n\tWckqFKsaFPVPqLxfOK2PFtXqyJWWOlag2YIVMDLUFWUtpPBQZU6Xo/HSbvuetO0ZXRnA\n\t+AQmXOutRl8XQecKa56zjjKnZC7pY5EEecBhA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=hZDT8cNI/9rhnMMwQw4AhrvAIrHkiQH4MRh280ZdV2M=;\n\tb=HkOIPhRAhq7OX/8DmFnuBAmTPf+aHjeGTSe2IYxGBrG7tx3q8GXYLOAV/xGKovCaJd\n\tnll30+jCWR/a4Z1HWDnLFL/ZO9/fcscEeUTi/82pxGmhfm5AFIcvAFF6qQEmFoPEK9/x\n\thAXkGjlBwZmPSRoSjsbtdmn4/2mnppmW2rZz0LikNyLMk+/A5eCB63YcZ8Mz+KSBc65C\n\tf4fZvR/WvfdyPXE3O7zGS6+1ICzFpgWvFyHUYA+qmMYX+Ho23DCB9Cv5p9EnfBaFPUpw\n\t697QXPs+kpGHZ1sj+yISEsG18ssPdC42E5c2Lbd6AIz9gwL76BVlQxDHUqzkB4nOJJDM\n\trzKg==", "X-Gm-Message-State": "AHPjjUgDbmBFWZolEB2QI1nVURjgnPC4uUpSQESAHNB3pQys0jafecEu\n\tPn2paXVNi/ro5cAAP8eyg+E5Hmt6HVo=", "X-Google-Smtp-Source": "AOwi7QAFb9qltYmvIRokcGdT8iR6AYYdm+RN8YKybatACZMnTiCpc4/HwwaNBNZuePywAW1ZBz+5mg==", "X-Received": "by 10.99.113.94 with SMTP id b30mr12036012pgn.312.1506456883824; \n\tTue, 26 Sep 2017 13:14:43 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 26 Sep 2017 13:14:27 -0700", "Message-Id": "<20170926201427.2833-10-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170926201427.2833-1-richard.henderson@linaro.org>", "References": "<20170926201427.2833-1-richard.henderson@linaro.org>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400e:c05::22f", "Subject": "[Qemu-devel] [PATCH v3 9/9] disas: Add capstone as submodule", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, qemu-ppc@nongnu.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Do not require the submodule, but use it if present (in preference\neven to a system copy). This will allow us to easily use capstone\nin older systems for which a package is not available, and also\neasily track bug fixes from upstream.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n Makefile | 4 ++++\n .gitmodules | 3 +++\n capstone | 1 +\n configure | 12 +++++++++++-\n 4 files changed, 19 insertions(+), 1 deletion(-)\n create mode 160000 capstone", "diff": "diff --git a/Makefile b/Makefile\nindex 2be61fcf1c..4723a65e9c 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -335,6 +335,10 @@ subdir-dtc:dtc/libfdt dtc/tests\n dtc/%:\n \tmkdir -p $@\n \n+# ??? Overriding CFLAGS causes us to lose defines added in the sub-makefile.\n+subdir-capstone:\n+\t$(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone CAPSTONE_SHARED=no BUILDDIR=\"$(BUILD_DIR)/capstone\" CC=\"$(CC)\" AR=\"$(AR)\" LD=\"$(LD)\" $(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/libcapstone.a)\n+\n $(SUBDIR_RULES): libqemuutil.a $(common-obj-y) $(chardev-obj-y) \\\n \t$(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY))\n \ndiff --git a/.gitmodules b/.gitmodules\nindex 84c54cdc49..bcb80d701a 100644\n--- a/.gitmodules\n+++ b/.gitmodules\n@@ -34,3 +34,6 @@\n [submodule \"roms/QemuMacDrivers\"]\n \tpath = roms/QemuMacDrivers\n \turl = git://git.qemu.org/QemuMacDrivers.git\n+[submodule \"capstone\"]\n+\tpath = capstone\n+\turl = https://github.com/aquynh/capstone.git\ndiff --git a/capstone b/capstone\nnew file mode 160000\nindex 0000000000..a279481dbf\n--- /dev/null\n+++ b/capstone\n@@ -0,0 +1 @@\n+Subproject commit a279481dbfd54bb1e2336d771e89978cc6d43176\ndiff --git a/configure b/configure\nindex 62d172d88a..b0c30992ff 100755\n--- a/configure\n+++ b/configure\n@@ -4378,7 +4378,14 @@ fi\n # capstone\n \n if test \"$capstone\" != no; then\n- if $pkg_config capstone; then\n+ if test -d ${source_path}/capstone ; then\n+ # have submodule capstone - use it\n+ capstone=yes\n+ capstone_internal=yes\n+ mkdir -p capstone\n+ QEMU_CFLAGS=\"$QEMU_CFLAGS -I\\$(SRC_PATH)/capstone/include\"\n+ LIBS=\"\\$(BUILD_DIR)/capstone/libcapstone.a $LIBS\"\n+ elif $pkg_config capstone; then\n capstone=yes\n QEMU_CFLAGS=\"$QEMU_CFLAGS $($pkg_config --cflags capstone)\"\n LIBS=\"$($pkg_config --libs capstone) $LIBS\"\n@@ -6577,6 +6584,9 @@ done # for target in $targets\n if [ \"$dtc_internal\" = \"yes\" ]; then\n echo \"config-host.h: subdir-dtc\" >> $config_host_mak\n fi\n+if [ \"$capstone_internal\" = \"yes\" ]; then\n+ echo \"config-host.h: subdir-capstone\" >> $config_host_mak\n+fi\n \n if test \"$numa\" = \"yes\"; then\n echo \"CONFIG_NUMA=y\" >> $config_host_mak\n", "prefixes": [ "v3", "9/9" ] }