Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/818788/?format=api
{ "id": 818788, "url": "http://patchwork.ozlabs.org/api/patches/818788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170926192142.42308-2-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170926192142.42308-2-sjg@chromium.org>", "list_archive_url": null, "date": "2017-09-26T19:21:29", "name": "[U-Boot,v2,01/14] Revert \"sandbox: remove os_putc() and os_puts()\"", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2532e1aad56ac51a17e1c17d490b7241c5d2363d", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170926192142.42308-2-sjg@chromium.org/mbox/", "series": [ { "id": 5217, "url": "http://patchwork.ozlabs.org/api/series/5217/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=5217", "date": "2017-09-26T19:21:28", "name": "log: Add a new logging feature", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/5217/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/818788/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/818788/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"lIZGmCJm\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1rSW6qJtz9t4Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 05:22:35 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 9F7F8C21F3C; Tue, 26 Sep 2017 19:22:31 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C6B97C21E70;\n\tTue, 26 Sep 2017 19:22:24 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 38232C21E68; Tue, 26 Sep 2017 19:22:10 +0000 (UTC)", "from mail-oi0-f43.google.com (mail-oi0-f43.google.com\n\t[209.85.218.43])\n\tby lists.denx.de (Postfix) with ESMTPS id DB04AC21F3A\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 19:22:08 +0000 (UTC)", "by mail-oi0-f43.google.com with SMTP id w65so13465264oia.7\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 12:22:08 -0700 (PDT)", "from kiwi.bld.corp.google.com ([2620:0:10f2:0:c194:3fa6:8abc:2569])\n\tby smtp.gmail.com with ESMTPSA id\n\tt205sm10068653oig.53.2017.09.26.12.22.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 12:22:06 -0700 (PDT)", "by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid C5D7E140573; Tue, 26 Sep 2017 13:22:05 -0600 (MDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ZKJM/e9MhRED/wFDueaRUcAgsjH5kXlAvxZ5Bn0nlOU=;\n\tb=lIZGmCJmu0aeVMdhPwLpa96i/jI11vvimSwNC88ZeJ4fYIcGWSmsMK8twb/yQyGqn4\n\tOVY4EGimw1ofuj0pePhnkeXTgtmeXxPC9vezaFH/3pj5DUmAuvoKEBQtik9XaMzwLwRO\n\t2xe0fO/k30avYZPMMJXZh9p/VN3lb6lZ2Ea0DoPKbu6BEW1K4UEaLYmjE4y15/X9oqo6\n\taGh7w1bv4dq6roYSnbjf/8SmPsXsruiVs3me1xSYNm2st3Jr9I3GLyTU0Trc7nQyScKc\n\ttYhHZXx9br0PR4ZZN5wKh2tjGI3SmucoNCad2u4P5/zqkKms/RDYh8hPQe5MHqIddqVv\n\tQpHQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=ZKJM/e9MhRED/wFDueaRUcAgsjH5kXlAvxZ5Bn0nlOU=;\n\tb=uk2rjYboSlglP5f4nDMuJgPrgOrl+KguD8M1dQK/V2CqtyWEOqDdofciYp4yxIlIRK\n\tk8S0llhaQo2rkrjcBqos/3DisDShEL5RT1q1LgnjsyyXrpCGJJFsjpC+tBmeWhK1J/Qv\n\tLqYO2oyTh2dyC99sFP/rF+GwON8gPggJdV3P6Y/HfBXMGiv3NzuVxo0FAPYIjcOJ0ji/\n\tPrhzRuyI0JTayJBPYx44rJEWWTAYh5EzoOX0WvcNq2AjsAMjec1rNddnUzvatMfVWUgz\n\tFPkzRTHT870V3k01Ovmf1xQORvU12yjf1YBpnMyLqSov1+Hqa8egUl+bBHcITtmCJQQ3\n\tlsyg==", "X-Gm-Message-State": "AMCzsaUdcVn6B+45r3BCDT1gntZjDXxtw9096k+PF8D/ylbZgpOa5lF2\n\tgDSvVUohKtKejRd5OH0fcVBcLQ==", "X-Google-Smtp-Source": "AOwi7QBhWdNBI657D4jaUZJVMC13amTvs9e9e3ODEgnNu9FcL51tw0tPyggEQtVpMMS7/6vXiSLe2w==", "X-Received": "by 10.157.22.243 with SMTP id s48mr464425ots.459.1506453727490; \n\tTue, 26 Sep 2017 12:22:07 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Tue, 26 Sep 2017 13:21:29 -0600", "Message-Id": "<20170926192142.42308-2-sjg@chromium.org>", "X-Mailer": "git-send-email 2.14.1.992.g2c7b836f3a-goog", "In-Reply-To": "<20170926192142.42308-1-sjg@chromium.org>", "References": "<20170926192142.42308-1-sjg@chromium.org>", "Cc": "Tom Rini <trini@konsulko.com>", "Subject": "[U-Boot] [PATCH v2 01/14] Revert \"sandbox: remove os_putc() and\n\tos_puts()\"", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "While sandbox works OK without the special-case code, it does result in\nconsole output being stored in the pre-console buffer while sandbox starts\nup. If there is a crash or a problem then there is no indication of what\nis going on.\n\nFor ease of debugging it seems better to revert this change.\n\nThis reverts commit 47b98ad0f6779485d0f0c14f337c3eece273eb54.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\nChanges in v2: None\n\n arch/sandbox/cpu/os.c | 11 +++++++++++\n include/os.h | 20 ++++++++++++++++++++\n 2 files changed, 31 insertions(+)", "diff": "diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c\nindex 22d6aab534..7243bfc1b1 100644\n--- a/arch/sandbox/cpu/os.c\n+++ b/arch/sandbox/cpu/os.c\n@@ -413,6 +413,17 @@ int os_get_filesize(const char *fname, loff_t *size)\n \treturn 0;\n }\n \n+void os_putc(int ch)\n+{\n+\tputchar(ch);\n+}\n+\n+void os_puts(const char *str)\n+{\n+\twhile (*str)\n+\t\tos_putc(*str++);\n+}\n+\n int os_write_ram_buf(const char *fname)\n {\n \tstruct sandbox_state *state = state_get_current();\ndiff --git a/include/os.h b/include/os.h\nindex 2bf4bdb1b8..049b248c5b 100644\n--- a/include/os.h\n+++ b/include/os.h\n@@ -240,6 +240,26 @@ const char *os_dirent_get_typename(enum os_dirent_t type);\n */\n int os_get_filesize(const char *fname, loff_t *size);\n \n+/**\n+ * Write a character to the controlling OS terminal\n+ *\n+ * This bypasses the U-Boot console support and writes directly to the OS\n+ * stdout file descriptor.\n+ *\n+ * @param ch\tCharacter to write\n+ */\n+void os_putc(int ch);\n+\n+/**\n+ * Write a string to the controlling OS terminal\n+ *\n+ * This bypasses the U-Boot console support and writes directly to the OS\n+ * stdout file descriptor.\n+ *\n+ * @param str\tString to write (note that \\n is not appended)\n+ */\n+void os_puts(const char *str);\n+\n /**\n * Write the sandbox RAM buffer to a existing file\n *\n", "prefixes": [ "U-Boot", "v2", "01/14" ] }