Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/818777/?format=api
{ "id": 818777, "url": "http://patchwork.ozlabs.org/api/patches/818777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926183318.12995-5-david@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170926183318.12995-5-david@redhat.com>", "list_archive_url": null, "date": "2017-09-26T18:33:16", "name": "[v1,4/6] s390x/tcg: make stora(g) use the new _real mmu", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a50ec4583110fcda43f9f5fdbe6b6476651014b9", "submitter": { "id": 70402, "url": "http://patchwork.ozlabs.org/api/people/70402/?format=api", "name": "David Hildenbrand", "email": "david@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926183318.12995-5-david@redhat.com/mbox/", "series": [ { "id": 5209, "url": "http://patchwork.ozlabs.org/api/series/5209/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5209", "date": "2017-09-26T18:33:12", "name": "s390x/tcg: fix some accesses using low address", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/5209/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/818777/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/818777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1qRM0LNHz9t3R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 04:36:31 +1000 (AEST)", "from localhost ([::1]:50681 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwuib-0006Js-4G\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 14:36:29 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:45166)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwufo-0004T4-BQ\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:37 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwufn-0003US-D3\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:36 -0400", "from mx1.redhat.com ([209.132.183.28]:58002)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dwufn-0003UJ-6U\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:35 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 43D2115552;\n\tTue, 26 Sep 2017 18:33:34 +0000 (UTC)", "from t460s.redhat.com (ovpn-117-152.ams2.redhat.com\n\t[10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CF62760841;\n\tTue, 26 Sep 2017 18:33:29 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 43D2115552", "From": "David Hildenbrand <david@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 26 Sep 2017 20:33:16 +0200", "Message-Id": "<20170926183318.12995-5-david@redhat.com>", "In-Reply-To": "<20170926183318.12995-1-david@redhat.com>", "References": "<20170926183318.12995-1-david@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 26 Sep 2017 18:33:34 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v1 4/6] s390x/tcg: make stora(g) use the new\n\t_real mmu", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "thuth@redhat.com, David Hildenbrand <david@redhat.com>, cohuck@redhat.com,\n\tAlexander Graf <agraf@suse.de>,\n\tChristian Borntraeger <borntraeger@de.ibm.com>,\n\tRichard Henderson <rth@twiddle.net>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "As we properly handle the return address now, we can drop\npotential_page_fault().\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/mem_helper.c | 8 ++------\n target/s390x/translate.c | 2 --\n 2 files changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c\nindex f8525e05b3..34ffc282bf 100644\n--- a/target/s390x/mem_helper.c\n+++ b/target/s390x/mem_helper.c\n@@ -1985,9 +1985,7 @@ uint64_t HELPER(lurag)(CPUS390XState *env, uint64_t addr)\n /* store using real address */\n void HELPER(stura)(CPUS390XState *env, uint64_t addr, uint64_t v1)\n {\n- CPUState *cs = CPU(s390_env_get_cpu(env));\n-\n- stl_phys(cs->as, wrap_address(env, addr), (uint32_t)v1);\n+ cpu_stl_real_ra(env, wrap_address(env, addr), (uint32_t)v1, GETPC());\n \n if ((env->psw.mask & PSW_MASK_PER) &&\n (env->cregs[9] & PER_CR9_EVENT_STORE) &&\n@@ -2000,9 +1998,7 @@ void HELPER(stura)(CPUS390XState *env, uint64_t addr, uint64_t v1)\n \n void HELPER(sturg)(CPUS390XState *env, uint64_t addr, uint64_t v1)\n {\n- CPUState *cs = CPU(s390_env_get_cpu(env));\n-\n- stq_phys(cs->as, wrap_address(env, addr), v1);\n+ cpu_stq_real_ra(env, wrap_address(env, addr), v1, GETPC());\n \n if ((env->psw.mask & PSW_MASK_PER) &&\n (env->cregs[9] & PER_CR9_EVENT_STORE) &&\ndiff --git a/target/s390x/translate.c b/target/s390x/translate.c\nindex d0ce14d120..ee93fce482 100644\n--- a/target/s390x/translate.c\n+++ b/target/s390x/translate.c\n@@ -4063,7 +4063,6 @@ static ExitStatus op_stnosm(DisasContext *s, DisasOps *o)\n static ExitStatus op_stura(DisasContext *s, DisasOps *o)\n {\n check_privileged(s);\n- potential_page_fault(s);\n gen_helper_stura(cpu_env, o->in2, o->in1);\n return NO_EXIT;\n }\n@@ -4071,7 +4070,6 @@ static ExitStatus op_stura(DisasContext *s, DisasOps *o)\n static ExitStatus op_sturg(DisasContext *s, DisasOps *o)\n {\n check_privileged(s);\n- potential_page_fault(s);\n gen_helper_sturg(cpu_env, o->in2, o->in1);\n return NO_EXIT;\n }\n", "prefixes": [ "v1", "4/6" ] }