Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 818738,
    "url": "http://patchwork.ozlabs.org/api/patches/818738/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170926163548.24347-3-phil@nwl.cc/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170926163548.24347-3-phil@nwl.cc>",
    "list_archive_url": null,
    "date": "2017-09-26T16:35:47",
    "name": "[iproute,v2,2/3] tc: flower: No need to cache indev arg",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "c2c6564d1304d54f3c9b14104becb25245fb7d8b",
    "submitter": {
        "id": 4285,
        "url": "http://patchwork.ozlabs.org/api/people/4285/?format=api",
        "name": "Phil Sutter",
        "email": "phil@nwl.cc"
    },
    "delegate": {
        "id": 389,
        "url": "http://patchwork.ozlabs.org/api/users/389/?format=api",
        "username": "shemminger",
        "first_name": "stephen",
        "last_name": "hemminger",
        "email": "shemminger@vyatta.com"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170926163548.24347-3-phil@nwl.cc/mbox/",
    "series": [
        {
            "id": 5182,
            "url": "http://patchwork.ozlabs.org/api/series/5182/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=5182",
            "date": "2017-09-26T16:35:46",
            "name": "Check user supplied interface name lengths",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/5182/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/818738/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/818738/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1nDW1z5Hz9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 02:56:58 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S969239AbdIZQ44 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 12:56:56 -0400",
            "from orbyte.nwl.cc ([151.80.46.58]:58160 \"EHLO orbyte.nwl.cc\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S966076AbdIZQ4z (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 12:56:55 -0400",
            "from localhost ([::1]:52642 helo=xsao)\n\tby orbyte.nwl.cc with esmtp (Exim 4.89)\n\t(envelope-from <phil@nwl.cc>)\n\tid 1dwspz-0008H5-9s; Tue, 26 Sep 2017 18:35:59 +0200"
        ],
        "From": "Phil Sutter <phil@nwl.cc>",
        "To": "Stephen Hemminger <stephen@networkplumber.org>",
        "Cc": "netdev@vger.kernel.org",
        "Subject": "[iproute PATCH v2 2/3] tc: flower: No need to cache indev arg",
        "Date": "Tue, 26 Sep 2017 18:35:47 +0200",
        "Message-Id": "<20170926163548.24347-3-phil@nwl.cc>",
        "X-Mailer": "git-send-email 2.13.1",
        "In-Reply-To": "<20170926163548.24347-1-phil@nwl.cc>",
        "References": "<20170926163548.24347-1-phil@nwl.cc>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Since addattrstrz() will copy the provided string into the attribute\npayload, there is no need to cache the data.\n\nSigned-off-by: Phil Sutter <phil@nwl.cc>\n---\n tc/f_flower.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)",
    "diff": "diff --git a/tc/f_flower.c b/tc/f_flower.c\nindex 934832e2bbe90..99e62a382dec6 100644\n--- a/tc/f_flower.c\n+++ b/tc/f_flower.c\n@@ -629,11 +629,8 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,\n \t\t} else if (matches(*argv, \"skip_sw\") == 0) {\n \t\t\tflags |= TCA_CLS_FLAGS_SKIP_SW;\n \t\t} else if (matches(*argv, \"indev\") == 0) {\n-\t\t\tchar ifname[IFNAMSIZ] = {};\n-\n \t\t\tNEXT_ARG();\n-\t\t\tstrncpy(ifname, *argv, sizeof(ifname) - 1);\n-\t\t\taddattrstrz(n, MAX_MSG, TCA_FLOWER_INDEV, ifname);\n+\t\t\taddattrstrz(n, MAX_MSG, TCA_FLOWER_INDEV, *argv);\n \t\t} else if (matches(*argv, \"vlan_id\") == 0) {\n \t\t\t__u16 vid;\n \n",
    "prefixes": [
        "iproute",
        "v2",
        "2/3"
    ]
}