Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/818583/?format=api
{ "id": 818583, "url": "http://patchwork.ozlabs.org/api/patches/818583/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/150642404260.3900.15791385339764676289.stgit@Misha-PC.lan02.inno/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<150642404260.3900.15791385339764676289.stgit@Misha-PC.lan02.inno>", "list_archive_url": null, "date": "2017-09-26T11:07:22", "name": "[35/43] windbg: debug exception subscribing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ba60c8cf439e0effc15a35033280d618662632c3", "submitter": { "id": 71645, "url": "http://patchwork.ozlabs.org/api/people/71645/?format=api", "name": "Mikhail Abakumov", "email": "mikhail.abakumov@ispras.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/150642404260.3900.15791385339764676289.stgit@Misha-PC.lan02.inno/mbox/", "series": [ { "id": 5104, "url": "http://patchwork.ozlabs.org/api/series/5104/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5104", "date": "2017-09-26T11:04:06", "name": "Windbg supporting", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/5104/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/818583/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/818583/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1fBP4Xbhz9t1G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 21:39:41 +1000 (AEST)", "from localhost ([::1]:46868 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwoDC-0000Dg-Q9\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 07:39:38 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:60168)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mikhail.abakumov@ispras.ru>) id 1dwni7-0005py-C5\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:34 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mikhail.abakumov@ispras.ru>) id 1dwni1-0001cY-Cf\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:31 -0400", "from mail.ispras.ru ([83.149.199.45]:52330)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mikhail.abakumov@ispras.ru>) id 1dwni1-0001c4-1c\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:25 -0400", "from Misha-PC.lan02.inno (unknown [85.142.117.226])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id 237B55400FF;\n\tTue, 26 Sep 2017 14:07:24 +0300 (MSK)" ], "From": "Mihail Abakumov <mikhail.abakumov@ispras.ru>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 26 Sep 2017 14:07:22 +0300", "Message-ID": "<150642404260.3900.15791385339764676289.stgit@Misha-PC.lan02.inno>", "In-Reply-To": "<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>", "References": "<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "83.149.199.45", "Subject": "[Qemu-devel] [PATCH 35/43] windbg: debug exception subscribing", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru,\n\trkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Added handler registration of gdb debug exception. Its exception also can be used for windbg.\n\nSigned-off-by: Mihail Abakumov <mikhail.abakumov@ispras.ru>\nSigned-off-by: Pavel Dovgalyuk <dovgaluk@ispras.ru>\nSigned-off-by: Dmitriy Koltunov <koltunov@ispras.ru>\n---\n cpus.c | 18 +++++++++++++++++-\n gdbstub.c | 4 ++++\n include/sysemu/sysemu.h | 2 ++\n windbgstub.c | 16 ++++++++++++----\n 4 files changed, 35 insertions(+), 5 deletions(-)", "diff": "diff --git a/cpus.c b/cpus.c\nindex 9bed61eefc..212553b7e3 100644\n--- a/cpus.c\n+++ b/cpus.c\n@@ -77,6 +77,8 @@ int64_t max_advance;\n static QEMUTimer *throttle_timer;\n static unsigned int throttle_percentage;\n \n+static void (*excp_debug_handler)(CPUState *cpu);\n+\n #define CPU_THROTTLE_PCT_MIN 1\n #define CPU_THROTTLE_PCT_MAX 99\n #define CPU_THROTTLE_TIMESLICE_NS 10000000\n@@ -960,9 +962,23 @@ static bool cpu_can_run(CPUState *cpu)\n return true;\n }\n \n+bool register_excp_debug_handler(void (*handler)(CPUState *cpu))\n+{\n+ if (excp_debug_handler == NULL) {\n+ excp_debug_handler = handler;\n+ return true;\n+ } else {\n+ error_report(\"ERROR: Something debugger already using\");\n+ return false;\n+ }\n+}\n+\n static void cpu_handle_guest_debug(CPUState *cpu)\n {\n- gdb_set_stop_cpu(cpu);\n+ if (excp_debug_handler != NULL) {\n+ excp_debug_handler(cpu);\n+ }\n+\n qemu_system_debug_request();\n cpu->stopped = true;\n }\ndiff --git a/gdbstub.c b/gdbstub.c\nindex 2a94030d3b..8c76f54117 100644\n--- a/gdbstub.c\n+++ b/gdbstub.c\n@@ -2006,6 +2006,10 @@ int gdbserver_start(const char *device)\n s->mon_chr = mon_chr;\n s->current_syscall_cb = NULL;\n \n+ if (!register_excp_debug_handler(gdb_set_stop_cpu)) {\n+ exit(1);\n+ }\n+\n return 0;\n }\n \ndiff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h\nindex b21369672a..34588c99b4 100644\n--- a/include/sysemu/sysemu.h\n+++ b/include/sysemu/sysemu.h\n@@ -193,6 +193,8 @@ QemuOpts *qemu_get_machine_opts(void);\n \n bool defaults_enabled(void);\n \n+bool register_excp_debug_handler(void (*handler)(CPUState *cpu));\n+\n extern QemuOptsList qemu_legacy_drive_opts;\n extern QemuOptsList qemu_common_drive_opts;\n extern QemuOptsList qemu_drive_opts;\ndiff --git a/windbgstub.c b/windbgstub.c\nindex f8e80c60ab..54564962a5 100755\n--- a/windbgstub.c\n+++ b/windbgstub.c\n@@ -112,16 +112,20 @@ static void windbg_send_control_packet(uint16_t type)\n windbg_state->ctrl_packet_id ^= 1;\n }\n \n-static void windbg_vm_stop(void)\n+static void windbg_bp_handler(CPUState *cpu)\n {\n- CPUState *cpu = qemu_get_cpu(0);\n- vm_stop(RUN_STATE_PAUSED);\n-\n SizedBuf buf = kd_gen_exception_sc(cpu);\n windbg_send_data_packet(buf.data, buf.size, PACKET_TYPE_KD_STATE_CHANGE64);\n SBUF_FREE(buf);\n }\n \n+static void windbg_vm_stop(void)\n+{\n+ CPUState *cpu = qemu_get_cpu(0);\n+ vm_stop(RUN_STATE_PAUSED);\n+ windbg_bp_handler(cpu);\n+}\n+\n static void windbg_process_manipulate_packet(ParsingContext *ctx)\n {\n CPUState *cpu;\n@@ -406,6 +410,10 @@ int windbg_server_start(const char *device)\n qemu_chr_fe_set_handlers(&windbg_state->chr, windbg_chr_can_receive,\n windbg_chr_receive, NULL, NULL, NULL, NULL, true);\n \n+ if (!register_excp_debug_handler(windbg_bp_handler)) {\n+ exit(1);\n+ }\n+\n atexit(windbg_exit);\n return 0;\n }\n", "prefixes": [ "35/43" ] }