Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/818275/?format=api
{ "id": 818275, "url": "http://patchwork.ozlabs.org/api/patches/818275/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925145526.32690-2-eblake@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170925145526.32690-2-eblake@redhat.com>", "list_archive_url": null, "date": "2017-09-25T14:55:07", "name": "[v10,01/20] block: Make bdrv_img_create() size selection easier to read", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4f54a99c043ec77fc461d518ff80177b97862e28", "submitter": { "id": 6591, "url": "http://patchwork.ozlabs.org/api/people/6591/?format=api", "name": "Eric Blake", "email": "eblake@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925145526.32690-2-eblake@redhat.com/mbox/", "series": [ { "id": 4978, "url": "http://patchwork.ozlabs.org/api/series/4978/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4978", "date": "2017-09-25T14:55:06", "name": "make dirty-bitmap byte-based", "version": 10, "mbox": "http://patchwork.ozlabs.org/series/4978/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/818275/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/818275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y16cN0bWhz9tXC\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 00:56:52 +1000 (AEST)", "from localhost ([::1]:42830 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwUoU-0005ks-46\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 10:56:50 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:53964)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dwUnd-0005hm-N8\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 10:55:59 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dwUnc-00039h-Tw\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 10:55:57 -0400", "from mx1.redhat.com ([209.132.183.28]:52382)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>)\n\tid 1dwUnV-00035S-S1; Mon, 25 Sep 2017 10:55:49 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C73D781E07;\n\tMon, 25 Sep 2017 14:55:48 +0000 (UTC)", "from red.redhat.com (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8FCA778384;\n\tMon, 25 Sep 2017 14:55:46 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com C73D781E07", "From": "Eric Blake <eblake@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 25 Sep 2017 09:55:07 -0500", "Message-Id": "<20170925145526.32690-2-eblake@redhat.com>", "In-Reply-To": "<20170925145526.32690-1-eblake@redhat.com>", "References": "<20170925145526.32690-1-eblake@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 25 Sep 2017 14:55:48 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v10 01/20] block: Make bdrv_img_create() size\n\tselection easier to read", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "kwolf@redhat.com, vsementsov@virtuozzo.com, famz@redhat.com,\n\tqemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>, jsnow@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "All callers of bdrv_img_create() pass in a size, or -1 to read the\nsize from the backing file. We then set that size as the QemuOpt\ndefault, which means we will reuse that default rather than the\nfinal parameter to qemu_opt_get_size() several lines later. But\nit is rather confusing to read subsequent checks of 'size == -1'\nwhen it looks (without seeing the full context) like size defaults\nto 0; it also doesn't help that a size of 0 is valid (for some\nformats).\n\nRework the logic to make things more legible.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nReviewed-by: Kevin Wolf <kwolf@redhat.com>\nReviewed-by: Fam Zheng <famz@redhat.com>\n\n---\nv6: Combine into a series rather than being a standalone patch (more for\nease of tracking than for being on topic)\n---\n block.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/block.c b/block.c\nindex 5c65fac672..528cda7b2c 100644\n--- a/block.c\n+++ b/block.c\n@@ -4488,7 +4488,7 @@ void bdrv_img_create(const char *filename, const char *fmt,\n\n /* The size for the image must always be specified, unless we have a backing\n * file and we have not been forbidden from opening it. */\n- size = qemu_opt_get_size(opts, BLOCK_OPT_SIZE, 0);\n+ size = qemu_opt_get_size(opts, BLOCK_OPT_SIZE, img_size);\n if (backing_file && !(flags & BDRV_O_NO_BACKING)) {\n BlockDriverState *bs;\n char *full_backing = g_new0(char, PATH_MAX);\n", "prefixes": [ "v10", "01/20" ] }