Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/818221/?format=api
{ "id": 818221, "url": "http://patchwork.ozlabs.org/api/patches/818221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925122808.14561-4-kwolf@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170925122808.14561-4-kwolf@redhat.com>", "list_archive_url": null, "date": "2017-09-25T12:28:06", "name": "[3/5] qemu-iotests: Allow QMP pretty printing in common.qemu", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5f0a3a0f21640006bf2bf99d8729d899451c4ea6", "submitter": { "id": 2714, "url": "http://patchwork.ozlabs.org/api/people/2714/?format=api", "name": "Kevin Wolf", "email": "kwolf@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925122808.14561-4-kwolf@redhat.com/mbox/", "series": [ { "id": 4949, "url": "http://patchwork.ozlabs.org/api/series/4949/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4949", "date": "2017-09-25T12:28:05", "name": "commit: Support multiple roots above top node", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4949/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/818221/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/818221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y13L83RNWz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 25 Sep 2017 22:29:20 +1000 (AEST)", "from localhost ([::1]:42258 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwSVi-0003lX-Fv\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 08:29:18 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:47284)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <kwolf@redhat.com>) id 1dwSUs-0003eO-4Y\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 08:28:30 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <kwolf@redhat.com>) id 1dwSUm-000650-Gy\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 08:28:26 -0400", "from mx1.redhat.com ([209.132.183.28]:45324)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <kwolf@redhat.com>)\n\tid 1dwSUj-00063R-TB; Mon, 25 Sep 2017 08:28:18 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D5269C0587DE;\n\tMon, 25 Sep 2017 12:28:16 +0000 (UTC)", "from localhost.localdomain.com (ovpn-116-119.ams2.redhat.com\n\t[10.36.116.119])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9AF2A70A10;\n\tMon, 25 Sep 2017 12:28:15 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com D5269C0587DE", "From": "Kevin Wolf <kwolf@redhat.com>", "To": "qemu-block@nongnu.org", "Date": "Mon, 25 Sep 2017 14:28:06 +0200", "Message-Id": "<20170925122808.14561-4-kwolf@redhat.com>", "In-Reply-To": "<20170925122808.14561-1-kwolf@redhat.com>", "References": "<20170925122808.14561-1-kwolf@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tMon, 25 Sep 2017 12:28:16 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in\n\tcommon.qemu", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "QMP responses to certain commands can become quite long, which doesn't\nonly make reading them hard, but also means that the maximum line length\nin patch emails can be exceeded. Allow tests to switch to QMP pretty\nprinting, which results in more, but shorter lines.\n\nWe also need to make sure to keep indentation in the response for this\nto work as expected.\n\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\n---\n tests/qemu-iotests/common.qemu | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu\nindex 7645f1dc72..92739a1eac 100644\n--- a/tests/qemu-iotests/common.qemu\n+++ b/tests/qemu-iotests/common.qemu\n@@ -55,13 +55,13 @@ function _timed_wait_for()\n shift\n \n QEMU_STATUS[$h]=0\n- while read -t ${QEMU_COMM_TIMEOUT} resp <&${QEMU_OUT[$h]}\n+ while IFS= read -t ${QEMU_COMM_TIMEOUT} resp <&${QEMU_OUT[$h]}\n do\n if [ -z \"${silent}\" ]; then\n echo \"${resp}\" | _filter_testdir | _filter_qemu \\\n | _filter_qemu_io | _filter_qmp | _filter_hmp\n fi\n- grep -q \"${*}\" < <(echo ${resp})\n+ grep -q \"${*}\" < <(echo \"${resp}\")\n if [ $? -eq 0 ]; then\n return\n fi\n@@ -129,6 +129,7 @@ function _send_qemu_cmd()\n # $qemu_comm_method: set this variable to 'monitor' (case insensitive)\n # to use the QEMU HMP monitor for communication.\n # Otherwise, the default of QMP is used.\n+# $qmp_pretty: Set this variable to 'y' to enable QMP pretty printing.\n # $keep_stderr: Set this variable to 'y' to keep QEMU's stderr output on stderr.\n # If this variable is empty, stderr will be redirected to stdout.\n # Returns:\n@@ -145,7 +146,11 @@ function _launch_qemu()\n comm=\"-monitor stdio\"\n else\n local qemu_comm_method=\"qmp\"\n- comm=\"-monitor none -qmp stdio\"\n+ if [ \"$qmp_pretty\" = \"y\" ]; then\n+ comm=\"-monitor none -qmp-pretty stdio\"\n+ else\n+ comm=\"-monitor none -qmp stdio\"\n+ fi\n fi\n \n fifo_out=${QEMU_FIFO_OUT}_${_QEMU_HANDLE}\n@@ -192,6 +197,9 @@ function _launch_qemu()\n then\n # Don't print response, since it has version information in it\n silent=yes _timed_wait_for ${_QEMU_HANDLE} \"capabilities\"\n+ if [ \"$qmp_pretty\" = \"y\" ]; then\n+ silent=yes _timed_wait_for ${_QEMU_HANDLE} \"^}\"\n+ fi\n fi\n QEMU_HANDLE=${_QEMU_HANDLE}\n let _QEMU_HANDLE++\n", "prefixes": [ "3/5" ] }