Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 818191,
    "url": "http://patchwork.ozlabs.org/api/patches/818191/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170925110738.68382-11-mika.westerberg@linux.intel.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170925110738.68382-11-mika.westerberg@linux.intel.com>",
    "list_archive_url": null,
    "date": "2017-09-25T11:07:32",
    "name": "[v2,10/16] thunderbolt: Move ring descriptor flags to thunderbolt.h",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "83785e4a197494c722ad1141f4b6ae041e0da3c7",
    "submitter": {
        "id": 14534,
        "url": "http://patchwork.ozlabs.org/api/people/14534/?format=api",
        "name": "Mika Westerberg",
        "email": "mika.westerberg@linux.intel.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170925110738.68382-11-mika.westerberg@linux.intel.com/mbox/",
    "series": [
        {
            "id": 4937,
            "url": "http://patchwork.ozlabs.org/api/series/4937/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4937",
            "date": "2017-09-25T11:07:27",
            "name": "Thunderbolt networking",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/4937/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/818191/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/818191/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y11bg18sVz9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 25 Sep 2017 21:10:55 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934923AbdIYLHu (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 25 Sep 2017 07:07:50 -0400",
            "from mga04.intel.com ([192.55.52.120]:15186 \"EHLO mga04.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S934895AbdIYLHr (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 25 Sep 2017 07:07:47 -0400",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Sep 2017 04:07:46 -0700",
            "from black.fi.intel.com ([10.237.72.28])\n\tby FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2017 04:07:43 -0700",
            "by black.fi.intel.com (Postfix, from userid 1001)\n\tid D5DF846D; Mon, 25 Sep 2017 14:07:38 +0300 (EEST)"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.42,435,1500966000\"; d=\"scan'208\";a=\"903572252\"",
        "From": "Mika Westerberg <mika.westerberg@linux.intel.com>",
        "To": "Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\t\"David S . Miller\" <davem@davemloft.net>",
        "Cc": "Andreas Noever <andreas.noever@gmail.com>,\n\tMichael Jamet <michael.jamet@intel.com>,\n\tYehezkel Bernat <yehezkel.bernat@intel.com>,\n\tAmir Levy <amir.jer.levy@intel.com>,\n\tMario.Limonciello@dell.com, Lukas Wunner <lukas@wunner.de>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>,\n\tAndrew Lunn <andrew@lunn.ch>,\n\tMika Westerberg <mika.westerberg@linux.intel.com>,\n\tlinux-kernel@vger.kernel.org, netdev@vger.kernel.org",
        "Subject": "[PATCH v2 10/16] thunderbolt: Move ring descriptor flags to\n\tthunderbolt.h",
        "Date": "Mon, 25 Sep 2017 14:07:32 +0300",
        "Message-Id": "<20170925110738.68382-11-mika.westerberg@linux.intel.com>",
        "X-Mailer": "git-send-email 2.14.1",
        "In-Reply-To": "<20170925110738.68382-1-mika.westerberg@linux.intel.com>",
        "References": "<20170925110738.68382-1-mika.westerberg@linux.intel.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "A Thunderbolt service driver might need to check if there was an error\nwith the descriptor when in frame mode. We also add two Rx specific\nerror flags RING_DESC_CRC_ERROR and RING_DESC_BUFFER_OVERRUN.\n\nSigned-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>\nReviewed-by: Michael Jamet <michael.jamet@intel.com>\nReviewed-by: Yehezkel Bernat <yehezkel.bernat@intel.com>\n---\n drivers/thunderbolt/nhi_regs.h |  7 -------\n include/linux/thunderbolt.h    | 18 ++++++++++++++++++\n 2 files changed, 18 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/thunderbolt/nhi_regs.h b/drivers/thunderbolt/nhi_regs.h\nindex 491a4c0c18fc..5ed6934e31e7 100644\n--- a/drivers/thunderbolt/nhi_regs.h\n+++ b/drivers/thunderbolt/nhi_regs.h\n@@ -17,13 +17,6 @@ enum ring_flags {\n \tRING_FLAG_ENABLE = 1 << 31,\n };\n \n-enum ring_desc_flags {\n-\tRING_DESC_ISOCH = 0x1, /* TX only? */\n-\tRING_DESC_COMPLETED = 0x2, /* set by NHI */\n-\tRING_DESC_POSTED = 0x4, /* always set this */\n-\tRING_DESC_INTERRUPT = 0x8, /* request an interrupt on completion */\n-};\n-\n /**\n  * struct ring_desc - TX/RX ring entry\n  *\ndiff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h\nindex 9ddb83ad890f..e3b9af7be0ad 100644\n--- a/include/linux/thunderbolt.h\n+++ b/include/linux/thunderbolt.h\n@@ -478,6 +478,24 @@ struct tb_ring {\n struct ring_frame;\n typedef void (*ring_cb)(struct tb_ring *, struct ring_frame *, bool canceled);\n \n+/**\n+ * enum ring_desc_flags - Flags for DMA ring descriptor\n+ * %RING_DESC_ISOCH: Enable isonchronous DMA (Tx only)\n+ * %RING_DESC_CRC_ERROR: In frame mode CRC check failed for the frame (Rx only)\n+ * %RING_DESC_COMPLETED: Descriptor completed (set by NHI)\n+ * %RING_DESC_POSTED: Always set this\n+ * %RING_DESC_BUFFER_OVERRUN: RX buffer overrun\n+ * %RING_DESC_INTERRUPT: Request an interrupt on completion\n+ */\n+enum ring_desc_flags {\n+\tRING_DESC_ISOCH = 0x1,\n+\tRING_DESC_CRC_ERROR = 0x1,\n+\tRING_DESC_COMPLETED = 0x2,\n+\tRING_DESC_POSTED = 0x4,\n+\tRING_DESC_BUFFER_OVERRUN = 0x04,\n+\tRING_DESC_INTERRUPT = 0x8,\n+};\n+\n /**\n  * struct ring_frame - For use with ring_rx/ring_tx\n  * @buffer_phy: DMA mapped address of the frame\n",
    "prefixes": [
        "v2",
        "10/16"
    ]
}