Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817910/?format=api
{ "id": 817910, "url": "http://patchwork.ozlabs.org/api/patches/817910/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1506264466-28252-2-git-send-email-mark.cave-ayland@ilande.co.uk/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1506264466-28252-2-git-send-email-mark.cave-ayland@ilande.co.uk>", "list_archive_url": null, "date": "2017-09-24T14:47:40", "name": "[1/7] mac_dbdma: remove unused IO fields from DBDMAState", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "32901a1c17742361414fa0156f849859f9a4acca", "submitter": { "id": 12451, "url": "http://patchwork.ozlabs.org/api/people/12451/?format=api", "name": "Mark Cave-Ayland", "email": "mark.cave-ayland@ilande.co.uk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1506264466-28252-2-git-send-email-mark.cave-ayland@ilande.co.uk/mbox/", "series": [ { "id": 4817, "url": "http://patchwork.ozlabs.org/api/series/4817/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4817", "date": "2017-09-24T14:47:39", "name": "mac_dbdma: tidy-up and QOMify", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4817/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817910/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0VVx5pnbz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 25 Sep 2017 00:50:01 +1000 (AEST)", "from localhost ([::1]:38420 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dw8EJ-0003YV-Rn\n\tfor incoming@patchwork.ozlabs.org; Sun, 24 Sep 2017 10:49:59 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:57141)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1dw8Cb-0002gT-A8\n\tfor qemu-devel@nongnu.org; Sun, 24 Sep 2017 10:48:14 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1dw8Ca-0002H8-E9\n\tfor qemu-devel@nongnu.org; Sun, 24 Sep 2017 10:48:13 -0400", "from chuckie.co.uk ([82.165.15.123]:49763\n\thelo=s16892447.onlinehome-server.info)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mark.cave-ayland@ilande.co.uk>)\n\tid 1dw8CW-000292-Gq; Sun, 24 Sep 2017 10:48:08 -0400", "from host86-191-82-173.range86-191.btcentralplus.com\n\t([86.191.82.173] helo=kentang.home)\n\tby s16892447.onlinehome-server.info with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76)\n\t(envelope-from <mark.cave-ayland@ilande.co.uk>)\n\tid 1dw8CR-0006gI-DU; Sun, 24 Sep 2017 15:48:04 +0100" ], "From": "Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>", "To": "qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au", "Date": "Sun, 24 Sep 2017 15:47:40 +0100", "Message-Id": "<1506264466-28252-2-git-send-email-mark.cave-ayland@ilande.co.uk>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1506264466-28252-1-git-send-email-mark.cave-ayland@ilande.co.uk>", "References": "<1506264466-28252-1-git-send-email-mark.cave-ayland@ilande.co.uk>", "X-SA-Exim-Connect-IP": "86.191.82.173", "X-SA-Exim-Mail-From": "mark.cave-ayland@ilande.co.uk", "X-SA-Exim-Version": "4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000)", "X-SA-Exim-Scanned": "Yes (on s16892447.onlinehome-server.info)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "82.165.15.123", "Subject": "[Qemu-devel] [PATCH 1/7] mac_dbdma: remove unused IO fields from\n\tDBDMAState", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "These fields were used to manually handle IO requests that weren't aligned\nto a sector boundary before this feature was supported by the block API.\n\nOnce the block API changed to support byte-aligned IO requests, the macio\ncontroller was switched over to use it in commit be1e343 but these fields\nwere accidentally left behind. Remove them, including the initialisation\nin DBDMA_init().\n\nSigned-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>\n---\n hw/misc/macio/mac_dbdma.c | 2 --\n include/hw/ppc/mac_dbdma.h | 4 ----\n 2 files changed, 6 deletions(-)", "diff": "diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_dbdma.c\nindex 3fe5073..9795172 100644\n--- a/hw/misc/macio/mac_dbdma.c\n+++ b/hw/misc/macio/mac_dbdma.c\n@@ -893,9 +893,7 @@ void* DBDMA_init (MemoryRegion **dbdma_mem)\n s = g_malloc0(sizeof(DBDMAState));\n \n for (i = 0; i < DBDMA_CHANNELS; i++) {\n- DBDMA_io *io = &s->channels[i].io;\n DBDMA_channel *ch = &s->channels[i];\n- qemu_iovec_init(&io->iov, 1);\n \n ch->rw = dbdma_unassigned_rw;\n ch->flush = dbdma_unassigned_flush;\ndiff --git a/include/hw/ppc/mac_dbdma.h b/include/hw/ppc/mac_dbdma.h\nindex a860387..21bd66f 100644\n--- a/include/hw/ppc/mac_dbdma.h\n+++ b/include/hw/ppc/mac_dbdma.h\n@@ -42,10 +42,6 @@ struct DBDMA_io {\n DBDMA_end dma_end;\n /* DMA is in progress, don't start another one */\n bool processing;\n- /* unaligned last sector of a request */\n- uint8_t head_remainder[0x200];\n- uint8_t tail_remainder[0x200];\n- QEMUIOVector iov;\n /* DMA request */\n void *dma_mem;\n dma_addr_t dma_len;\n", "prefixes": [ "1/7" ] }