Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817679/?format=api
{ "id": 817679, "url": "http://patchwork.ozlabs.org/api/patches/817679/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170922194045.18814-3-vivien.didelot@savoirfairelinux.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170922194045.18814-3-vivien.didelot@savoirfairelinux.com>", "list_archive_url": null, "date": "2017-09-22T19:40:44", "name": "[net-next,v2,2/3] net: dsa: make slave close symmetrical to open", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "330bd6bf756cfbdc9ff51e06e85e6a64980ec72f", "submitter": { "id": 15889, "url": "http://patchwork.ozlabs.org/api/people/15889/?format=api", "name": "Vivien Didelot", "email": "vivien.didelot@savoirfairelinux.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170922194045.18814-3-vivien.didelot@savoirfairelinux.com/mbox/", "series": [ { "id": 4699, "url": "http://patchwork.ozlabs.org/api/series/4699/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4699", "date": "2017-09-22T19:40:43", "name": "net: dsa: use slave device phydev", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/4699/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817679/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817679/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzP8X4BX2z9t32\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 23 Sep 2017 05:45:16 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752111AbdIVTpD (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 15:45:03 -0400", "from mail.savoirfairelinux.com ([208.88.110.44]:53380 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1751866AbdIVTo0 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 15:44:26 -0400", "from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 378B39C2D0B;\n\tFri, 22 Sep 2017 15:44:26 -0400 (EDT)", "from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id xS3XEWt2Isek; Fri, 22 Sep 2017 15:44:24 -0400 (EDT)", "from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id D4B769C1A1A;\n\tFri, 22 Sep 2017 15:44:24 -0400 (EDT)", "from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id GuhvWw5LrUDP; Fri, 22 Sep 2017 15:44:24 -0400 (EDT)", "from weeman.mtl.sfl (unknown [192.168.49.104])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id AA5429C2C4A;\n\tFri, 22 Sep 2017 15:44:24 -0400 (EDT)" ], "X-Virus-Scanned": "amavisd-new at mail.savoirfairelinux.com", "From": "Vivien Didelot <vivien.didelot@savoirfairelinux.com>", "To": "netdev@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tFlorian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>,\n\tVivien Didelot <vivien.didelot@savoirfairelinux.com>", "Subject": "[PATCH net-next v2 2/3] net: dsa: make slave close symmetrical to\n\topen", "Date": "Fri, 22 Sep 2017 15:40:44 -0400", "Message-Id": "<20170922194045.18814-3-vivien.didelot@savoirfairelinux.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170922194045.18814-1-vivien.didelot@savoirfairelinux.com>", "References": "<20170922194045.18814-1-vivien.didelot@savoirfairelinux.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The DSA slave open function configures the unicast MAC addresses on the\nmaster device, enable the switch port, change its STP state, then start\nthe PHY device.\n\nMake the close function symmetric, by first stopping the PHY device,\nthen changing the STP state, disabling the switch port and restore the\nmaster device.\n\nSigned-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\nReviewed-by: Florian Fainelli <f.fainelli@gmail.com>\nReviewed-by: Andrew Lunn <andrew@lunn.ch>\n---\n net/dsa/slave.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/net/dsa/slave.c b/net/dsa/slave.c\nindex 3760472bf41d..0aab29928152 100644\n--- a/net/dsa/slave.c\n+++ b/net/dsa/slave.c\n@@ -133,6 +133,11 @@ static int dsa_slave_close(struct net_device *dev)\n \tif (dev->phydev)\n \t\tphy_stop(dev->phydev);\n \n+\tdsa_port_set_state_now(p->dp, BR_STATE_DISABLED);\n+\n+\tif (ds->ops->port_disable)\n+\t\tds->ops->port_disable(ds, p->dp->index, dev->phydev);\n+\n \tdev_mc_unsync(master, dev);\n \tdev_uc_unsync(master, dev);\n \tif (dev->flags & IFF_ALLMULTI)\n@@ -143,11 +148,6 @@ static int dsa_slave_close(struct net_device *dev)\n \tif (!ether_addr_equal(dev->dev_addr, master->dev_addr))\n \t\tdev_uc_del(master, dev->dev_addr);\n \n-\tif (ds->ops->port_disable)\n-\t\tds->ops->port_disable(ds, p->dp->index, dev->phydev);\n-\n-\tdsa_port_set_state_now(p->dp, BR_STATE_DISABLED);\n-\n \treturn 0;\n }\n \n", "prefixes": [ "net-next", "v2", "2/3" ] }