Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817647/?format=api
{ "id": 817647, "url": "http://patchwork.ozlabs.org/api/patches/817647/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170922171348.17630-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170922171348.17630-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-09-22T17:13:48", "name": "[V3] e1000: avoid null pointer dereference on invalid stat type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "406e79a4b75f6c963b05fe4d6bf472c3c948bbae", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170922171348.17630-1-colin.king@canonical.com/mbox/", "series": [ { "id": 4678, "url": "http://patchwork.ozlabs.org/api/series/4678/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=4678", "date": "2017-09-22T17:13:48", "name": "[V3] e1000: avoid null pointer dereference on invalid stat type", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/4678/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817647/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzKnw1S0Zz9sP1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 03:13:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4D1AB8A2EC;\n\tFri, 22 Sep 2017 17:13:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PI6Sr4cLnNiZ; Fri, 22 Sep 2017 17:13:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 741428A2CE;\n\tFri, 22 Sep 2017 17:13:53 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1143A1C0599\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 17:13:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0861F8124A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 17:13:52 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0wjbgYFlfAyB for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 17:13:51 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4A66C89A8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 17:13:51 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1dvRWO-0001GT-Vm; Fri, 22 Sep 2017 17:13:49 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Fri, 22 Sep 2017 18:13:48 +0100", "Message-Id": "<20170922171348.17630-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH][V3] e1000: avoid null pointer dereference\n\ton invalid stat type", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nCurrently if the stat type is invalid then data[i] is being set\neither by dereferencing a null pointer p, or it is reading from\nan incorrect previous location if we had a valid stat type\npreviously. Fix this by skipping over the read of p on an invalid\nstat type.\n\nDetected by CoverityScan, CID#113385 (\"Explicit null dereferenced\")\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\nindex ec8aa4562cc9..3b3983a1ffbb 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n@@ -1824,11 +1824,12 @@ static void e1000_get_ethtool_stats(struct net_device *netdev,\n {\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n \tint i;\n-\tchar *p = NULL;\n \tconst struct e1000_stats *stat = e1000_gstrings_stats;\n \n \te1000_update_stats(adapter);\n-\tfor (i = 0; i < E1000_GLOBAL_STATS_LEN; i++) {\n+\tfor (i = 0; i < E1000_GLOBAL_STATS_LEN; i++, stat++) {\n+\t\tchar *p;\n+\n \t\tswitch (stat->type) {\n \t\tcase NETDEV_STATS:\n \t\t\tp = (char *)netdev + stat->stat_offset;\n@@ -1839,15 +1840,13 @@ static void e1000_get_ethtool_stats(struct net_device *netdev,\n \t\tdefault:\n \t\t\tWARN_ONCE(1, \"Invalid E1000 stat type: %u index %d\\n\",\n \t\t\t\t stat->type, i);\n-\t\t\tbreak;\n+\t\t\tcontinue;\n \t\t}\n \n \t\tif (stat->sizeof_stat == sizeof(u64))\n \t\t\tdata[i] = *(u64 *)p;\n \t\telse\n \t\t\tdata[i] = *(u32 *)p;\n-\n-\t\tstat++;\n \t}\n /* BUG_ON(i != E1000_STATS_LEN); */\n }\n", "prefixes": [ "V3" ] }