Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817624/?format=api
{ "id": 817624, "url": "http://patchwork.ozlabs.org/api/patches/817624/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170922160111.31885-2-f4bug@amsat.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170922160111.31885-2-f4bug@amsat.org>", "list_archive_url": null, "date": "2017-09-22T16:01:01", "name": "[24/34] hw/timer/mc146818: rename rtc_init() -> mc146818_init()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8a40907f8b3f3774fe3a6ff255244da108dfae65", "submitter": { "id": 70924, "url": "http://patchwork.ozlabs.org/api/people/70924/?format=api", "name": "Philippe Mathieu-Daudé", "email": "f4bug@amsat.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170922160111.31885-2-f4bug@amsat.org/mbox/", "series": [ { "id": 4657, "url": "http://patchwork.ozlabs.org/api/series/4657/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4657", "date": "2017-09-22T15:39:40", "name": "remove i386/pc dependency from non-PC world (part 1)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4657/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817624/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817624/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"a9vW8jCv\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzJX86mMXz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 02:16:56 +1000 (AEST)", "from localhost ([::1]:59916 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dvQdK-0002al-VQ\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 12:16:55 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51564)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dvQOh-00067t-H7\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:01:48 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dvQOc-0008NZ-Lg\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 12:01:47 -0400", "from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:36448)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dvQOc-0008NN-Gm; Fri, 22 Sep 2017 12:01:42 -0400", "by mail-qt0-x244.google.com with SMTP id t46so920607qtj.3;\n\tFri, 22 Sep 2017 09:01:42 -0700 (PDT)", "from yoga.lan ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id\n\ty31sm108325qta.83.2017.09.22.09.01.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 09:01:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=CG3JkLfzmFq08KAOWuKpGIc67luu5oY1muwbG4sTQWc=;\n\tb=a9vW8jCvgraH47F8/AwMjTnjQOPJAXKfXD8PeDIQkonpVSUaje1BI6DewhDpji8CRE\n\tqTeJaH95jsj8tOBhZ6U4fkU62++A90ssVa7ZiozSSx9Xo24v9g223MnJmUn6nFPpRNRV\n\tZBv+36ivLr4xBgOWfJRnPACjUnVn8hUu1ujI7o1dJdXbzDRwtrscGxfZlXYbrE4gCOJ/\n\t1h5zuXVB5A4v02QI/3VFnxxO3KJ41DvGBlNExDd8BNOWOkAo4l+DnGX3lSKcp8W+geX5\n\t43+S0kbTFP5j06aDHG0rcGir+P28z2eDyvmxRayeM65M0hofxFPN5Hc6hVpvTkfqmtcs\n\tYmIA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=CG3JkLfzmFq08KAOWuKpGIc67luu5oY1muwbG4sTQWc=;\n\tb=obLHB1VQzkK0TpEuEtvSvrctg9TTpL1i52z/v3NcPzsaurpQjVWLxVqmQs9QpjZs77\n\tKUd16q6o2gPqvy3NJ5OBJy7PxddwhcCbJVHN+h6e13/601u5ZaZ1VN47BtivPMmoW04S\n\tPF/eDvqH+lJ08jetSrhaX8/jC0/1hHVZtTZDkPOysl19su/TU6mbH49JizwpOG7/353f\n\tIr3SgbEm7Laz0xZlfSSnuZaOkwvnLDOS8hVnMRmEZc36ITqXtJLIGHp90c+9ASWsms2Y\n\t4lT/QlMlSAyGSCQSuLuxwK/YnbLDRVddf7dBVNgtmMjMJk4xWBvqPGtXtOqAOlbablVl\n\tHUOw==", "X-Gm-Message-State": "AHPjjUj4J2XNbkwa89fsq3oFikG6ZlLqGIUk0EwaR2gOnUrdVI2xk1wB\n\tzawHsU5Ppq76c14Ak9ZRItc=", "X-Google-Smtp-Source": "AOwi7QCjSxahy20AAwTOjX3v3RRrnugFbz8cj/rNylcc6gx3i2PsT4CPu3ehwqhdbcR38RmD/FfVQw==", "X-Received": "by 10.237.37.14 with SMTP id v14mr8492205qtc.116.1506096101689; \n\tFri, 22 Sep 2017 09:01:41 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>", "To": "Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tPaolo Bonzini <pbonzini@redhat.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>, Aurelien Jarno\n\t<aurelien@aurel32.net>, Yongbok Kim <yongbok.kim@imgtec.com>,\n\tRichard Henderson <rth@twiddle.net>, =?utf-8?q?Herv=C3=A9_Poussineau?=\n\t<hpoussin@reactos.org>, David Gibson <david@gibson.dropbear.id.au>,\n\tAlexander Graf <agraf@suse.de>", "Date": "Fri, 22 Sep 2017 13:01:01 -0300", "Message-Id": "<20170922160111.31885-2-f4bug@amsat.org>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170922154014.29350-1-f4bug@amsat.org>", "References": "<20170922154014.29350-1-f4bug@amsat.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400d:c0d::244", "Subject": "[Qemu-devel] [PATCH 24/34] hw/timer/mc146818: rename rtc_init() ->\n\tmc146818_init()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathi?=\n\t=?utf-8?b?ZXUtRGF1ZMOp?= <f4bug@amsat.org>, \tqemu-devel@nongnu.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "and remove the old i386/pc dependency\n\nSigned-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\n include/hw/timer/mc146818rtc.h | 3 ++-\n hw/alpha/dp264.c | 2 +-\n hw/i386/pc.c | 2 +-\n hw/isa/i82378.c | 3 ++-\n hw/mips/mips_fulong2e.c | 2 +-\n hw/mips/mips_jazz.c | 2 +-\n hw/mips/mips_malta.c | 2 +-\n hw/mips/mips_r4k.c | 2 +-\n hw/ppc/pnv.c | 2 +-\n hw/timer/mc146818rtc.c | 2 +-\n 10 files changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/hw/timer/mc146818rtc.h b/include/hw/timer/mc146818rtc.h\nindex 7c8e64b203..fe6ed63f71 100644\n--- a/include/hw/timer/mc146818rtc.h\n+++ b/include/hw/timer/mc146818rtc.h\n@@ -6,7 +6,8 @@\n \n #define TYPE_MC146818_RTC \"mc146818rtc\"\n \n-ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq);\n+ISADevice *mc146818_rtc_init(ISABus *bus, int base_year,\n+ qemu_irq intercept_irq);\n void rtc_set_memory(ISADevice *dev, int addr, int val);\n int rtc_get_memory(ISADevice *dev, int addr);\n \ndiff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c\nindex 2253990654..df6dadf13f 100644\n--- a/hw/alpha/dp264.c\n+++ b/hw/alpha/dp264.c\n@@ -80,7 +80,7 @@ static void clipper_init(MachineState *machine)\n clipper_pci_map_irq);\n \n /* Since we have an SRM-compatible PALcode, use the SRM epoch. */\n- rtc_init(isa_bus, 1900, rtc_irq);\n+ mc146818_rtc_init(isa_bus, 1900, rtc_irq);\n \n i8254_pit_init(isa_bus, 0x40, 0, NULL);\n isa_create_simple(isa_bus, TYPE_I8042);\ndiff --git a/hw/i386/pc.c b/hw/i386/pc.c\nindex 76d4be5991..788844e0de 100644\n--- a/hw/i386/pc.c\n+++ b/hw/i386/pc.c\n@@ -1545,7 +1545,7 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,\n rtc_irq = qdev_get_gpio_in(hpet, HPET_LEGACY_RTC_INT);\n }\n }\n- *rtc_state = rtc_init(isa_bus, 2000, rtc_irq);\n+ *rtc_state = mc146818_rtc_init(isa_bus, 2000, rtc_irq);\n \n qemu_register_boot_set(pc_boot_set, *rtc_state);\n \ndiff --git a/hw/isa/i82378.c b/hw/isa/i82378.c\nindex 7a8baef23c..14b006cadc 100644\n--- a/hw/isa/i82378.c\n+++ b/hw/isa/i82378.c\n@@ -21,6 +21,7 @@\n #include \"hw/pci/pci.h\"\n #include \"hw/i386/pc.h\"\n #include \"hw/timer/i8254.h\"\n+#include \"hw/timer/mc146818rtc.h\"\n #include \"hw/audio/pcspk.h\"\n \n #define TYPE_I82378 \"i82378\"\n@@ -106,7 +107,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp)\n isa = isa_create_simple(isabus, \"i82374\");\n \n /* timer */\n- isa_create_simple(isabus, \"mc146818rtc\");\n+ isa_create_simple(isabus, TYPE_MC146818_RTC);\n }\n \n static void i82378_init(Object *obj)\ndiff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c\nindex 6dc6a0ac18..7ebbffa8f2 100644\n--- a/hw/mips/mips_fulong2e.c\n+++ b/hw/mips/mips_fulong2e.c\n@@ -371,7 +371,7 @@ static void mips_fulong2e_init(MachineState *machine)\n /* Super I/O */\n isa_create_simple(isa_bus, TYPE_I8042);\n \n- rtc_init(isa_bus, 2000, NULL);\n+ mc146818_rtc_init(isa_bus, 2000, NULL);\n \n serial_hds_isa_init(isa_bus, 0, MAX_SERIAL_PORTS);\n parallel_hds_isa_init(isa_bus, 1);\ndiff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c\nindex 1b54602c1d..439bbd71fe 100644\n--- a/hw/mips/mips_jazz.c\n+++ b/hw/mips/mips_jazz.c\n@@ -295,7 +295,7 @@ static void mips_jazz_init(MachineState *machine,\n fdctrl_init_sysbus(qdev_get_gpio_in(rc4030, 1), -1, 0x80003000, fds);\n \n /* Real time clock */\n- rtc_init(isa_bus, 1980, NULL);\n+ mc146818_rtc_init(isa_bus, 1980, NULL);\n memory_region_init_io(rtc, NULL, &rtc_ops, NULL, \"rtc\", 0x1000);\n memory_region_add_subregion(address_space, 0x80004000, rtc);\n \ndiff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c\nindex 050da36f1d..6945fa47c3 100644\n--- a/hw/mips/mips_malta.c\n+++ b/hw/mips/mips_malta.c\n@@ -1225,7 +1225,7 @@ void mips_malta_init(MachineState *machine)\n /* Super I/O */\n isa_create_simple(isa_bus, TYPE_I8042);\n \n- rtc_init(isa_bus, 2000, NULL);\n+ mc146818_rtc_init(isa_bus, 2000, NULL);\n serial_hds_isa_init(isa_bus, 0, 2);\n parallel_hds_isa_init(isa_bus, 1);\n \ndiff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c\nindex 946097a31f..349da59912 100644\n--- a/hw/mips/mips_r4k.c\n+++ b/hw/mips/mips_r4k.c\n@@ -279,7 +279,7 @@ void mips_r4k_init(MachineState *machine)\n i8259 = i8259_init(isa_bus, env->irq[2]);\n isa_bus_irqs(isa_bus, i8259);\n \n- rtc_init(isa_bus, 2000, NULL);\n+ mc146818_rtc_init(isa_bus, 2000, NULL);\n \n pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);\n \ndiff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c\nindex 47221158d4..d188b899c5 100644\n--- a/hw/ppc/pnv.c\n+++ b/hw/ppc/pnv.c\n@@ -647,7 +647,7 @@ static void ppc_powernv_init(MachineState *machine)\n serial_hds_isa_init(pnv->isa_bus, 0, MAX_SERIAL_PORTS);\n \n /* Create an RTC ISA device too */\n- rtc_init(pnv->isa_bus, 2000, NULL);\n+ mc146818_rtc_init(pnv->isa_bus, 2000, NULL);\n \n /* OpenPOWER systems use a IPMI SEL Event message to notify the\n * host to powerdown */\ndiff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c\nindex 82843ed03f..f7d8c4bae4 100644\n--- a/hw/timer/mc146818rtc.c\n+++ b/hw/timer/mc146818rtc.c\n@@ -997,7 +997,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)\n qdev_init_gpio_out(dev, &s->irq, 1);\n }\n \n-ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)\n+ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)\n {\n DeviceState *dev;\n ISADevice *isadev;\n", "prefixes": [ "24/34" ] }