Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817539/?format=api
{ "id": 817539, "url": "http://patchwork.ozlabs.org/api/patches/817539/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170922141138.13038-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170922141138.13038-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-09-22T14:11:38", "name": "i40e: make const array patterns static, reduces object code size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7a662688a77096d0a6d47cdae4d729da7f436230", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170922141138.13038-1-colin.king@canonical.com/mbox/", "series": [ { "id": 4640, "url": "http://patchwork.ozlabs.org/api/series/4640/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=4640", "date": "2017-09-22T14:11:38", "name": "i40e: make const array patterns static, reduces object code size", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4640/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817539/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817539/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzFlm0J4Nz9t3h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 00:11:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0C92F89BF9;\n\tFri, 22 Sep 2017 14:11:46 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0wLpDPvyh8iq; Fri, 22 Sep 2017 14:11:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6566989BDA;\n\tFri, 22 Sep 2017 14:11:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id F39381C3EBC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 14:11:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ECE248A177\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 14:11:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6eUYju90UVDL for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 14:11:43 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 43BF38A176\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 22 Sep 2017 14:11:43 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1dvOg8-00087f-I2; Fri, 22 Sep 2017 14:11:40 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Fri, 22 Sep 2017 15:11:38 +0100", "Message-Id": "<20170922141138.13038-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40e: make const array patterns static,\n\treduces object code size", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nDon't populate const array patterns on the stack, instead make it\nstatic. Makes the object code smaller by over 60 bytes:\n\nBefore:\n text\t data\t bss\t dec\t hex\tfilename\n 1953\t 496\t 0\t 2449\t 991\ti40e_diag.o\n\nAfter:\n text\t data\t bss\t dec\t hex\tfilename\n 1798\t 584\t 0\t 2382\t 94e\ti40e_diag.o\n\n(gcc 6.3.0, x86-64)\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_diag.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_diag.c b/drivers/net/ethernet/intel/i40e/i40e_diag.c\nindex f141e78d409e..76ed56641864 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_diag.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_diag.c\n@@ -36,7 +36,9 @@\n static i40e_status i40e_diag_reg_pattern_test(struct i40e_hw *hw,\n \t\t\t\t\t\t\tu32 reg, u32 mask)\n {\n-\tconst u32 patterns[] = {0x5A5A5A5A, 0xA5A5A5A5, 0x00000000, 0xFFFFFFFF};\n+\tstatic const u32 patterns[] = {\n+\t\t0x5A5A5A5A, 0xA5A5A5A5, 0x00000000, 0xFFFFFFFF\n+\t};\n \tu32 pat, val, orig_val;\n \tint i;\n \n", "prefixes": [] }