Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817484/?format=api
{ "id": 817484, "url": "http://patchwork.ozlabs.org/api/patches/817484/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1506083624-20621-2-git-send-email-amarnath.valluri@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1506083624-20621-2-git-send-email-amarnath.valluri@intel.com>", "list_archive_url": null, "date": "2017-09-22T12:33:37", "name": "[v7,1/8] tpm-backend: Remove unneeded member variable from backend class", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4c63169a562eae88075a3fb7027ff1d2aa5d51dd", "submitter": { "id": 71320, "url": "http://patchwork.ozlabs.org/api/people/71320/?format=api", "name": "Valluri, Amarnath", "email": "amarnath.valluri@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1506083624-20621-2-git-send-email-amarnath.valluri@intel.com/mbox/", "series": [ { "id": 4614, "url": "http://patchwork.ozlabs.org/api/series/4614/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4614", "date": "2017-09-22T12:33:37", "name": "Provide support for the software TPM emulator", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/4614/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817484/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817484/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzChL3lN8z9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 22:38:42 +1000 (AEST)", "from localhost ([::1]:58652 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dvNE8-000501-IF\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 08:38:40 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:56392)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <amarnath.valluri@intel.com>) id 1dvN8X-0000bS-Q6\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:32:57 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <amarnath.valluri@intel.com>) id 1dvN8U-0005q4-JA\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:32:53 -0400", "from mga07.intel.com ([134.134.136.100]:27337)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <amarnath.valluri@intel.com>)\n\tid 1dvN8U-0005pe-9u\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:32:50 -0400", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga105.jf.intel.com with ESMTP; 22 Sep 2017 05:32:48 -0700", "from avallurigigabyte.fi.intel.com ([10.237.68.147])\n\tby FMSMGA003.fm.intel.com with ESMTP; 22 Sep 2017 05:32:47 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,427,1500966000\"; d=\"scan'208\";a=\"902897827\"", "From": "Amarnath Valluri <amarnath.valluri@intel.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 22 Sep 2017 15:33:37 +0300", "Message-Id": "<1506083624-20621-2-git-send-email-amarnath.valluri@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1506083624-20621-1-git-send-email-amarnath.valluri@intel.com>", "References": "<1506083624-20621-1-git-send-email-amarnath.valluri@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "134.134.136.100", "Subject": "[Qemu-devel] [PATCH v7 1/8] tpm-backend: Remove unneeded member\n\tvariable from backend class", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Amarnath Valluri <amarnath.valluri@intel.com>, =?utf-8?q?Marc-Andr?=\n\t=?utf-8?b?w6kgTHVyZWF1?= <marcandre.lureau@gmail.com>,\n\tStefan Berger <stefanb@linux.vnet.ibm.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class\nmember. The only possible reason for keeping in TPMBackend was, to get the\nbackend type in tpm.c where dedicated backend api, tpm_backend_get_type() is\npresent.\n\nSigned-off-by: Amarnath Valluri <amarnath.valluri@intel.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>\n---\n hw/tpm/tpm_passthrough.c | 4 ----\n include/sysemu/tpm_backend.h | 1 -\n tpm.c | 2 +-\n 3 files changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c\nindex 9234eb3..a0baf5f 100644\n--- a/hw/tpm/tpm_passthrough.c\n+++ b/hw/tpm/tpm_passthrough.c\n@@ -46,8 +46,6 @@\n #define TPM_PASSTHROUGH(obj) \\\n OBJECT_CHECK(TPMPassthruState, (obj), TYPE_TPM_PASSTHROUGH)\n \n-static const TPMDriverOps tpm_passthrough_driver;\n-\n /* data structures */\n typedef struct TPMPassthruThreadParams {\n TPMState *tpm_state;\n@@ -462,8 +460,6 @@ static TPMBackend *tpm_passthrough_create(QemuOpts *opts, const char *id)\n /* let frontend set the fe_model to proper value */\n tb->fe_model = -1;\n \n- tb->ops = &tpm_passthrough_driver;\n-\n if (tpm_passthrough_handle_device_opts(opts, tb)) {\n goto err_exit;\n }\ndiff --git a/include/sysemu/tpm_backend.h b/include/sysemu/tpm_backend.h\nindex b0a9731..3708413 100644\n--- a/include/sysemu/tpm_backend.h\n+++ b/include/sysemu/tpm_backend.h\n@@ -50,7 +50,6 @@ struct TPMBackend {\n enum TpmModel fe_model;\n char *path;\n char *cancel_path;\n- const TPMDriverOps *ops;\n \n QLIST_ENTRY(TPMBackend) list;\n };\ndiff --git a/tpm.c b/tpm.c\nindex 2d830d0..abedf3f 100644\n--- a/tpm.c\n+++ b/tpm.c\n@@ -211,7 +211,7 @@ static TPMInfo *qmp_query_tpm_inst(TPMBackend *drv)\n res->model = drv->fe_model;\n res->options = g_new0(TpmTypeOptions, 1);\n \n- switch (drv->ops->type) {\n+ switch (tpm_backend_get_type(drv)) {\n case TPM_TYPE_PASSTHROUGH:\n res->options->type = TPM_TYPE_OPTIONS_KIND_PASSTHROUGH;\n tpo = g_new0(TPMPassthroughOptions, 1);\n", "prefixes": [ "v7", "1/8" ] }