Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 817434,
    "url": "http://patchwork.ozlabs.org/api/patches/817434/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1506077902-1796-6-git-send-email-allen.lkml@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1506077902-1796-6-git-send-email-allen.lkml@gmail.com>",
    "list_archive_url": null,
    "date": "2017-09-22T10:58:22",
    "name": "[5/5] net: nfc: llcp_core: use setup_timer() helper.",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "3ab461b83b0c8dde93866315fee79398b32376a5",
    "submitter": {
        "id": 72354,
        "url": "http://patchwork.ozlabs.org/api/people/72354/?format=api",
        "name": "Allen Pais",
        "email": "allen.lkml@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1506077902-1796-6-git-send-email-allen.lkml@gmail.com/mbox/",
    "series": [
        {
            "id": 4595,
            "url": "http://patchwork.ozlabs.org/api/series/4595/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4595",
            "date": "2017-09-22T10:58:17",
            "name": "use setup_timer() helper function.",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/4595/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/817434/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/817434/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"pdrMPfu4\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz9T42jZJz9sP1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 20:58:48 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752097AbdIVK6r (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 06:58:47 -0400",
            "from mail-pg0-f65.google.com ([74.125.83.65]:33724 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752072AbdIVK6o (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 06:58:44 -0400",
            "by mail-pg0-f65.google.com with SMTP id i130so447865pgc.0\n\tfor <netdev@vger.kernel.org>; Fri, 22 Sep 2017 03:58:44 -0700 (PDT)",
            "from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\ts17sm6283035pgq.25.2017.09.22.03.58.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 22 Sep 2017 03:58:43 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wPPFXFdth4AKZF0OkIbp9LPOTMR4IhxIp+LNKzOK3Nw=;\n\tb=pdrMPfu4GJmFIzLHi5MTQY4FCyIdEyY9p0Hu+Nuuxzka08EUCMb2pjbqae/PYMnmWB\n\tI0eiXehGQHwJY9zVmXJ7qWyxCVBEneoLiznRM51CNpHE4bJrSKTXRKczJ98dDR62JWtR\n\tAwoKKPf/vvZTtbxmzAMY9IWwqJPOKtWNso+a9ikMb9jreAvreWlyA+JObR7pyLHopt4c\n\t7Acd/ah2ONBTvt5WPhHhgeqzgmneTFDpN18p4GS/u1oBIH2xgrTvGhL163pTO/DSYLj8\n\tGv8TFC8NQJ7Jyo326XIa5u8tj4waGhp0LO672WK5Vu9pMFDLQfh9aSYn4Mfc+carcREi\n\tsfoA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wPPFXFdth4AKZF0OkIbp9LPOTMR4IhxIp+LNKzOK3Nw=;\n\tb=H5SqgE+3U0GKzPFeYbV6Y9MUH5DVm/EXq2/b6yQ/C8VunH16ILsjhd9nMoHE5bm+FD\n\tjIFwizQCtMI5ECdihJTpGz1o+5Akr2/IOEvNjIjGwiE6jy/c2FXC0s/uLCMp0BUBVcw+\n\tIGRQUzJVwhe79A8qoUpYLeuzZm8g/NtmLSXvZgdizhOEZRASzqpiIa6jRyLFECEHRAZZ\n\tKDQf6OeVNDw2PCflMTI78JyWasw+Sr/fM3LScEbBLKCM4wbPOXGd9x8iQNyK6KiXN3/G\n\tCHD8Mzldai2cgZH+OsamWd9pJNckzHb9QK5K62LEJYuO+VDcvkZNh2zEm7FcoaYqjJJK\n\ty1EQ==",
        "X-Gm-Message-State": "AHPjjUi8z006vLvXgAKlCUXZ5WyNQ4iOHHAgpCO+kEXg+IQkB0Cfhm3E\n\tmhFnV5fKYSb0yFCOacG2SLXB90KO",
        "X-Google-Smtp-Source": "AOwi7QD4GCR6j4cR+pERy4MyGtC5+ztsa1jqlNYGC9M/ZKWJsFuT+lBqJt047iWydsOesj+rKje/+w==",
        "X-Received": "by 10.98.20.19 with SMTP id 19mr8753264pfu.167.1506077924098;\n\tFri, 22 Sep 2017 03:58:44 -0700 (PDT)",
        "From": "Allen Pais <allen.lkml@gmail.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "davem@davemloft.net, sameo@linux.intel.com,\n\tAllen Pais <allen.lkml@gmail.com>",
        "Subject": "[PATCH 5/5] net: nfc: llcp_core: use setup_timer() helper.",
        "Date": "Fri, 22 Sep 2017 16:28:22 +0530",
        "Message-Id": "<1506077902-1796-6-git-send-email-allen.lkml@gmail.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1506077902-1796-1-git-send-email-allen.lkml@gmail.com>",
        "References": "<1506077902-1796-1-git-send-email-allen.lkml@gmail.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Use setup_timer function instead of initializing timer with the\n   function and data fields.\n\nSigned-off-by: Allen Pais <allen.lkml@gmail.com>\n---\n net/nfc/llcp_core.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c\nindex 02eef5c..7988185 100644\n--- a/net/nfc/llcp_core.c\n+++ b/net/nfc/llcp_core.c\n@@ -1573,9 +1573,8 @@ int nfc_llcp_register_device(struct nfc_dev *ndev)\n \tINIT_LIST_HEAD(&local->list);\n \tkref_init(&local->ref);\n \tmutex_init(&local->sdp_lock);\n-\tinit_timer(&local->link_timer);\n-\tlocal->link_timer.data = (unsigned long) local;\n-\tlocal->link_timer.function = nfc_llcp_symm_timer;\n+\tsetup_timer(&local->link_timer, nfc_llcp_symm_timer,\n+\t\t    (unsigned long)local);\n \n \tskb_queue_head_init(&local->tx_queue);\n \tINIT_WORK(&local->tx_work, nfc_llcp_tx_work);\n@@ -1601,9 +1600,8 @@ int nfc_llcp_register_device(struct nfc_dev *ndev)\n \n \tmutex_init(&local->sdreq_lock);\n \tINIT_HLIST_HEAD(&local->pending_sdreqs);\n-\tinit_timer(&local->sdreq_timer);\n-\tlocal->sdreq_timer.data = (unsigned long) local;\n-\tlocal->sdreq_timer.function = nfc_llcp_sdreq_timer;\n+\tsetup_timer(&local->sdreq_timer, nfc_llcp_sdreq_timer,\n+\t\t    (unsigned long)local);\n \tINIT_WORK(&local->sdreq_timeout_work, nfc_llcp_sdreq_timeout_work);\n \n \tlist_add(&local->list, &llcp_devices);\n",
    "prefixes": [
        "5/5"
    ]
}