Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 817432,
    "url": "http://patchwork.ozlabs.org/api/patches/817432/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1506077902-1796-3-git-send-email-allen.lkml@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1506077902-1796-3-git-send-email-allen.lkml@gmail.com>",
    "list_archive_url": null,
    "date": "2017-09-22T10:58:19",
    "name": "[2/5] net: nfc: hci: llc_shdlc: use setup_timer() helper.",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "3c22bf6b5de6d74f50aa7b85d0af210b9eb021c2",
    "submitter": {
        "id": 72354,
        "url": "http://patchwork.ozlabs.org/api/people/72354/?format=api",
        "name": "Allen Pais",
        "email": "allen.lkml@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1506077902-1796-3-git-send-email-allen.lkml@gmail.com/mbox/",
    "series": [
        {
            "id": 4595,
            "url": "http://patchwork.ozlabs.org/api/series/4595/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4595",
            "date": "2017-09-22T10:58:17",
            "name": "use setup_timer() helper function.",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/4595/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/817432/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/817432/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sWpZZmuE\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz9Sz4ht3z9ryk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 20:58:43 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752069AbdIVK6m (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 06:58:42 -0400",
            "from mail-pf0-f193.google.com ([209.85.192.193]:35883 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751992AbdIVK6g (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 06:58:36 -0400",
            "by mail-pf0-f193.google.com with SMTP id f84so320690pfj.3\n\tfor <netdev@vger.kernel.org>; Fri, 22 Sep 2017 03:58:36 -0700 (PDT)",
            "from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\ts17sm6283035pgq.25.2017.09.22.03.58.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 22 Sep 2017 03:58:34 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=5mMy4BCGfWjKJkTgV4LCny9g1+91+pdguFdMr7GUKVI=;\n\tb=sWpZZmuEvgub21RgXVpvrvKuTYseQCUbeDynTUscwkD26pLZpleOJfIUxTqXNHAB4r\n\tNKi8R2hdJXVk7Irihy4w6L5KtXa0Eny3BrZFS1GoxV4lUhAd/kN17s6XXBk+FdkqB48N\n\tf1hLIbHmy5Z0UyiG6pewaczKGGjj3RQ+h3cAwv677Q7YNFaxU+9lGlWDY1wuYVLWowy2\n\toC058rMBpWdXgKFPg+JEgmHeGvUN19XBolqoIL9hKiUzekzKrO/3hFusrIv9mWxiUnzo\n\tNf3tJaTnMizm40Kki5TUV33lre55gMswF2SKM/mLDt/UphKAQiKTwvpM5mnHJSSSyPcl\n\t15Uw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=5mMy4BCGfWjKJkTgV4LCny9g1+91+pdguFdMr7GUKVI=;\n\tb=YNVRTlzUOVHGOFPkJE2JcJlCoGfZuc7B8ZShd+w/jBEdiLSntkX63TFQR2K/ovxz4k\n\tPZ2QCrPHOyT30XReceXyStMfSSzOZ3wuFGw80dDU8fbURytoKP0gSW0lg6BPsq564gIo\n\tEpHIm6OpADfWwY3mtMmpqu2DjxfvKdnhYk82JsELX/kavJDI+8q/dpGQhKfSRFQrzpD/\n\tgQkKGb9YZr77duoEvbz8Wmtr7u8Xw7pY9pq3YyEVhEbAfiKGxOTeiQWUMWE1TS4PqCI+\n\tCZQMhHx+tSbiJ1cPPJrfBOtFl/TEzASXZ6NTVNlqKpLKEK18ozzuX3fnUqoEInv1GnFP\n\tj8bA==",
        "X-Gm-Message-State": "AHPjjUgVhI0c5NcseOXaywuHRNSSraC10dWLmkvrSAb25kEzvs/S9VNZ\n\tPB3MVYNgSwFbZ1/fLtlizysOhGky",
        "X-Google-Smtp-Source": "AOwi7QC1SRIkicnOu12JvxXfat1hWLOd5Gdj7C+nTalrKT2KNcX8AxfbMbZ8HL39u1UpJvCND+6MdA==",
        "X-Received": "by 10.98.36.132 with SMTP id k4mr9034311pfk.148.1506077915297;\n\tFri, 22 Sep 2017 03:58:35 -0700 (PDT)",
        "From": "Allen Pais <allen.lkml@gmail.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "davem@davemloft.net, sameo@linux.intel.com,\n\tAllen Pais <allen.lkml@gmail.com>",
        "Subject": "[PATCH 2/5] net: nfc: hci: llc_shdlc: use setup_timer() helper.",
        "Date": "Fri, 22 Sep 2017 16:28:19 +0530",
        "Message-Id": "<1506077902-1796-3-git-send-email-allen.lkml@gmail.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1506077902-1796-1-git-send-email-allen.lkml@gmail.com>",
        "References": "<1506077902-1796-1-git-send-email-allen.lkml@gmail.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Use setup_timer function instead of initializing timer with the\n   function and data fields.\n\nSigned-off-by: Allen Pais <allen.lkml@gmail.com>\n---\n net/nfc/hci/llc_shdlc.c | 15 ++++++---------\n 1 file changed, 6 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c\nindex 17e59a0..58df37e 100644\n--- a/net/nfc/hci/llc_shdlc.c\n+++ b/net/nfc/hci/llc_shdlc.c\n@@ -763,17 +763,14 @@ static void *llc_shdlc_init(struct nfc_hci_dev *hdev, xmit_to_drv_t xmit_to_drv,\n \tmutex_init(&shdlc->state_mutex);\n \tshdlc->state = SHDLC_DISCONNECTED;\n \n-\tinit_timer(&shdlc->connect_timer);\n-\tshdlc->connect_timer.data = (unsigned long)shdlc;\n-\tshdlc->connect_timer.function = llc_shdlc_connect_timeout;\n+\tsetup_timer(&shdlc->connect_timer, llc_shdlc_connect_timeout,\n+\t\t    (unsigned long)shdlc);\n \n-\tinit_timer(&shdlc->t1_timer);\n-\tshdlc->t1_timer.data = (unsigned long)shdlc;\n-\tshdlc->t1_timer.function = llc_shdlc_t1_timeout;\n+\tsetup_timer(&shdlc->t1_timer, llc_shdlc_t1_timeout,\n+\t\t    (unsigned long)shdlc);\n \n-\tinit_timer(&shdlc->t2_timer);\n-\tshdlc->t2_timer.data = (unsigned long)shdlc;\n-\tshdlc->t2_timer.function = llc_shdlc_t2_timeout;\n+\tsetup_timer(&shdlc->t2_timer, llc_shdlc_t2_timeout,\n+\t\t    (unsigned long)shdlc);\n \n \tshdlc->w = SHDLC_MAX_WINDOW;\n \tshdlc->srej_support = SHDLC_SREJ_SUPPORT;\n",
    "prefixes": [
        "2/5"
    ]
}