Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817318/?format=api
{ "id": 817318, "url": "http://patchwork.ozlabs.org/api/patches/817318/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1506052009-8285-2-git-send-email-yamada.masahiro@socionext.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1506052009-8285-2-git-send-email-yamada.masahiro@socionext.com>", "list_archive_url": null, "date": "2017-09-22T03:46:38", "name": "[v2,01/12] mtd: nand: denali: squash setup_ecc_for_xfer() helper into caller", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f7070ea2156d0ecb40f8e27a03b02f327b52e31c", "submitter": { "id": 65882, "url": "http://patchwork.ozlabs.org/api/people/65882/?format=api", "name": "Masahiro Yamada", "email": "yamada.masahiro@socionext.com" }, "delegate": { "id": 58324, "url": "http://patchwork.ozlabs.org/api/users/58324/?format=api", "username": "bbrezillon", "first_name": "Boris", "last_name": "Brezillon", "email": "boris.brezillon@free-electrons.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1506052009-8285-2-git-send-email-yamada.masahiro@socionext.com/mbox/", "series": [ { "id": 4537, "url": "http://patchwork.ozlabs.org/api/series/4537/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4537", "date": "2017-09-22T03:46:37", "name": "mtd: nand: denali: more clean-ups", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/4537/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817318/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"AYnDE5tG\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"mHNUJFbL\"; dkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz0545vnnz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 13:55:52 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvF48-0002f5-4n; Fri, 22 Sep 2017 03:55:48 +0000", "from conuserg-09.nifty.com ([210.131.2.76])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvEwN-0004Fl-KZ\n\tfor linux-mtd@lists.infradead.org; Fri, 22 Sep 2017 03:47:57 +0000", "from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp\n\t[153.142.97.92]) (authenticated)\n\tby conuserg-09.nifty.com with ESMTP id v8M3kwAK029389;\n\tFri, 22 Sep 2017 12:47:00 +0900" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=Jc4VR/5Ilo8AlFvsEaVKJFjv0/UdtyxgLBCC6ZKK7j0=;\n\tb=AYnDE5tGjNlzmmzSAV4CrT/tM4\n\tFmthdG3iWOlz+aLqMqIqVoBPGSk9cs6OA3Cye7TXoJwcBEhMrmXtXejX3FHfq6zBkJsIa0b4tFrku\n\t3PbHwmY+JXp9RSYatU2eujTYzvlUl902C4tUGDciVIxmwU0PHNp4XiQIkYNG6U9Fi0FOraTSSPa0w\n\t5IXaUtdrnUNMmq64m15/YYnwvnEErx5ClHEd2Wn3COeh6Pb0sV5GRF3GAWwTRML7E+l3mV7x4K2av\n\tanz4DIJ7Nv/lkar1LVxbpR+/5/twmk2Yn1d2hQX1OKI80mfhUbh/WpCtwJVwxDb5Ee3DXZmIXLV3R\n\tSHPjIJdg==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1506052020;\n\tbh=59fdI7+UE95X4PNnOZNZNKCOmyNFFdGozGYIY/JOjgk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mHNUJFbLTCeNJmhfWV+NIhXLq0bLHEQLrfbnz1Vq9HIBy39LVZ4qciab+O216YcN3\n\tua99UCqzcZdFRV0xFDqH1B4/xoVQb+seWyiQV+aYBMX0PtzQVBi0HXhAEL+Tc7IMSZ\n\t8wpqmXNTiT2/8ngbRKjAJp5wKvVAfoQ21JqGZ6MFB0NqH2nEOhGu2k/45HT8xqoGWe\n\t7aUBk5wpTjUeANhyuAUegML1G4dZUq/lH7DKAYYPC8LUfzj64QNuR+Km3P/IYgWNDr\n\tph1umNSdRTux7m1IsaZWd5ncL4mHJGRBW3aWCeMIyZS1jm2IzXXxjw/5P+m5ejYPOu\n\tpovlGe4du4s9g==" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 conuserg-09.nifty.com v8M3kwAK029389", "X-Nifty-SrcIP": "[153.142.97.92]", "From": "Masahiro Yamada <yamada.masahiro@socionext.com>", "To": "linux-mtd@lists.infradead.org", "Subject": "[PATCH v2 01/12] mtd: nand: denali: squash setup_ecc_for_xfer()\n\thelper into caller", "Date": "Fri, 22 Sep 2017 12:46:38 +0900", "Message-Id": "<1506052009-8285-2-git-send-email-yamada.masahiro@socionext.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1506052009-8285-1-git-send-email-yamada.masahiro@socionext.com>", "References": "<1506052009-8285-1-git-send-email-yamada.masahiro@socionext.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170921_204748_304860_D80BABF8 ", "X-CRM114-Status": "GOOD ( 11.18 )", "X-Spam-Score": "-1.2 (-)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "Boris Brezillon <boris.brezillon@free-electrons.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tRichard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org,\n\tMasahiro Yamada <yamada.masahiro@socionext.com>, \n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "The setup_ecc_for_xfer() is only called from denali_data_xfer().\nThis helper is small enough, so squash it into the caller.\nThis looks cleaner to me.\n\nSigned-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>\n---\n\nChanges in v2: None\n\n drivers/mtd/nand/denali.c | 22 +++-------------------\n 1 file changed, 3 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c\nindex aefdc83..d847ae4 100644\n--- a/drivers/mtd/nand/denali.c\n+++ b/drivers/mtd/nand/denali.c\n@@ -208,24 +208,6 @@ static uint32_t denali_check_irq(struct denali_nand_info *denali)\n \treturn irq_status;\n }\n \n-/*\n- * This helper function setups the registers for ECC and whether or not\n- * the spare area will be transferred.\n- */\n-static void setup_ecc_for_xfer(struct denali_nand_info *denali, bool ecc_en,\n-\t\t\t\tbool transfer_spare)\n-{\n-\tint ecc_en_flag, transfer_spare_flag;\n-\n-\t/* set ECC, transfer spare bits if needed */\n-\tecc_en_flag = ecc_en ? ECC_ENABLE__FLAG : 0;\n-\ttransfer_spare_flag = transfer_spare ? TRANSFER_SPARE_REG__FLAG : 0;\n-\n-\t/* Enable spare area/ECC per user's request. */\n-\tiowrite32(ecc_en_flag, denali->reg + ECC_ENABLE);\n-\tiowrite32(transfer_spare_flag, denali->reg + TRANSFER_SPARE_REG);\n-}\n-\n static void denali_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)\n {\n \tstruct denali_nand_info *denali = mtd_to_denali(mtd);\n@@ -659,7 +641,9 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf,\n static int denali_data_xfer(struct denali_nand_info *denali, void *buf,\n \t\t\t size_t size, int page, int raw, int write)\n {\n-\tsetup_ecc_for_xfer(denali, !raw, raw);\n+\tiowrite32(raw ? 0 : ECC_ENABLE__FLAG, denali->reg + ECC_ENABLE);\n+\tiowrite32(raw ? TRANSFER_SPARE_REG__FLAG : 0,\n+\t\t denali->reg + TRANSFER_SPARE_REG);\n \n \tif (denali->dma_avail)\n \t\treturn denali_dma_xfer(denali, buf, size, page, raw, write);\n", "prefixes": [ "v2", "01/12" ] }