Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817118/?format=api
{ "id": 817118, "url": "http://patchwork.ozlabs.org/api/patches/817118/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-23-git-send-email-allen.lkml@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1506013525-29291-23-git-send-email-allen.lkml@gmail.com>", "list_archive_url": null, "date": "2017-09-21T17:04:43", "name": "[22/64] drivers: net: natsemi: use setup_timer() helper.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8634ff1023390d14a55d9fe4998b195418eef211", "submitter": { "id": 72354, "url": "http://patchwork.ozlabs.org/api/people/72354/?format=api", "name": "Allen Pais", "email": "allen.lkml@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-23-git-send-email-allen.lkml@gmail.com/mbox/", "series": [ { "id": 4448, "url": "http://patchwork.ozlabs.org/api/series/4448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4448", "date": "2017-09-21T17:04:27", "name": "use setup_timer() helper function.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4448/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817118/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817118/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SuC7YHAQ\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykGr3TM5z9ryv\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 03:33:24 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752387AbdIURIG (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 13:08:06 -0400", "from mail-pg0-f65.google.com ([74.125.83.65]:34820 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752371AbdIURIC (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 21 Sep 2017 13:08:02 -0400", "by mail-pg0-f65.google.com with SMTP id j16so3745772pga.2;\n\tThu, 21 Sep 2017 10:08:01 -0700 (PDT)", "from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.07.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:08:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=s/cpplDAsoMatSy7wzbWOpIwOHeIF5jl6MUm3Lh0VeQ=;\n\tb=SuC7YHAQf7IxCSWKPj/mgABKrD5Xzm4pAN/f2+Bsb58TJzRGlaYY+CxgPBiwijzJSB\n\tdTOIe0rWLTzA9yi3jPkbOccD6n9/B8B27OslDLjSzXq6L3b+8/KhCrv8dH30ftNn64Ub\n\tsVhClGTMaE5kyK36CCemwUu2bdsllWgGS3kJ9xLz0528uMyN3VFwnEfdBIILq8bhvC6o\n\tLAooD0YIE2IZ+S60Z9EKnD6RwVYVDadtGNXG7pTzoitQ0JYsy9cp34JeFHibzur5OvUR\n\tJVW7eSwgDE7cfidKLiWKE9HHyVKSZB8xSPZ2XiAD0jWjAGknKHFKpOvTfHQsmOeqRVcb\n\toG5A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=s/cpplDAsoMatSy7wzbWOpIwOHeIF5jl6MUm3Lh0VeQ=;\n\tb=DPqYufSsVS1NDPu35oamqlSWB3POVe22wyC/7C1ZpL0dcbVNDJFGf/RdOowff3sS+7\n\tT+Sr8eEMkKcUr9zBNvOuAoaEEUrpe2pH12TX3/dGTpdVmbww0Rwp3K6cb5MIY4AhKfSj\n\t014xGbqiNX/kVrWEsrjh0YnC0WK7cmjQIbaJS0mQccmsahsZ3UOabtuE8HTiDuB0gWjL\n\tkCbBSdRyI2pRXuoEhYZIERok4Myn49kLRBa+D/lYmhly9pqeDBOVDpRHKle696J1SUMA\n\t4mYONSy/FS3kiFkyTb2rVCZiwpMN9fzMx7JBJIkR65WOndlPnLSG+cW+EumztVYwcdXP\n\tDenA==", "X-Gm-Message-State": "AHPjjUjfRZfVYyKuW+dMCa8jlMuoSy1j2OUd7wmQi8r2TopLNJK/75tB\n\t8c1x+zSX5BVJIKNiUAmh1y/ngdh/", "X-Google-Smtp-Source": "AOwi7QBjfLJWAkjRi1QGl2M+oxeZXqd2dY23L2U0CP2qi9VN3jloh2hr33x/EPvChYaGjaUXCUT5Aw==", "X-Received": "by 10.98.201.20 with SMTP id k20mr6202689pfg.272.1506013681137; \n\tThu, 21 Sep 2017 10:08:01 -0700 (PDT)", "From": "Allen Pais <allen.lkml@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais <allen.lkml@gmail.com>", "Subject": "[PATCH 22/64] drivers: net: natsemi: use setup_timer() helper.", "Date": "Thu, 21 Sep 2017 22:34:43 +0530", "Message-Id": "<1506013525-29291-23-git-send-email-allen.lkml@gmail.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>", "References": "<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais <allen.lkml@gmail.com>\n---\n drivers/net/ethernet/natsemi/natsemi.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c\nindex 18af2a2..dedeacd 100644\n--- a/drivers/net/ethernet/natsemi/natsemi.c\n+++ b/drivers/net/ethernet/natsemi/natsemi.c\n@@ -1571,10 +1571,8 @@ static int netdev_open(struct net_device *dev)\n \t\t\tdev->name, (int)readl(ioaddr + ChipCmd));\n \n \t/* Set the timer to check for link beat. */\n-\tinit_timer(&np->timer);\n+\tsetup_timer(&np->timer, netdev_timer, (unsigned long)dev);\n \tnp->timer.expires = round_jiffies(jiffies + NATSEMI_TIMER_FREQ);\n-\tnp->timer.data = (unsigned long)dev;\n-\tnp->timer.function = netdev_timer; /* timer handler */\n \tadd_timer(&np->timer);\n \n \treturn 0;\n", "prefixes": [ "22/64" ] }