Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/817087/?format=api
{ "id": 817087, "url": "http://patchwork.ozlabs.org/api/patches/817087/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-52-git-send-email-allen.lkml@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1506013525-29291-52-git-send-email-allen.lkml@gmail.com>", "list_archive_url": null, "date": "2017-09-21T17:05:12", "name": "[51/64] drivers: net: caif: use setup_timer() helper.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9d203e7e2038c74107eff48dc76572be1cd27aee", "submitter": { "id": 72354, "url": "http://patchwork.ozlabs.org/api/people/72354/?format=api", "name": "Allen Pais", "email": "allen.lkml@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-52-git-send-email-allen.lkml@gmail.com/mbox/", "series": [ { "id": 4448, "url": "http://patchwork.ozlabs.org/api/series/4448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4448", "date": "2017-09-21T17:04:27", "name": "use setup_timer() helper function.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4448/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/817087/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/817087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KeycH/Xo\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyjz82n0fz9t49\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 03:19:48 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753020AbdIURLJ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 13:11:09 -0400", "from mail-pf0-f194.google.com ([209.85.192.194]:36972 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752441AbdIURLG (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 21 Sep 2017 13:11:06 -0400", "by mail-pf0-f194.google.com with SMTP id e69so2715485pfg.4;\n\tThu, 21 Sep 2017 10:11:05 -0700 (PDT)", "from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.10.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:11:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=5FqrShsIO7lSImMM9gaedGQPb17ewGqQnR2vGbZPUVs=;\n\tb=KeycH/XorYHOdqx0wrk0TFUuqn4YkOa0HqgFhRzDEpmllFMldC3CxvP6IuFOJT/0mV\n\t9J+LQJtT2fMx9YaYeiYVkcsIqSMvauOYA21fawtG0rZLFgL2sa+aZJ1vtVF85NUc3HhV\n\t85pj2HE4q0iTMAKwZmR+lxaboXbMIIURCfG2sSx7q/9hiBZjj2PDQKKTAr71xutqg9pI\n\tEsNJGXrCMTpiiY0UDdm/gnZ9RfcOJgW+UxkdymP43DvAzdL6/lnlL17amOuhbsdiVMKq\n\ty3XY8ziTklZkcvJg9CXgozTzxIeJ9sNOBIRmWLjFxLlmqjPQc7p+58ANFoXIli5ctZZz\n\tbYRg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=5FqrShsIO7lSImMM9gaedGQPb17ewGqQnR2vGbZPUVs=;\n\tb=WT0xcGv3t03R7rX5xHKwcG/lkiMhaV26ESfHHjAdbXeb36SmquKN7wUoQTrvXAqh81\n\t6AXc/O0YlbMKrNodqKzvB/dNco4E0ZvkIcYWMnkxQSdMYfKdtJlRsvoZr1wWZiRmYolk\n\tW4lJDQaN3Z2jpTvaBQk+80K/nCSaeGGqAEx6dHTEa/b+A4CCpkerveFv/PsHI66d5GGN\n\teWfJ3KOnZym0a9M6v+j2FI2XTriNc1MEJXIcFcOvtlJCkNjXmK28wqt4u4QAZHYQRH/x\n\t1pMwXCkJxL8JRCZkjS0S4w3PHG4D83zLSR+LORjDM3wi9px+Lh1lATdn127h9JO1XEV2\n\tO/zw==", "X-Gm-Message-State": "AHPjjUjBUOrxoxF8kTJV3G/C2B2i5IwvPEMhog0xuPyKQTpud2bVFTK7\n\t16mNMUi6jZk8QcGCRetHgmY229Lh", "X-Google-Smtp-Source": "AOwi7QCZpEIrPYvlGRuWRkCSJOMqhgrG7/lvFj7EYu9csz+gdaw2QBdY0esdfJtvilr/ydTZs9clfg==", "X-Received": "by 10.98.78.203 with SMTP id c194mr6426085pfb.152.1506013865084; \n\tThu, 21 Sep 2017 10:11:05 -0700 (PDT)", "From": "Allen Pais <allen.lkml@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais <allen.lkml@gmail.com>", "Subject": "[PATCH 51/64] drivers: net: caif: use setup_timer() helper.", "Date": "Thu, 21 Sep 2017 22:35:12 +0530", "Message-Id": "<1506013525-29291-52-git-send-email-allen.lkml@gmail.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>", "References": "<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais <allen.lkml@gmail.com>\n---\n drivers/net/caif/caif_hsi.c | 15 ++++++---------\n 1 file changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c\nindex 438966b..fed75e7 100644\n--- a/drivers/net/caif/caif_hsi.c\n+++ b/drivers/net/caif/caif_hsi.c\n@@ -1211,17 +1211,14 @@ static int cfhsi_open(struct net_device *ndev)\n \tinit_waitqueue_head(&cfhsi->flush_fifo_wait);\n \n \t/* Setup the inactivity timer. */\n-\tinit_timer(&cfhsi->inactivity_timer);\n-\tcfhsi->inactivity_timer.data = (unsigned long)cfhsi;\n-\tcfhsi->inactivity_timer.function = cfhsi_inactivity_tout;\n+\tsetup_timer(&cfhsi->inactivity_timer, cfhsi_inactivity_tout,\n+\t\t (unsigned long)cfhsi);\n \t/* Setup the slowpath RX timer. */\n-\tinit_timer(&cfhsi->rx_slowpath_timer);\n-\tcfhsi->rx_slowpath_timer.data = (unsigned long)cfhsi;\n-\tcfhsi->rx_slowpath_timer.function = cfhsi_rx_slowpath;\n+\tsetup_timer(&cfhsi->rx_slowpath_timer, cfhsi_rx_slowpath,\n+\t\t (unsigned long)cfhsi);\n \t/* Setup the aggregation timer. */\n-\tinit_timer(&cfhsi->aggregation_timer);\n-\tcfhsi->aggregation_timer.data = (unsigned long)cfhsi;\n-\tcfhsi->aggregation_timer.function = cfhsi_aggregation_tout;\n+\tsetup_timer(&cfhsi->aggregation_timer, cfhsi_aggregation_tout,\n+\t\t (unsigned long)cfhsi);\n \n \t/* Activate HSI interface. */\n \tres = cfhsi->ops->cfhsi_up(cfhsi->ops);\n", "prefixes": [ "51/64" ] }