Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816957/?format=api
{ "id": 816957, "url": "http://patchwork.ozlabs.org/api/patches/816957/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1506007346-10037-9-git-send-email-jjhiblot@ti.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1506007346-10037-9-git-send-email-jjhiblot@ti.com>", "list_archive_url": null, "date": "2017-09-21T15:22:11", "name": "[U-Boot,08/23] mmc: omap_hsmmc: Reduce the max timeout for reset controller fsm", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "c92573493fb2e68e189ae75498d01e01b0c19a63", "submitter": { "id": 70508, "url": "http://patchwork.ozlabs.org/api/people/70508/?format=api", "name": "Jean-Jacques Hiblot", "email": "jjhiblot@ti.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1506007346-10037-9-git-send-email-jjhiblot@ti.com/mbox/", "series": [ { "id": 4414, "url": "http://patchwork.ozlabs.org/api/series/4414/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=4414", "date": "2017-09-21T15:22:03", "name": "mmc: omap5: Add support for UHS and HS200 modes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4414/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816957/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816957/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"NKVnteWQ\";\n\tdkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xygRk6yWTz9t43\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 01:25:54 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 9A364C22020; Thu, 21 Sep 2017 15:23:21 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2D657C21E63;\n\tThu, 21 Sep 2017 15:23:14 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 650CBC2205D; Thu, 21 Sep 2017 15:22:56 +0000 (UTC)", "from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17])\n\tby lists.denx.de (Postfix) with ESMTPS id 814CFC21E8A\n\tfor <u-boot@lists.denx.de>; Thu, 21 Sep 2017 15:22:52 +0000 (UTC)", "from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8LFMocN010592; \n\tThu, 21 Sep 2017 10:22:50 -0500", "from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LFMomj000335; \n\tThu, 21 Sep 2017 10:22:50 -0500", "from DLEE107.ent.ti.com (157.170.170.37) by DLEE107.ent.ti.com\n\t(157.170.170.37) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tThu, 21 Sep 2017 10:22:49 -0500", "from dlep32.itg.ti.com (157.170.170.100) by DLEE107.ent.ti.com\n\t(157.170.170.37) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Thu, 21 Sep 2017 10:22:49 -0500", "from localhost (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LFMmYG020801;\n\tThu, 21 Sep 2017 10:22:49 -0500" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506007370;\n\tbh=WNI9S5DbZG8G0OiOMBfCp04jGYcI4tk4jXwInG5v5JY=;\n\th=From:To:CC:Subject:Date:In-Reply-To:References;\n\tb=NKVnteWQnRQrjnLLWjR6LVx5MLX9+aicMBTTYvSYm1yrko19zmJ/4fhVqw1wwJnsv\n\tQoyY9bveM5Chf/azWI3KW8fBiU/BdDd5VG5XwN3bsfLfriasqE5VQYaRBz7Vjfdlse\n\t9aYVz+pwQ9bexWx35SIEmOXXAoiyobl7auQCdsZU=", "From": "Jean-Jacques Hiblot <jjhiblot@ti.com>", "To": "<jh80.chung@samsung.com>, <trini@konsulko.com>, <kishon@ti.com>,\n\t<sjg@chromium.org>, <lokeshvutla@ti.com>", "Date": "Thu, 21 Sep 2017 17:22:11 +0200", "Message-ID": "<1506007346-10037-9-git-send-email-jjhiblot@ti.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1506007346-10037-1-git-send-email-jjhiblot@ti.com>", "References": "<1506007346-10037-1-git-send-email-jjhiblot@ti.com>", "MIME-Version": "1.0", "X-EXCLAIMER-MD-CONFIG": "e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180", "Cc": "u-boot@lists.denx.de", "Subject": "[U-Boot] [PATCH 08/23] mmc: omap_hsmmc: Reduce the max timeout for\n\treset controller fsm", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "From OMAP3 SoCs (OMAP3, OMAP4, OMAP5, AM572x, AM571x), the DAT/CMD lines\nreset procedure section in TRM suggests to first poll the SRD/SRC bit\nuntil it is set to 0x1. But looks like that bit is never set to 1 and there\nis an observable delay of 1sec everytime the driver tries to reset DAT/CMD.\n(The same is observed in linux kernel).\n\nReduce the time the driver waits for the controller to set the SRC/SRD bits\nto 1 so that there is no observable delay.\n\nSigned-off-by: Kishon Vijay Abraham I <kishon@ti.com>\nSigned-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>\n---\n drivers/mmc/omap_hsmmc.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c\nindex 8e42410..116aa31 100644\n--- a/drivers/mmc/omap_hsmmc.c\n+++ b/drivers/mmc/omap_hsmmc.c\n@@ -108,6 +108,7 @@ struct omap_hsmmc_adma_desc {\n \n /* If we fail after 1 second wait, something is really bad */\n #define MAX_RETRY_MS\t1000\n+#define MMC_TIMEOUT_MS\t20\n \n /* DMA transfers can take a long time if a lot a data is transfered.\n * The timeout must take in account the amount of data. Let's assume\n@@ -596,7 +597,7 @@ static void mmc_reset_controller_fsm(struct hsmmc *mmc_base, u32 bit)\n \tif (!(readl(&mmc_base->sysctl) & bit)) {\n \t\tstart = get_timer(0);\n \t\twhile (!(readl(&mmc_base->sysctl) & bit)) {\n-\t\t\tif (get_timer(0) - start > MAX_RETRY_MS)\n+\t\t\tif (get_timer(0) - start > MMC_TIMEOUT_MS)\n \t\t\t\treturn;\n \t\t}\n \t}\n", "prefixes": [ "U-Boot", "08/23" ] }