Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 816867,
    "url": "http://patchwork.ozlabs.org/api/patches/816867/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1506000722-40095-3-git-send-email-zhangshengju@cmss.chinamobile.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1506000722-40095-3-git-send-email-zhangshengju@cmss.chinamobile.com>",
    "list_archive_url": null,
    "date": "2017-09-21T13:32:02",
    "name": "[net-next,2/2] ifb: add device MTU validation check",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "a3eb4f76d5070ccd3f95e4ae42ccbd5665d99e0d",
    "submitter": {
        "id": 66922,
        "url": "http://patchwork.ozlabs.org/api/people/66922/?format=api",
        "name": "Zhang Shengju",
        "email": "zhangshengju@cmss.chinamobile.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1506000722-40095-3-git-send-email-zhangshengju@cmss.chinamobile.com/mbox/",
    "series": [
        {
            "id": 4389,
            "url": "http://patchwork.ozlabs.org/api/series/4389/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4389",
            "date": "2017-09-21T13:32:00",
            "name": "add device MTU validation check",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/4389/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/816867/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/816867/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xycxD3CCXz9t43\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 23:32:48 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751678AbdIUNcU (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 09:32:20 -0400",
            "from cmccmta3.chinamobile.com ([221.176.66.81]:25817 \"EHLO\n\tcmccmta3.chinamobile.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751617AbdIUNcT (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 21 Sep 2017 09:32:19 -0400",
            "from spf.mail.chinamobile.com (unknown[172.16.121.5]) by\n\trmmx-syy-dmz-app09-12009 (RichMail) with SMTP id\n\t2ee959c3bf5dd58-f1243; Thu, 21 Sep 2017 21:32:14 +0800 (CST)",
            "from promote.cache-dns.local (unknown[112.25.154.148])\n\tby rmsmtp-syy-appsvr03-12003 (RichMail) with SMTP id\n\t2ee359c3bf5395a-06c7c; Thu, 21 Sep 2017 21:32:14 +0800 (CST)"
        ],
        "X-RM-TRANSID": [
            "2ee959c3bf5dd58-f1243",
            "2ee359c3bf5395a-06c7c"
        ],
        "X-RM-SPAM-FLAG": "00000000",
        "From": "Zhang Shengju <zhangshengju@cmss.chinamobile.com>",
        "To": "davem@davemloft.net, willemb@google.com,\n\tstephen@networkplumber.org, netdev@vger.kernel.org",
        "Subject": "[net-next 2/2] ifb: add device MTU validation check",
        "Date": "Thu, 21 Sep 2017 21:32:02 +0800",
        "Message-Id": "<1506000722-40095-3-git-send-email-zhangshengju@cmss.chinamobile.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1506000722-40095-1-git-send-email-zhangshengju@cmss.chinamobile.com>",
        "References": "<1506000722-40095-1-git-send-email-zhangshengju@cmss.chinamobile.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Currently, any mtu value can be assigned when adding a new ifb device:\n[~]# ip link add name ifb2 mtu 100000 type ifb\n[~]# ip link show ifb2\n18: ifb2: <BROADCAST,NOARP> mtu 100000 qdisc noop state DOWN mode DEFAULT group default qlen 32\n    link/ether 7a:bf:f4:63:da:d1 brd ff:ff:ff:ff:ff:ff\n\nThis patch adds device MTU validation check.\n\nSigned-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>\n---\n drivers/net/ifb.c | 8 ++++++++\n 1 file changed, 8 insertions(+)",
    "diff": "diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c\nindex 8870bd2..ce84ad2 100644\n--- a/drivers/net/ifb.c\n+++ b/drivers/net/ifb.c\n@@ -282,6 +282,14 @@ static int ifb_validate(struct nlattr *tb[], struct nlattr *data[],\n \t\tif (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS])))\n \t\t\treturn -EADDRNOTAVAIL;\n \t}\n+\n+\tif (tb[IFLA_MTU]) {\n+\t\tu32 mtu = nla_get_u32(tb[IFLA_MTU]);\n+\n+\t\tif (mtu < ETH_MIN_MTU || mtu > ETH_DATA_LEN)\n+\t\t\treturn -EINVAL;\n+\t}\n+\n \treturn 0;\n }\n \n",
    "prefixes": [
        "net-next",
        "2/2"
    ]
}