Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816767/?format=api
{ "id": 816767, "url": "http://patchwork.ozlabs.org/api/patches/816767/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170921085110.25598-19-aik@ozlabs.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170921085110.25598-19-aik@ozlabs.ru>", "list_archive_url": null, "date": "2017-09-21T08:51:10", "name": "[qemu,v5,18/18] memory: Avoid temporary FlatView allocation in a single child case", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "560815e6729a51bbb42b7a2c8051c0af38d75112", "submitter": { "id": 7621, "url": "http://patchwork.ozlabs.org/api/people/7621/?format=api", "name": "Alexey Kardashevskiy", "email": "aik@ozlabs.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170921085110.25598-19-aik@ozlabs.ru/mbox/", "series": [ { "id": 4333, "url": "http://patchwork.ozlabs.org/api/series/4333/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4333", "date": "2017-09-21T08:50:55", "name": "memory: Store physical root MR in FlatView", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/4333/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816767/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816767/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyVtB6B82z9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 18:59:46 +1000 (AEST)", "from localhost ([::1]:52454 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1duxKj-0003Cq-03\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 04:59:45 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:48589)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1duxCw-0005Cc-Im\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:51:43 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1duxCv-0001Q2-Jj\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:51:42 -0400", "from ozlabs.ru ([107.173.13.209]:54112)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aik@ozlabs.ru>) id 1duxCv-0001CA-Dp\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:51:41 -0400", "from vpl1.ozlabs.ibm.com (localhost [IPv6:::1])\n\tby ozlabs.ru (Postfix) with ESMTP id 47D483A6005A;\n\tThu, 21 Sep 2017 04:52:57 -0400 (EDT)" ], "From": "Alexey Kardashevskiy <aik@ozlabs.ru>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 21 Sep 2017 18:51:10 +1000", "Message-Id": "<20170921085110.25598-19-aik@ozlabs.ru>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170921085110.25598-1-aik@ozlabs.ru>", "References": "<20170921085110.25598-1-aik@ozlabs.ru>", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [fuzzy]", "X-Received-From": "107.173.13.209", "Subject": "[Qemu-devel] [PATCH qemu v5 18/18] memory: Avoid temporary FlatView\n\tallocation in a single child case", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The root MR may be enabled but the only child may be not (this is\nthe case for the PCI bus master address space) so check this and avoid\nallocating temporary FV if that nested MR is not enabled.\n\nThis does not make any difference though.\n\nSigned-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>\n---\n memory.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/memory.c b/memory.c\nindex 5c21563745..bf71f19fec 100644\n--- a/memory.c\n+++ b/memory.c\n@@ -748,9 +748,14 @@ static FlatView *generate_memory_topology(MemoryRegion *mr)\n int i;\n FlatView *view;\n bool use_empty = false;\n+ MemoryRegion *child = QTAILQ_FIRST(&mr->subregions);\n \n if (!mr->enabled) {\n use_empty = true;\n+ } else if (child && !child->enabled &&\n+ !QTAILQ_NEXT(child, subregions_link) &&\n+ !child->addr && int128_eq(child->size, mr->size)) {\n+ use_empty = true;\n } else {\n view = flatview_new(mr);\n if (mr) {\n", "prefixes": [ "qemu", "v5", "18/18" ] }