Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816739/?format=api
{ "id": 816739, "url": "http://patchwork.ozlabs.org/api/patches/816739/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1505981969-49480-3-git-send-email-philipp.tomsich@theobroma-systems.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505981969-49480-3-git-send-email-philipp.tomsich@theobroma-systems.com>", "list_archive_url": null, "date": "2017-09-21T08:19:25", "name": "[U-Boot,v3,2/6] arm: mark save_boot_params_ret as a function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7ed220f8956c3c8ce11a4f9dd6f4c5c5a5293717", "submitter": { "id": 53488, "url": "http://patchwork.ozlabs.org/api/people/53488/?format=api", "name": "Philipp Tomsich", "email": "philipp.tomsich@theobroma-systems.com" }, "delegate": { "id": 69486, "url": "http://patchwork.ozlabs.org/api/users/69486/?format=api", "username": "ptomsich", "first_name": "Philipp", "last_name": "Tomsich", "email": "philipp.tomsich@theobroma-systems.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1505981969-49480-3-git-send-email-philipp.tomsich@theobroma-systems.com/mbox/", "series": [ { "id": 4327, "url": "http://patchwork.ozlabs.org/api/series/4327/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=4327", "date": "2017-09-21T08:19:25", "name": "rockchip: back-to-bootrom: replace assembly-implementation with C-code", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/4327/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816739/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816739/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyV0828VNz9t3C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 18:19:52 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 0173FC21E23; Thu, 21 Sep 2017 08:19:48 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6782EC21E85;\n\tThu, 21 Sep 2017 08:19:46 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 11EF5C21E85; Thu, 21 Sep 2017 08:19:44 +0000 (UTC)", "from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id B4E56C21E23\n\tfor <u-boot@lists.denx.de>; Thu, 21 Sep 2017 08:19:44 +0000 (UTC)", "from [86.59.122.178] (port=36209 helo=android.lan)\n\tby mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:RSA_AES_128_CBC_SHA256:128)\n\t(Exim 4.80) (envelope-from <philipp.tomsich@theobroma-systems.com>)\n\tid 1duwhy-0003Re-NO; Thu, 21 Sep 2017 10:19:42 +0200" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "From": "Philipp Tomsich <philipp.tomsich@theobroma-systems.com>", "To": "u-boot@lists.denx.de", "Date": "Thu, 21 Sep 2017 10:19:25 +0200", "Message-Id": "<1505981969-49480-3-git-send-email-philipp.tomsich@theobroma-systems.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1505981969-49480-1-git-send-email-philipp.tomsich@theobroma-systems.com>", "References": "<1505981969-49480-1-git-send-email-philipp.tomsich@theobroma-systems.com>", "Cc": "Nisal Menuka <nisalmenuka23@gmail.com>,\n\tKlaus Goger <klaus.goger@theobroma-systems.com>,\n\tAndy Yan <andy.yan@rock-chips.com>", "Subject": "[U-Boot] [PATCH v3 2/6] arm: mark save_boot_params_ret as a function", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "As no '.type' was set for save_boot_params_ret in start.S, binutils\ndid not track whether it was emitted as A32 or T32. By properly\nmarking save_boot_params_ret as a potential function entry, we can\nmake sure that the compiler will insert the appropriate instructions\nfor branching to save_boot_params_ret both for call-sites emitted as\nA32 and T32.\n\nReported-by: Andy Yan <andy.yan@rock-chips.com>\nSigned-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\nTested-by: Andy Yan <andy.yan@rock-chips.com>\n\n---\n\nChanges in v3:\n- tracked the root-cause why no interwork branch was emitted and fixed\n it using a '.type'-directive in start.S to mark save_boot_params_ret\n as a (possible) function-entry.\n\nChanges in v2: None\n\n arch/arm/cpu/armv7/start.S | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S\nindex 7b84a7a..95a0b52 100644\n--- a/arch/arm/cpu/armv7/start.S\n+++ b/arch/arm/cpu/armv7/start.S\n@@ -31,6 +31,7 @@\n \n \t.globl\treset\n \t.globl\tsave_boot_params_ret\n+\t.type save_boot_params_ret,%function\n #ifdef CONFIG_ARMV7_LPAE\n \t.global\tswitch_to_hypervisor_ret\n #endif\n", "prefixes": [ "U-Boot", "v3", "2/6" ] }