Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816714/?format=api
{ "id": 816714, "url": "http://patchwork.ozlabs.org/api/patches/816714/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170921071634.16883-4-ubraun@linux.vnet.ibm.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170921071634.16883-4-ubraun@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-09-21T07:16:28", "name": "[net,3/9] net/smc: take RCU read lock for routing cache lookup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6f1b942f0138aca6ea3313ad3fbcb705d520bfa6", "submitter": { "id": 2266, "url": "http://patchwork.ozlabs.org/api/people/2266/?format=api", "name": "Ursula Braun", "email": "ubraun@linux.vnet.ibm.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170921071634.16883-4-ubraun@linux.vnet.ibm.com/mbox/", "series": [ { "id": 4314, "url": "http://patchwork.ozlabs.org/api/series/4314/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4314", "date": "2017-09-21T07:16:25", "name": "net/smc: bug fixes 2017-09-20", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4314/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816714/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816714/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xySbT2PC1z9sBZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 17:16:53 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751892AbdIUHQu (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 03:16:50 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:41292 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751854AbdIUHQq (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 21 Sep 2017 03:16:46 -0400", "from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8L7GeDd083925\n\tfor <netdev@vger.kernel.org>; Thu, 21 Sep 2017 03:16:45 -0400", "from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d48cy1b7c-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <netdev@vger.kernel.org>; Thu, 21 Sep 2017 03:16:45 -0400", "from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <netdev@vger.kernel.org> from <ubraun@linux.vnet.ibm.com>;\n\tThu, 21 Sep 2017 08:16:43 +0100", "from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 21 Sep 2017 08:16:41 +0100", "from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com\n\t[9.149.105.60])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8L7GePc18808866; Thu, 21 Sep 2017 07:16:40 GMT", "from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E321D42041;\n\tThu, 21 Sep 2017 08:12:50 +0100 (BST)", "from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9BCEA4203F;\n\tThu, 21 Sep 2017 08:12:50 +0100 (BST)", "from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tThu, 21 Sep 2017 08:12:50 +0100 (BST)" ], "From": "Ursula Braun <ubraun@linux.vnet.ibm.com>", "To": "davem@davemloft.net", "Cc": "netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, jwi@linux.vnet.ibm.com,\n\tschwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,\n\traspl@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com", "Subject": "[PATCH net 3/9] net/smc: take RCU read lock for routing cache lookup", "Date": "Thu, 21 Sep 2017 09:16:28 +0200", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170921071634.16883-1-ubraun@linux.vnet.ibm.com>", "References": "<20170921071634.16883-1-ubraun@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17092107-0008-0000-0000-00000498E217", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17092107-0009-0000-0000-00001E2A1BB3", "Message-Id": "<20170921071634.16883-4-ubraun@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-21_01:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709210099", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "smc_netinfo_by_tcpsk() looks up the routing cache. Such a lookup requires\nprotection by an RCU read lock.\n\nSigned-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>\n---\n net/smc/af_smc.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c\nindex 8c6d24b2995d..2e8d2dabac0c 100644\n--- a/net/smc/af_smc.c\n+++ b/net/smc/af_smc.c\n@@ -282,6 +282,7 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock,\n \t\t\t __be32 *subnet, u8 *prefix_len)\n {\n \tstruct dst_entry *dst = sk_dst_get(clcsock->sk);\n+\tstruct in_device *in_dev;\n \tstruct sockaddr_in addr;\n \tint rc = -ENOENT;\n \tint len;\n@@ -298,14 +299,17 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock,\n \t/* get address to which the internal TCP socket is bound */\n \tkernel_getsockname(clcsock, (struct sockaddr *)&addr, &len);\n \t/* analyze IPv4 specific data of net_device belonging to TCP socket */\n-\tfor_ifa(dst->dev->ip_ptr) {\n-\t\tif (ifa->ifa_address != addr.sin_addr.s_addr)\n+\trcu_read_lock();\n+\tin_dev = __in_dev_get_rcu(dst->dev);\n+\tfor_ifa(in_dev) {\n+\t\tif (!inet_ifa_match(addr.sin_addr.s_addr, ifa))\n \t\t\tcontinue;\n \t\t*prefix_len = inet_mask_len(ifa->ifa_mask);\n \t\t*subnet = ifa->ifa_address & ifa->ifa_mask;\n \t\trc = 0;\n \t\tbreak;\n-\t} endfor_ifa(dst->dev->ip_ptr);\n+\t} endfor_ifa(in_dev);\n+\trcu_read_unlock();\n \n out_rel:\n \tdst_release(dst);\n", "prefixes": [ "net", "3/9" ] }