Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816693/?format=api
{ "id": 816693, "url": "http://patchwork.ozlabs.org/api/patches/816693/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170921064338.1282-7-jiri@resnulli.us/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170921064338.1282-7-jiri@resnulli.us>", "list_archive_url": null, "date": "2017-09-21T06:43:32", "name": "[net-next,06/12] net: mroute: Check if rule is a default rule", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e709ce4008d919eca62c25123c9a2c0efc7debb0", "submitter": { "id": 15321, "url": "http://patchwork.ozlabs.org/api/people/15321/?format=api", "name": "Jiri Pirko", "email": "jiri@resnulli.us" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170921064338.1282-7-jiri@resnulli.us/mbox/", "series": [ { "id": 4309, "url": "http://patchwork.ozlabs.org/api/series/4309/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4309", "date": "2017-09-21T06:43:26", "name": "mlxsw: Add support for offloading IPv4 multicast routes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4309/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816693/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"aGqQWrIS\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyRsK1tlQz9s7g\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 16:43:49 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751931AbdIUGnr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 02:43:47 -0400", "from mail-wm0-f68.google.com ([74.125.82.68]:35179 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751896AbdIUGnp (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 21 Sep 2017 02:43:45 -0400", "by mail-wm0-f68.google.com with SMTP id e64so4294925wmi.2\n\tfor <netdev@vger.kernel.org>; Wed, 20 Sep 2017 23:43:44 -0700 (PDT)", "from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\t133sm902645wmu.4.2017.09.20.23.43.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 23:43:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=/ZmiMONj29sADZfOfHp8fPrjcx/lKC7QeJh6FtBMMAY=;\n\tb=aGqQWrIS3F8TyEShLgNI4xmS4L9XmIEjZU8gjlniIFhYFxXmuZOCVCINc5qTh+vHI5\n\tYjWfpWkoPWCYDH7qvlhXHGO9qKfXVS/TOFlhBAJeSE8/BZE+9POW80a9/8s0K7D5w23o\n\thXU5+CPW34yesdP+pa2el8nwtVcKpvv2sNpsXbZW6sklqLgNlKBJxXPRDhG46KkjhahU\n\tvvMQ2AC9kR7lxa5AZ7MjYRlm8OOFKCt+a3c3rKZYeJ2GqHqSCSjydya59AOjrjA37tVe\n\toTliRMm0hCmlwGNGGRpojYsZZhG2GN+HuxTnEegMsAa2wJ7CiYyKk+4Dv+j/ynBsYiKR\n\t16bw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=/ZmiMONj29sADZfOfHp8fPrjcx/lKC7QeJh6FtBMMAY=;\n\tb=mACoiHcLD50bauiA3oXRpitAxPdPlaRXnBJT8w7Psm2hcnEMdLEAykJ2JMUZ+PGSRg\n\ttRD38AhsqHG4P+xll6V0GeOTVwQQI/J1EKw42A0TF97YosYJ4Q96H9s5Skf7IPv5gBV3\n\tuo4Z6OazYSo9qEFsC61B7lWQnQNhNf2HQA2TWL4cB62fYYRNfS/AOE3iuhg1UIcmJZ/F\n\tX0YcroAfdZv0pNWntQWL2Oc5A5z7gzWzpUTpNXC63jvocTfjompS++ZVJ5Ls2pQ4o8qG\n\tvxyTNHG909rTDQb87Ew5SoZGqBRRe01QiQN5CtxM8+CeNb0vYj89DfssX0iRflzHXM7o\n\tTtlg==", "X-Gm-Message-State": "AHPjjUiqzam1q/Hr1owDJPzsC10ulGgU+eqqyWVIO8eQEImBEGevidOL\n\tQRejfj1y4g1Q4YTKP1lm1nigI2Iq", "X-Google-Smtp-Source": "AOwi7QDh6GHbmLdUPzUHWzAOZlxsgEjqNO331LAHUnT25c6cYUytskLwrdC5EyBSyArAYY2H8Bz1/A==", "X-Received": "by 10.28.4.135 with SMTP id 129mr10367wme.34.1505976224148;\n\tWed, 20 Sep 2017 23:43:44 -0700 (PDT)", "From": "Jiri Pirko <jiri@resnulli.us>", "To": "netdev@vger.kernel.org", "Cc": "davem@davemloft.net, yotamg@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com", "Subject": "[patch net-next 06/12] net: mroute: Check if rule is a default rule", "Date": "Thu, 21 Sep 2017 08:43:32 +0200", "Message-Id": "<20170921064338.1282-7-jiri@resnulli.us>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20170921064338.1282-1-jiri@resnulli.us>", "References": "<20170921064338.1282-1-jiri@resnulli.us>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Yotam Gigi <yotamg@mellanox.com>\n\nWhen the ipmr starts, it adds one default FIB rule that matches all packets\nand sends them to the DEFAULT (multicast) FIB table. A more complex rule\ncan be added by user to specify that for a specific interface, a packet\nshould be look up at either an arbitrary table or according to the l3mdev\nof the interface.\n\nFor drivers willing to offload the ipmr logic into a hardware but don't\nwant to offload all the FIB rules functionality, provide a function that\ncan indicate whether the FIB rule is the default multicast rule, thus only\none routing table is needed.\n\nThis way, a driver can register to the FIB notification chain, get\nnotifications about FIB rules added and trigger some kind of an internal\nabort mechanism when a non default rule is added by the user.\n\nSigned-off-by: Yotam Gigi <yotamg@mellanox.com>\nReviewed-by: Ido Schimmel <idosch@mellanox.com>\nSigned-off-by: Jiri Pirko <jiri@mellanox.com>\n---\n include/linux/mroute.h | 7 +++++++\n net/ipv4/ipmr.c | 10 ++++++++++\n 2 files changed, 17 insertions(+)", "diff": "diff --git a/include/linux/mroute.h b/include/linux/mroute.h\nindex 9b64587..585369d 100644\n--- a/include/linux/mroute.h\n+++ b/include/linux/mroute.h\n@@ -5,6 +5,7 @@\n #include <linux/pim.h>\n #include <linux/rhashtable.h>\n #include <net/sock.h>\n+#include <net/fib_rules.h>\n #include <net/fib_notifier.h>\n #include <uapi/linux/mroute.h>\n \n@@ -19,6 +20,7 @@ int ip_mroute_getsockopt(struct sock *, int, char __user *, int __user *);\n int ipmr_ioctl(struct sock *sk, int cmd, void __user *arg);\n int ipmr_compat_ioctl(struct sock *sk, unsigned int cmd, void __user *arg);\n int ip_mr_init(void);\n+bool ipmr_rule_default(const struct fib_rule *rule);\n #else\n static inline int ip_mroute_setsockopt(struct sock *sock, int optname,\n \t\t\t\t char __user *optval, unsigned int optlen)\n@@ -46,6 +48,11 @@ static inline int ip_mroute_opt(int opt)\n {\n \treturn 0;\n }\n+\n+static inline bool ipmr_rule_default(const struct fib_rule *rule)\n+{\n+\treturn true;\n+}\n #endif\n \n struct vif_device {\ndiff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c\nindex 6804885..6e1de35 100644\n--- a/net/ipv4/ipmr.c\n+++ b/net/ipv4/ipmr.c\n@@ -320,6 +320,16 @@ static unsigned int ipmr_rules_seq_read(struct net *net)\n }\n #endif\n \n+bool ipmr_rule_default(const struct fib_rule *rule)\n+{\n+#if IS_ENABLED(CONFIG_FIB_RULES)\n+\treturn fib_rule_matchall(rule) && rule->table == RT_TABLE_DEFAULT;\n+#else\n+\treturn true;\n+#endif\n+}\n+EXPORT_SYMBOL(ipmr_rule_default);\n+\n static inline int ipmr_hash_cmp(struct rhashtable_compare_arg *arg,\n \t\t\t\tconst void *ptr)\n {\n", "prefixes": [ "net-next", "06/12" ] }