Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816579/?format=api
{ "id": 816579, "url": "http://patchwork.ozlabs.org/api/patches/816579/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170920225214.21974-3-f.fainelli@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170920225214.21974-3-f.fainelli@gmail.com>", "list_archive_url": null, "date": "2017-09-20T22:52:14", "name": "[net,2/2] net: phy: Keep reporting transceiver type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "213d2f82b1933592b905fbb1b859bfa6e6ba208d", "submitter": { "id": 2800, "url": "http://patchwork.ozlabs.org/api/people/2800/?format=api", "name": "Florian Fainelli", "email": "f.fainelli@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170920225214.21974-3-f.fainelli@gmail.com/mbox/", "series": [ { "id": 4252, "url": "http://patchwork.ozlabs.org/api/series/4252/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4252", "date": "2017-09-20T22:52:12", "name": "Bring back transceiver type for PHYLIB", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/4252/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816579/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816579/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JqjjzAy8\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyFPR5YDrz9sNr\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 08:52:27 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752020AbdITWw0 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 20 Sep 2017 18:52:26 -0400", "from mail-qt0-f196.google.com ([209.85.216.196]:33445 \"EHLO\n\tmail-qt0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751988AbdITWwY (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 20 Sep 2017 18:52:24 -0400", "by mail-qt0-f196.google.com with SMTP id b1so2707348qtc.0\n\tfor <netdev@vger.kernel.org>; Wed, 20 Sep 2017 15:52:24 -0700 (PDT)", "from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id c1sm11823qkg.55.2017.09.20.15.52.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 15:52:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=sfaWbWhTmQfySouvequcayUXBMggqYpWZAmIo5dKR5w=;\n\tb=JqjjzAy8ll2d6hR+FBiNj1tH0MbvUPIFWsV+fSl923DgK0Ier/dY0OpTWGzKQfS0VZ\n\trZQY2B3pFQD+ocXgE5SD+b34YoMM5kSJCaWhSMeFaQLNzWA8Bw1Wi39MQRO9FXLPEBb2\n\tvzNnxpA0IpenRHMQd4/sBe1xtSi5MUWepDLfn7j1p3LLbJD3GLbLzbw2hWQaKqX/zGkQ\n\t5HY76YNKUjiLQo3uDgMDGSeq4B7OLfjpB7zYIOaK7clX3P1vXAHJubwvJ95gZeKjG2ZP\n\tQTAcXDiA37WOVwpSUT1ioxorLaxaCItM9ke/EylfYXeMi1pGay4noreSG8geyzsHXefO\n\toIKg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=sfaWbWhTmQfySouvequcayUXBMggqYpWZAmIo5dKR5w=;\n\tb=Dr4hbENyzmSRkLX3Lp0hZiKS31qZCAjongnb1GcyCRIuClh1rwVQExZ369VyDypljL\n\tQOchdg9hEZYu8MboqHbCZSllqOtxe/KVCruwItNBI+Gj0YLpdFIpkyDQxTbC5wdjP/o7\n\tPs2zqkoFRNa2rRe4YR8CFwZTXrue5Uu8STeL8NybV2+QYkN7BiYKX8vT4O+X91dwGThd\n\tCnPrQOiQJKFePSRjOusQfGe7OlktH5UWvJysJyL9qTroTlTnUPSXAg6L6CL2MQF1Bowq\n\tEupiLEY/rLGGramRmlE4/c6at2E6t7X6O2Pw3BJWMnYyM/cXr/mR0fvK3/wIptlzgDZo\n\tOCiQ==", "X-Gm-Message-State": "AHPjjUhu1AnEsVxGqF08tMy8Pc1xjBg9hfo2QsvqumxjGnsA/Ye/6tgx\n\tOwjNd3vbTv/peKOa0hpz+hpNV/UP", "X-Google-Smtp-Source": "AOwi7QC4eHu2QsT5wGjtRVCKBcAKggS7tWSskS8Qggu4R1RnyVBJRDAG+8IkkkKMcEQBdpBw96Zvyw==", "X-Received": "by 10.200.43.204 with SMTP id n12mr417303qtn.207.1505947943800; \n\tWed, 20 Sep 2017 15:52:23 -0700 (PDT)", "From": "Florian Fainelli <f.fainelli@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "davem@davemloft.net, linville@tuxdriver.com, decot@googlers.com,\n\ttremyfr@gmail.com, andrew@lunn.ch,\n\tFlorian Fainelli <f.fainelli@gmail.com>", "Subject": "[PATCH net 2/2] net: phy: Keep reporting transceiver type", "Date": "Wed, 20 Sep 2017 15:52:14 -0700", "Message-Id": "<20170920225214.21974-3-f.fainelli@gmail.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170920225214.21974-1-f.fainelli@gmail.com>", "References": "<20170920225214.21974-1-f.fainelli@gmail.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "With commit 2d55173e71b0 (\"phy: add generic function to support\nksetting support\"), we lost the ability to report the transceiver type\nlike we used to. Now that we have added back the transceiver type to\nethtool_link_settings, we can report it back like we used to and have no\nloss of information.\n\nFixes: 3f1ac7a700d0 (\"net: ethtool: add new ETHTOOL_xLINKSETTINGS API\")\nFixes: 2d55173e71b0 (\"phy: add generic function to support ksetting support\")\nSigned-off-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n drivers/net/phy/phy.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c\nindex e842d2cd1ee7..2b1e67bc1e73 100644\n--- a/drivers/net/phy/phy.c\n+++ b/drivers/net/phy/phy.c\n@@ -373,7 +373,8 @@ void phy_ethtool_ksettings_get(struct phy_device *phydev,\n \t\tcmd->base.port = PORT_BNC;\n \telse\n \t\tcmd->base.port = PORT_MII;\n-\n+\tcmd->base.transceiver = phy_is_internal(phydev) ?\n+\t\t\t\tXCVR_INTERNAL : XCVR_EXTERNAL;\n \tcmd->base.phy_address = phydev->mdio.addr;\n \tcmd->base.autoneg = phydev->autoneg;\n \tcmd->base.eth_tp_mdix_ctrl = phydev->mdix_ctrl;\n", "prefixes": [ "net", "2/2" ] }