Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816484/?format=api
{ "id": 816484, "url": "http://patchwork.ozlabs.org/api/patches/816484/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1505940337-79069-23-git-send-email-keescook@chromium.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505940337-79069-23-git-send-email-keescook@chromium.org>", "list_archive_url": null, "date": "2017-09-20T20:45:28", "name": "[v3,22/31] sctp: Copy struct sctp_sock.autoclose to userspace using put_user()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "15ef045aee2b414c411110ab21ce8bfd04cdb32f", "submitter": { "id": 10641, "url": "http://patchwork.ozlabs.org/api/people/10641/?format=api", "name": "Kees Cook", "email": "keescook@chromium.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1505940337-79069-23-git-send-email-keescook@chromium.org/mbox/", "series": [ { "id": 4231, "url": "http://patchwork.ozlabs.org/api/series/4231/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=4231", "date": "2017-09-20T20:45:22", "name": "Hardened usercopy whitelisting", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/4231/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816484/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816484/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"QDdfAFVA\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyBdQ6gPzz9s83\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 06:47:38 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752021AbdITUqz (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 20 Sep 2017 16:46:55 -0400", "from mail-pg0-f44.google.com ([74.125.83.44]:53602 \"EHLO\n\tmail-pg0-f44.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751940AbdITUqQ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 20 Sep 2017 16:46:16 -0400", "by mail-pg0-f44.google.com with SMTP id j70so2326986pgc.10\n\tfor <netdev@vger.kernel.org>; Wed, 20 Sep 2017 13:46:16 -0700 (PDT)", "from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\ts68sm10988374pfd.72.2017.09.20.13.46.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 13:46:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=hS3AC84FoHkASZGLNsNZedW+0T2lp4pqYCvFt8TS/VA=;\n\tb=QDdfAFVA+EGn5K99o+iLHU2x0TgfylgKtt4TTXRbyCw3kRunAZXwJYYPBiMnX/K3xO\n\tc2UH4SvSrg9GNLiQyMmeXrAOQyCyey+7oXvWpVyTgItVxw0rc4vsymn/+yAnw++6b6qL\n\t+Fc2OLrrDGBMYnG0GnPATDDxiAPSXCg8X9B8I=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=hS3AC84FoHkASZGLNsNZedW+0T2lp4pqYCvFt8TS/VA=;\n\tb=i1RcMxrJLefVy5Dydkxr/0KcxrDVVtlfFFyPKfWmUczZf6W70+sCfY4s8fhq/YNYkN\n\tWqOjRjUxZdSS79r+KejadbSFQanLkAVNyJvsAUDdRpWEUkTVa2jyUSQ5HPlKkX+u8l0+\n\t1wO9F7RqPIt0fN2/nVzQLRS0Arn+HUl0H5xD/iuQtGMwSnGKfkCTrBhz6Dg7IJS5y9q4\n\tD0m+KSf7wHjnAHxbi7D0DusPLhaSFIDYjj/DJBi6s/olTxbkHJUblrmf0QzCFZ+73kyq\n\tbwl3O1JtYoHIguEZEKy6jlo04bD+D+9L4bPBEooJ5jWZjcVynDJUVcHiVHO0WL9NLTmB\n\ticHw==", "X-Gm-Message-State": "AHPjjUhLe2y3q7ARIeHDu8ICpuSIG7zTZukHYjmxXyaqMMz6a7Jd+n1+\n\thL96Zw8fUbB228PLzoXkJtA2Ew==", "X-Google-Smtp-Source": "AOwi7QCeaV39ApqN5/uDadByIfJoBIZO0h6zwAzrkO/+0n3gzWBaSZaviVqrhFHp4NCVNd2vhdy7hQ==", "X-Received": "by 10.98.25.193 with SMTP id 184mr3405549pfz.24.1505940375733;\n\tWed, 20 Sep 2017 13:46:15 -0700 (PDT)", "From": "Kees Cook <keescook@chromium.org>", "To": "linux-kernel@vger.kernel.org", "Cc": "Kees Cook <keescook@chromium.org>, David Windsor <dave@nullcore.net>,\n\tVlad Yasevich <vyasevich@gmail.com>, Neil Horman <nhorman@tuxdriver.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tlinux-sctp@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org, linux-mm@kvack.org,\n\tkernel-hardening@lists.openwall.com", "Subject": "[PATCH v3 22/31] sctp: Copy struct sctp_sock.autoclose to userspace\n\tusing put_user()", "Date": "Wed, 20 Sep 2017 13:45:28 -0700", "Message-Id": "<1505940337-79069-23-git-send-email-keescook@chromium.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1505940337-79069-1-git-send-email-keescook@chromium.org>", "References": "<1505940337-79069-1-git-send-email-keescook@chromium.org>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: David Windsor <dave@nullcore.net>\n\nThe autoclose field can be copied with put_user(), so there is no need to\nuse copy_to_user(). In both cases, hardened usercopy is being bypassed\nsince the size is constant, and not open to runtime manipulation.\n\nThis patch is verbatim from Brad Spengler/PaX Team's PAX_USERCOPY\nwhitelisting code in the last public patch of grsecurity/PaX based on my\nunderstanding of the code. Changes or omissions from the original code are\nmine and don't reflect the original grsecurity/PaX code.\n\nSigned-off-by: David Windsor <dave@nullcore.net>\n[kees: adjust commit log]\nCc: Vlad Yasevich <vyasevich@gmail.com>\nCc: Neil Horman <nhorman@tuxdriver.com>\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: linux-sctp@vger.kernel.org\nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook <keescook@chromium.org>\n---\n net/sctp/socket.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/net/sctp/socket.c b/net/sctp/socket.c\nindex aa4f86d64545..e070c0934638 100644\n--- a/net/sctp/socket.c\n+++ b/net/sctp/socket.c\n@@ -4893,7 +4893,7 @@ static int sctp_getsockopt_autoclose(struct sock *sk, int len, char __user *optv\n \tlen = sizeof(int);\n \tif (put_user(len, optlen))\n \t\treturn -EFAULT;\n-\tif (copy_to_user(optval, &sctp_sk(sk)->autoclose, sizeof(int)))\n+\tif (put_user(sctp_sk(sk)->autoclose, (int __user *)optval))\n \t\treturn -EFAULT;\n \treturn 0;\n }\n", "prefixes": [ "v3", "22/31" ] }