Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816203/?format=api
{ "id": 816203, "url": "http://patchwork.ozlabs.org/api/patches/816203/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505913181-82547-9-git-send-email-bhanuprakash.bodireddy@intel.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505913181-82547-9-git-send-email-bhanuprakash.bodireddy@intel.com>", "list_archive_url": null, "date": "2017-09-20T13:12:57", "name": "[ovs-dev,v2,08/12] netdev-dpdk: Cleanup dpdk_do_tx_copy.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "10700e23735a7775b67717d2f50b336a4db2bc4e", "submitter": { "id": 68557, "url": "http://patchwork.ozlabs.org/api/people/68557/?format=api", "name": "Bodireddy, Bhanuprakash", "email": "bhanuprakash.bodireddy@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505913181-82547-9-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/", "series": [ { "id": 4111, "url": "http://patchwork.ozlabs.org/api/series/4111/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=4111", "date": "2017-09-20T13:12:49", "name": "Use packet batch macro and APIs.", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/4111/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816203/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy0tl4cDNz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 23:28:31 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 8E9A4B47;\n\tWed, 20 Sep 2017 13:22:51 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5C5B1AB2\n\tfor <dev@openvswitch.org>; Wed, 20 Sep 2017 13:22:44 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 14DA43FD\n\tfor <dev@openvswitch.org>; Wed, 20 Sep 2017 13:22:44 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Sep 2017 06:22:43 -0700", "from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby fmsmga004.fm.intel.com with ESMTP; 20 Sep 2017 06:22:43 -0700" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,421,1500966000\"; d=\"scan'208\";a=\"314221712\"", "From": "Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>", "To": "dev@openvswitch.org", "Date": "Wed, 20 Sep 2017 14:12:57 +0100", "Message-Id": "<1505913181-82547-9-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "References": "<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Spam-Status": "No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH v2 08/12] netdev-dpdk: Cleanup dpdk_do_tx_copy.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "Cleanup dpdk_do_tx_copy().\n\nSigned-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>\n---\n lib/netdev-dpdk.c | 22 ++++++++++------------\n 1 file changed, 10 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex 60ec528..60887e5 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -1835,22 +1835,23 @@ static void\n dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch)\n OVS_NO_THREAD_SAFETY_ANALYSIS\n {\n+ const size_t batch_cnt = dp_packet_batch_size(batch);\n #if !defined(__CHECKER__) && !defined(_WIN32)\n- const size_t PKT_ARRAY_SIZE = batch->count;\n+ const size_t PKT_ARRAY_SIZE = batch_cnt;\n #else\n /* Sparse or MSVC doesn't like variable length array. */\n enum { PKT_ARRAY_SIZE = NETDEV_MAX_BURST };\n #endif\n struct netdev_dpdk *dev = netdev_dpdk_cast(netdev);\n struct rte_mbuf *pkts[PKT_ARRAY_SIZE];\n- uint32_t cnt = batch->count;\n+ uint32_t cnt = batch_cnt;\n uint32_t dropped = 0;\n \n if (dev->type != DPDK_DEV_VHOST) {\n /* Check if QoS has been configured for this netdev. */\n cnt = netdev_dpdk_qos_run(dev, (struct rte_mbuf **) batch->packets,\n- cnt, false);\n- dropped += batch->count - cnt;\n+ batch_cnt, false);\n+ dropped += batch_cnt - cnt;\n }\n \n dp_packet_batch_apply_cutlen(batch);\n@@ -1858,8 +1859,8 @@ dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch)\n uint32_t txcnt = 0;\n \n for (uint32_t i = 0; i < cnt; i++) {\n-\n- uint32_t size = dp_packet_size(batch->packets[i]);\n+ struct dp_packet *packet = batch->packets[i];\n+ uint32_t size = dp_packet_size(packet);\n \n if (OVS_UNLIKELY(size > dev->max_packet_len)) {\n VLOG_WARN_RL(&rl, \"Too big size %u max_packet_len %d\",\n@@ -1870,18 +1871,15 @@ dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch)\n }\n \n pkts[txcnt] = rte_pktmbuf_alloc(dev->dpdk_mp->mp);\n-\n- if (!pkts[txcnt]) {\n+ if (OVS_UNLIKELY(!pkts[txcnt])) {\n dropped += cnt - i;\n break;\n }\n \n /* We have to do a copy for now */\n memcpy(rte_pktmbuf_mtod(pkts[txcnt], void *),\n- dp_packet_data(batch->packets[i]), size);\n-\n- rte_pktmbuf_data_len(pkts[txcnt]) = size;\n- rte_pktmbuf_pkt_len(pkts[txcnt]) = size;\n+ dp_packet_data(packet), size);\n+ dp_packet_set_size((struct dp_packet *)pkts[txcnt], size);\n \n txcnt++;\n }\n", "prefixes": [ "ovs-dev", "v2", "08/12" ] }