Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/816200/?format=api
{ "id": 816200, "url": "http://patchwork.ozlabs.org/api/patches/816200/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505913181-82547-8-git-send-email-bhanuprakash.bodireddy@intel.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505913181-82547-8-git-send-email-bhanuprakash.bodireddy@intel.com>", "list_archive_url": null, "date": "2017-09-20T13:12:56", "name": "[ovs-dev,v2,07/12] netdev-linux: Clean up netdev_linux_sock_batch_send().", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce9e773d63c9aaca727ce111ffc373e392ef3708", "submitter": { "id": 68557, "url": "http://patchwork.ozlabs.org/api/people/68557/?format=api", "name": "Bodireddy, Bhanuprakash", "email": "bhanuprakash.bodireddy@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505913181-82547-8-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/", "series": [ { "id": 4111, "url": "http://patchwork.ozlabs.org/api/series/4111/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=4111", "date": "2017-09-20T13:12:49", "name": "Use packet batch macro and APIs.", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/4111/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/816200/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/816200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy0st53wcz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 23:27:46 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 66B7AAF7;\n\tWed, 20 Sep 2017 13:22:50 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id B521EAB2\n\tfor <dev@openvswitch.org>; Wed, 20 Sep 2017 13:22:43 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 727A53FD\n\tfor <dev@openvswitch.org>; Wed, 20 Sep 2017 13:22:43 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Sep 2017 06:22:43 -0700", "from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby fmsmga004.fm.intel.com with ESMTP; 20 Sep 2017 06:22:42 -0700" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,421,1500966000\"; d=\"scan'208\";a=\"314221709\"", "From": "Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>", "To": "dev@openvswitch.org", "Date": "Wed, 20 Sep 2017 14:12:56 +0100", "Message-Id": "<1505913181-82547-8-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "References": "<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Spam-Status": "No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH v2 07/12] netdev-linux: Clean up\n\tnetdev_linux_sock_batch_send().", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "Use DP_PACKET_BATCH_FOR_EACH macro and dp_packet_batch_size() API\nin netdev_linux_sock_batch_send().\n\nSigned-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>\n---\n lib/netdev-linux.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c\nindex 6769819..440598b 100644\n--- a/lib/netdev-linux.c\n+++ b/lib/netdev-linux.c\n@@ -1186,16 +1186,17 @@ static int\n netdev_linux_sock_batch_send(int sock, int ifindex,\n struct dp_packet_batch *batch)\n {\n+ const size_t size = dp_packet_batch_size(batch);\n /* We don't bother setting most fields in sockaddr_ll because the\n * kernel ignores them for SOCK_RAW. */\n struct sockaddr_ll sll = { .sll_family = AF_PACKET,\n .sll_ifindex = ifindex };\n \n- struct mmsghdr *mmsg = xmalloc(sizeof(*mmsg) * batch->count);\n- struct iovec *iov = xmalloc(sizeof(*iov) * batch->count);\n+ struct mmsghdr *mmsg = xmalloc(sizeof(*mmsg) * size);\n+ struct iovec *iov = xmalloc(sizeof(*iov) * size);\n \n- for (int i = 0; i < batch->count; i++) {\n- struct dp_packet *packet = batch->packets[i];\n+ struct dp_packet *packet;\n+ DP_PACKET_BATCH_FOR_EACH (packet, batch) {\n iov[i].iov_base = dp_packet_data(packet);\n iov[i].iov_len = dp_packet_get_send_len(packet);\n mmsg[i].msg_hdr = (struct msghdr) { .msg_name = &sll,\n@@ -1205,10 +1206,10 @@ netdev_linux_sock_batch_send(int sock, int ifindex,\n }\n \n int error = 0;\n- for (uint32_t ofs = 0; ofs < batch->count; ) {\n+ for (uint32_t ofs = 0; ofs < size; ) {\n ssize_t retval;\n do {\n- retval = sendmmsg(sock, mmsg + ofs, batch->count - ofs, 0);\n+ retval = sendmmsg(sock, mmsg + ofs, size - ofs, 0);\n error = retval < 0 ? errno : 0;\n } while (error == EINTR);\n if (error) {\n", "prefixes": [ "ovs-dev", "v2", "07/12" ] }