Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815912/?format=api
{ "id": 815912, "url": "http://patchwork.ozlabs.org/api/patches/815912/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-35-blp@ovn.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919220125.32535-35-blp@ovn.org>", "list_archive_url": null, "date": "2017-09-19T22:01:07", "name": "[ovs-dev,RFC,34/52] ovsdb-idl: Remove 'uuid' member of struct ovsdb_idl.", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "5982cf962b96643c2e099652f9ae62c8796719d4", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-35-blp@ovn.org/mbox/", "series": [ { "id": 3975, "url": "http://patchwork.ozlabs.org/api/series/3975/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975", "date": "2017-09-19T22:00:34", "name": "clustering implementation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3975/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815912/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815912/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxd1c6gxjz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 08:33:08 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id D9241DC0;\n\tTue, 19 Sep 2017 22:21:44 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5B907DBC\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:21:43 +0000 (UTC)", "from slow1-d.mail.gandi.net (slow1-d.mail.gandi.net\n\t[217.70.178.86])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTP id 52231159\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:21:42 +0000 (UTC)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby slow1-d.mail.gandi.net (Postfix) with ESMTP id B34D5534ED6\n\tfor <dev@openvswitch.org>; Wed, 20 Sep 2017 00:02:26 +0200 (CEST)", "from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1B5A2172094;\n\tWed, 20 Sep 2017 00:02:24 +0200 (CEST)" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-Originating-IP": "208.91.2.3", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 19 Sep 2017 15:01:07 -0700", "Message-Id": "<20170919220125.32535-35-blp@ovn.org>", "X-Mailer": "git-send-email 2.10.2", "In-Reply-To": "<20170919220125.32535-1-blp@ovn.org>", "References": "<20170919220125.32535-1-blp@ovn.org>", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Cc": "Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH RFC 34/52] ovsdb-idl: Remove 'uuid' member of\n\tstruct ovsdb_idl.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "This was used to uniquely identify the monitor, but there's no need for\nthat. A fixed monitor name works fine.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n lib/ovsdb-idl.c | 20 ++++----------------\n 1 file changed, 4 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c\nindex 79912b649056..895abc283d96 100644\n--- a/lib/ovsdb-idl.c\n+++ b/lib/ovsdb-idl.c\n@@ -120,7 +120,6 @@ enum ovsdb_idl_state {\n struct ovsdb_idl {\n const struct ovsdb_idl_class *class_;\n struct jsonrpc_session *session;\n- struct uuid uuid;\n struct shash table_by_name; /* Contains \"struct ovsdb_idl_table *\"s.*/\n struct ovsdb_idl_table *tables; /* Array of ->class_->n_tables elements. */\n unsigned int change_seqno;\n@@ -338,7 +337,6 @@ ovsdb_idl_create(const char *remote, const struct ovsdb_idl_class *class,\n idl->schema = NULL;\n \n hmap_init(&idl->outstanding_txns);\n- uuid_generate(&idl->uuid);\n \n return idl;\n }\n@@ -1206,8 +1204,7 @@ static void\n ovsdb_idl_send_cond_change(struct ovsdb_idl *idl)\n {\n int i;\n- char uuid[UUID_LEN + 1];\n- struct json *params, *json_uuid;\n+ struct json *params;\n struct jsonrpc_msg *request;\n \n /* When 'idl-request_id' is not NULL, there is an outstanding\n@@ -1239,15 +1236,8 @@ ovsdb_idl_send_cond_change(struct ovsdb_idl *idl)\n \n /* Send request if not empty. */\n if (monitor_cond_change_requests) {\n- snprintf(uuid, sizeof uuid, UUID_FMT,\n- UUID_ARGS(&idl->uuid));\n- json_uuid = json_string_create(uuid);\n-\n- /* Create a new uuid */\n- uuid_generate(&idl->uuid);\n- snprintf(uuid, sizeof uuid, UUID_FMT,\n- UUID_ARGS(&idl->uuid));\n- params = json_array_create_3(json_uuid, json_string_create(uuid),\n+ params = json_array_create_3(json_string_create(\"monid\"),\n+ json_string_create(\"monid\"),\n monitor_cond_change_requests);\n \n request = jsonrpc_create_request(\"monitor_cond_change\", params,\n@@ -1547,7 +1537,6 @@ ovsdb_idl_send_monitor_request__(struct ovsdb_idl *idl,\n struct shash *schema;\n struct json *monitor_requests;\n struct jsonrpc_msg *msg;\n- char uuid[UUID_LEN + 1];\n size_t i;\n \n schema = parse_schema(idl->schema);\n@@ -1606,11 +1595,10 @@ ovsdb_idl_send_monitor_request__(struct ovsdb_idl *idl,\n \n json_destroy(idl->request_id);\n \n- snprintf(uuid, sizeof uuid, UUID_FMT, UUID_ARGS(&idl->uuid));\n msg = jsonrpc_create_request(\n method,\n json_array_create_3(json_string_create(idl->class_->database),\n- json_string_create(uuid), monitor_requests),\n+ json_string_create(\"monid\"), monitor_requests),\n &idl->request_id);\n jsonrpc_session_send(idl->session, msg);\n idl->cond_changed = false;\n", "prefixes": [ "ovs-dev", "RFC", "34/52" ] }