Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815893/?format=api
{ "id": 815893, "url": "http://patchwork.ozlabs.org/api/patches/815893/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-41-blp@ovn.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919220125.32535-41-blp@ovn.org>", "list_archive_url": null, "date": "2017-09-19T22:01:13", "name": "[ovs-dev,RFC,40/52] tests: Always ignore \"Broken pipe\" and \"Connection reset\" log messages.", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "294da49b7cfeae570e0272472527fadc953384e8", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-41-blp@ovn.org/mbox/", "series": [ { "id": 3975, "url": "http://patchwork.ozlabs.org/api/series/3975/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975", "date": "2017-09-19T22:00:34", "name": "clustering implementation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3975/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815893/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815893/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxck06hc2z9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 08:19:36 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id C46B6D01;\n\tTue, 19 Sep 2017 22:02:41 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id C3882CF7\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:02:39 +0000 (UTC)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 4171E159\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:02:39 +0000 (UTC)", "from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 0FDA7172098;\n\tWed, 20 Sep 2017 00:02:36 +0200 (CEST)" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Originating-IP": "208.91.2.3", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 19 Sep 2017 15:01:13 -0700", "Message-Id": "<20170919220125.32535-41-blp@ovn.org>", "X-Mailer": "git-send-email 2.10.2", "In-Reply-To": "<20170919220125.32535-1-blp@ovn.org>", "References": "<20170919220125.32535-1-blp@ovn.org>", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Cc": "Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH RFC 40/52] tests: Always ignore \"Broken pipe\" and\n\t\"Connection reset\" log messages.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "Until now, the ovn-controller-vtep, ovn-nbctl, and ovn-sbctl tests have\nignored \"Broken pipe\" and \"Connection reset\" messages. The same rationale\nthat applies to them also applies to ovs-vsctl and other utilities. It\nseems easier to just always ignore them.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n tests/ofproto-macros.at | 12 ++++++++++++\n tests/ovn-controller-vtep.at | 14 +-------------\n tests/ovn-nbctl.at | 14 +-------------\n tests/ovn-sbctl.at | 14 +-------------\n 4 files changed, 15 insertions(+), 39 deletions(-)", "diff": "diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at\nindex 17f85e703ccf..dd5763e87f49 100644\n--- a/tests/ofproto-macros.at\n+++ b/tests/ofproto-macros.at\n@@ -381,7 +381,19 @@ check_logs () {\n esac\n done\n \n+ # We most notably ignore 'Broken pipe' warnings. These often and\n+ # intermittently appear in ovsdb-server.log, because *ctl commands\n+ # (e.g. ovs-vsctl, ovn-nbctl) exit right after committing a change to the\n+ # database. However, in reaction, some daemon may immediately update the\n+ # database, and this later update may cause database sending update back to\n+ # *ctl command if *ctl has not exited yet. If *ctl command exits before\n+ # the database calls send, the send fails with 'Broken pipe'. Also removes\n+ # all \"connection reset\" warning logs for similar reasons (either EPIPE or\n+ # ECONNRESET can be returned on a send depending on whether the peer had\n+ # unconsumed data when it closed the socket).\n sed -n \"$1\n+/reset by peer/d\n+/Broken pipe/d\n /timeval.*Unreasonably long [[0-9]]*ms poll interval/d\n /timeval.*faults: [[0-9]]* minor, [[0-9]]* major/d\n /timeval.*disk: [[0-9]]* reads, [[0-9]]* writes/d\ndiff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at\nindex 9b9e42115678..f61c3efad592 100644\n--- a/tests/ovn-controller-vtep.at\n+++ b/tests/ovn-controller-vtep.at\n@@ -80,19 +80,7 @@ m4_define([OVN_CONTROLLER_VTEP_START],\n # So many exits... Yeah, we started a lot daemons~\n #\n m4_define([OVN_CONTROLLER_VTEP_STOP],\n- [# removes all 'Broken pipe' warning logs from ovsdb-server.log. this is in\n- # that *ctl command (e.g. ovn-nbctl) exits right after committing the change\n- # to database. however, in reaction, some daemon (e.g. ovn-controller-vtep)\n- # may immediately update the database. this later update may cause database\n- # sending update back to *ctl command if *ctl has not proceeded to exit yet.\n- # and if *ctl command exits before database calling send, the send from\n- # database will fail with 'Broken pipe' error. Also removes all \"connection\n- # reset\" warning logs by a similar rationale (either EPIPE or ECONNRESET can\n- # be returned on a send depending on whether the peer had unconsumed data when\n- # it closed the socket).\n- AT_CHECK([check_logs \"$1\n-/reset by peer/d\n-/Broken pipe/d\"])\n+ [AT_CHECK([check_logs \"$1\"])\n OVS_APP_EXIT_AND_WAIT([ovs-vtep])\n OVS_APP_EXIT_AND_WAIT([ovn-northd])\n OVS_APP_EXIT_AND_WAIT([ovn-controller-vtep])\ndiff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at\nindex 354b8df96d01..5346a123d3c4 100644\n--- a/tests/ovn-nbctl.at\n+++ b/tests/ovn-nbctl.at\n@@ -18,19 +18,7 @@ m4_define([OVN_NBCTL_TEST_START],\n \n # OVN_NBCTL_TEST_STOP\n m4_define([OVN_NBCTL_TEST_STOP],\n- [# removes all 'Broken pipe' warning logs from ovsdb-server.log. this is in\n- # that *ctl command (e.g. ovn-nbctl) exits right after committing the change\n- # to database. however, in reaction, some daemon (e.g. ovn-controller-vtep)\n- # may immediately update the database. this later update may cause database\n- # sending update back to *ctl command if *ctl has not proceeded to exit yet.\n- # and if *ctl command exits before database calling send, the send from\n- # database will fail with 'Broken pipe' error. Also removes all \"connection\n- # reset\" warning logs by a similar rationale (either EPIPE or ECONNRESET can\n- # be returned on a send depending on whether the peer had unconsumed data when\n- # it closed the socket).\n- AT_CHECK([check_logs \"$1\n-/reset by peer/d\n-/Broken pipe/d\"])\n+ [AT_CHECK([check_logs \"$1\"])\n OVS_APP_EXIT_AND_WAIT([ovsdb-server])])\n \n \ndiff --git a/tests/ovn-sbctl.at b/tests/ovn-sbctl.at\nindex 9374b5fef214..ee2face769f4 100644\n--- a/tests/ovn-sbctl.at\n+++ b/tests/ovn-sbctl.at\n@@ -27,19 +27,7 @@ m4_define([OVN_SBCTL_TEST_START],\n \n # OVN_SBCTL_TEST_STOP\n m4_define([OVN_SBCTL_TEST_STOP],\n- [# removes all 'Broken pipe' warning logs from ovsdb-server.log. this is in\n- # that *ctl command (e.g. ovn-nbctl) exits right after committing the change\n- # to database. however, in reaction, some daemon (e.g. ovn-controller-vtep)\n- # may immediately update the database. this later update may cause database\n- # sending update back to *ctl command if *ctl has not proceeded to exit yet.\n- # and if *ctl command exits before database calling send, the send from\n- # database will fail with 'Broken pipe' error. Also removes all \"connection\n- # reset\" warning logs by a similar rationale (either EPIPE or ECONNRESET can\n- # be returned on a send depending on whether the peer had unconsumed data when\n- # it closed the socket).\n- AT_CHECK([check_logs \"$1\n-/reset by peer/d\n-/Broken pipe/d\"])\n+ [AT_CHECK([check_logs \"$1\"])\n OVS_APP_EXIT_AND_WAIT([ovn-northd])\n OVS_APP_EXIT_AND_WAIT_BY_TARGET([$OVS_RUNDIR/ovnnb_db.ctl], [$OVS_RUNDIR/ovnnb_db.pid])\n OVS_APP_EXIT_AND_WAIT_BY_TARGET([$OVS_RUNDIR/ovnsb_db.ctl], [$OVS_RUNDIR/ovnsb_db.pid])])\n", "prefixes": [ "ovs-dev", "RFC", "40/52" ] }