Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815888/?format=api
{ "id": 815888, "url": "http://patchwork.ozlabs.org/api/patches/815888/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-22-blp@ovn.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919220125.32535-22-blp@ovn.org>", "list_archive_url": null, "date": "2017-09-19T22:00:54", "name": "[ovs-dev,RFC,21/52] stream-unix: Give accepted sockets distinct names for log messages.", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "29dca12b098a6a4dc33ba9d9350648c07dea20c2", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-22-blp@ovn.org/mbox/", "series": [ { "id": 3975, "url": "http://patchwork.ozlabs.org/api/series/3975/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975", "date": "2017-09-19T22:00:34", "name": "clustering implementation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3975/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815888/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815888/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxcdw5m8Fz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 08:16:04 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 5E641CDA;\n\tTue, 19 Sep 2017 22:02:12 +0000 (UTC)", "from smtp2.linuxfoundation.org (smtp2.linux-foundation.org\n\t[172.17.192.36])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 8FAE4CBE\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:02:07 +0000 (UTC)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp2.linuxfoundation.org (Postfix) with ESMTPS id 192A11DCE2\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:02:07 +0000 (UTC)", "from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id DA2AF172094;\n\tWed, 20 Sep 2017 00:02:04 +0200 (CEST)" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Originating-IP": "208.91.2.3", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 19 Sep 2017 15:00:54 -0700", "Message-Id": "<20170919220125.32535-22-blp@ovn.org>", "X-Mailer": "git-send-email 2.10.2", "In-Reply-To": "<20170919220125.32535-1-blp@ovn.org>", "References": "<20170919220125.32535-1-blp@ovn.org>", "X-Spam-Status": "No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW\n\tautolearn=ham version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp2.linux-foundation.org", "Cc": "Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH RFC 21/52] stream-unix: Give accepted sockets\n\tdistinct names for log messages.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "At least on Linux, when process A connects to process B over a Unix\ndomain socket, unless process A bound its socket to a name before\nit made the connection, process B gets an empty peer name. Until\nnow, OVS has just reported the name of the connection as \"unix\".\nThis is not meaningful, of course. I do not know of a good general\nsolution to this problem, but this commit attempts a step in the\nright direction by at least giving each connection of this kind a\nnumber: \"unix#1\", \"unix#2\", and so on. That way, in log messages\none can at least see which messages are related to a particular\nconnection.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n lib/stream-unix.c | 15 ++++++++++++---\n tests/ofproto-macros.at | 1 +\n tests/ofproto.at | 2 +-\n 3 files changed, 14 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/stream-unix.c b/lib/stream-unix.c\nindex 40ded19526f2..9261958fce35 100644\n--- a/lib/stream-unix.c\n+++ b/lib/stream-unix.c\n@@ -26,6 +26,7 @@\n #include <stdlib.h>\n #include <string.h>\n #include <unistd.h>\n+#include \"ovs-atomic.h\"\n #include \"packets.h\"\n #include \"poll-loop.h\"\n #include \"socket-util.h\"\n@@ -112,9 +113,17 @@ punix_accept(int fd, const struct sockaddr_storage *ss, size_t ss_len,\n {\n const struct sockaddr_un *sun = (const struct sockaddr_un *) ss;\n int name_len = get_unix_name_len(sun, ss_len);\n- char *bound_name = (name_len > 0\n- ? xasprintf(\"unix:%.*s\", name_len, sun->sun_path)\n- : xstrdup(\"unix\"));\n+ char *bound_name;\n+\n+ if (name_len > 0) {\n+ bound_name = xasprintf(\"unix:%.*s\", name_len, sun->sun_path);\n+ } else {\n+ /* When a Unix socket connects to us without first binding a name, we\n+ * don't get any name for it. It's useful nevertheless to be able to\n+ * distinguish separate sockets in log messages, so use a counter. */\n+ static atomic_count next_idx = ATOMIC_COUNT_INIT(0);\n+ bound_name = xasprintf(\"unix#%u\", atomic_count_inc(&next_idx));\n+ }\n return new_fd_stream(bound_name, fd, 0, AF_UNIX, streamp);\n }\n \ndiff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at\nindex 38449db32ee0..17f85e703ccf 100644\n--- a/tests/ofproto-macros.at\n+++ b/tests/ofproto-macros.at\n@@ -32,6 +32,7 @@ prt==1 { sub(/[ \\t]*$/, \"\"); print $0 }\n vconn_sub() {\n sed '\n s/tcp:127.0.0.1:[0-9][0-9]*:/unix:/\n+s/unix#[0-9]:/unix:/\n '\n }\n ]\ndiff --git a/tests/ofproto.at b/tests/ofproto.at\nindex 31cb5208fc1c..b8daa1018fd6 100644\n--- a/tests/ofproto.at\n+++ b/tests/ofproto.at\n@@ -5217,7 +5217,7 @@ vconn|DBG|unix: sent (Success): NXST_FLOW reply:\n in_port=2,dl_src=00:66:77:88:99:aa actions=drop\n ])\n \n-AT_CHECK([grep \" flow_mods in the last \" ovs-vswitchd.log | sed -e 's/^.*connmgr|INFO|//'], [0], [dnl\n+AT_CHECK([grep \" flow_mods in the last \" ovs-vswitchd.log | sed -e 's/^.*connmgr|INFO|//' | vconn_sub], [0], [dnl\n br0<->unix: 1 flow_mods in the last 0 s (1 deletes)\n br0<->unix: 9 flow_mods in the last 0 s (7 adds, 2 deletes)\n br0<->unix: 2 flow_mods in the last 0 s (2 modifications)\n", "prefixes": [ "ovs-dev", "RFC", "21/52" ] }