Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815887/?format=api
{ "id": 815887, "url": "http://patchwork.ozlabs.org/api/patches/815887/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-21-blp@ovn.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919220125.32535-21-blp@ovn.org>", "list_archive_url": null, "date": "2017-09-19T22:00:53", "name": "[ovs-dev,RFC,20/52] ovsdb-server: Drop 'txn' member from struct db.", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "b0b08e9fd60398253453eb7aacab7a65d7f4b6ca", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-21-blp@ovn.org/mbox/", "series": [ { "id": 3975, "url": "http://patchwork.ozlabs.org/api/series/3975/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975", "date": "2017-09-19T22:00:34", "name": "clustering implementation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3975/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815887/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815887/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxcdM4bjWz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 08:15:35 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 7C5EDCD6;\n\tTue, 19 Sep 2017 22:02:11 +0000 (UTC)", "from smtp2.linuxfoundation.org (smtp2.linux-foundation.org\n\t[172.17.192.36])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 3C7F8CCB\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:02:06 +0000 (UTC)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp2.linuxfoundation.org (Postfix) with ESMTPS id C140C1DC96\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:02:05 +0000 (UTC)", "from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 77D0917209D;\n\tWed, 20 Sep 2017 00:02:03 +0200 (CEST)" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Originating-IP": "208.91.2.3", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 19 Sep 2017 15:00:53 -0700", "Message-Id": "<20170919220125.32535-21-blp@ovn.org>", "X-Mailer": "git-send-email 2.10.2", "In-Reply-To": "<20170919220125.32535-1-blp@ovn.org>", "References": "<20170919220125.32535-1-blp@ovn.org>", "X-Spam-Status": "No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW\n\tautolearn=ham version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp2.linux-foundation.org", "Cc": "Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH RFC 20/52] ovsdb-server: Drop 'txn' member from\n\tstruct db.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "This member was only used in one particular code path, so this commit\nadds code to pass it around as a function parameter instead.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n ovsdb/ovsdb-server.c | 40 ++++++++++++++++------------------------\n 1 file changed, 16 insertions(+), 24 deletions(-)", "diff": "diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c\nindex 28f258a4ff70..eecd84607408 100644\n--- a/ovsdb/ovsdb-server.c\n+++ b/ovsdb/ovsdb-server.c\n@@ -62,13 +62,9 @@\n VLOG_DEFINE_THIS_MODULE(ovsdb_server);\n \n struct db {\n- /* Initialized in main(). */\n char *filename;\n struct ovsdb_file *file;\n struct ovsdb *db;\n-\n- /* Only used by update_remote_status(). */\n- struct ovsdb_txn *txn;\n };\n \n /* SSL configuration. */\n@@ -833,9 +829,10 @@ update_remote_row(const struct ovsdb_row *row, struct ovsdb_txn *txn,\n }\n \n static void\n-update_remote_rows(const struct shash *all_dbs,\n+update_remote_rows(const struct shash *all_dbs, const struct db *db_,\n const char *remote_name,\n- const struct ovsdb_jsonrpc_server *jsonrpc)\n+ const struct ovsdb_jsonrpc_server *jsonrpc,\n+ struct ovsdb_txn *txn)\n {\n const struct ovsdb_table *table, *ref_table;\n const struct ovsdb_column *column;\n@@ -853,7 +850,8 @@ update_remote_rows(const struct shash *all_dbs,\n return;\n }\n \n- if (column->type.key.type != OVSDB_TYPE_UUID\n+ if (db != db_\n+ || column->type.key.type != OVSDB_TYPE_UUID\n || !column->type.key.u.uuid.refTable\n || column->type.value.type != OVSDB_TYPE_VOID) {\n return;\n@@ -871,7 +869,7 @@ update_remote_rows(const struct shash *all_dbs,\n \n ref_row = ovsdb_table_get_row(ref_table, &datum->keys[i].uuid);\n if (ref_row) {\n- update_remote_row(ref_row, db->txn, jsonrpc);\n+ update_remote_row(ref_row, txn, jsonrpc);\n }\n }\n }\n@@ -882,26 +880,20 @@ update_remote_status(const struct ovsdb_jsonrpc_server *jsonrpc,\n const struct sset *remotes,\n struct shash *all_dbs)\n {\n- static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);\n- const char *remote;\n- struct db *db;\n struct shash_node *node;\n+ SHASH_FOR_EACH (node, all_dbs) {\n+ struct db *db = node->data;\n+ struct ovsdb_txn *txn = ovsdb_txn_create(db->db);\n \n- SHASH_FOR_EACH(node, all_dbs) {\n- db = node->data;\n- db->txn = ovsdb_txn_create(db->db);\n- }\n-\n- /* Iterate over --remote arguments given on command line. */\n- SSET_FOR_EACH (remote, remotes) {\n- update_remote_rows(all_dbs, remote, jsonrpc);\n- }\n+ /* Iterate over --remote arguments given on command line. */\n+ const char *remote;\n+ SSET_FOR_EACH (remote, remotes) {\n+ update_remote_rows(all_dbs, db, remote, jsonrpc, txn);\n+ }\n \n- SHASH_FOR_EACH(node, all_dbs) {\n- struct ovsdb_error *error;\n- db = node->data;\n- error = ovsdb_txn_commit(db->txn, false);\n+ struct ovsdb_error *error = ovsdb_txn_commit(txn, false);\n if (error) {\n+ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);\n char *msg = ovsdb_error_to_string_free(error);\n VLOG_ERR_RL(&rl, \"Failed to update remote status: %s\", msg);\n free(msg);\n", "prefixes": [ "ovs-dev", "RFC", "20/52" ] }