Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815871/?format=api
{ "id": 815871, "url": "http://patchwork.ozlabs.org/api/patches/815871/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-6-blp@ovn.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919220125.32535-6-blp@ovn.org>", "list_archive_url": null, "date": "2017-09-19T22:00:38", "name": "[ovs-dev,RFC,05/52] ofp-print: Avoid trailing white space in OpenFlow dumps.", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "3bfe7459b29164da420a561ed92fce6f2270de1c", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-6-blp@ovn.org/mbox/", "series": [ { "id": 3975, "url": "http://patchwork.ozlabs.org/api/series/3975/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975", "date": "2017-09-19T22:00:34", "name": "clustering implementation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3975/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815871/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815871/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxcP33MgYz9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 08:04:55 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 450E7C17;\n\tTue, 19 Sep 2017 22:01:46 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 12CDCBFF\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:01:42 +0000 (UTC)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 98B63159\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 22:01:41 +0000 (UTC)", "from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 7B6AF172097;\n\tWed, 20 Sep 2017 00:01:39 +0200 (CEST)" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Originating-IP": "208.91.2.3", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 19 Sep 2017 15:00:38 -0700", "Message-Id": "<20170919220125.32535-6-blp@ovn.org>", "X-Mailer": "git-send-email 2.10.2", "In-Reply-To": "<20170919220125.32535-1-blp@ovn.org>", "References": "<20170919220125.32535-1-blp@ovn.org>", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Cc": "Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH RFC 05/52] ofp-print: Avoid trailing white space\n\tin OpenFlow dumps.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "ofp_to_string() sometimes yields a trailing space in its output. This is\nannoying for the test infrastructure, since we have to specially mark the\ntrailing white space in Autotest with a \"@&t@\" marker at the end of the\nline. This commit gets rid of the trailing white space and the annoying\n\"@&t@\" markers.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n lib/ofp-print.c | 1 +\n tests/ofp-print.at | 16 ++++++++--------\n 2 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/ofp-print.c b/lib/ofp-print.c\nindex f77b31baf0b4..151d618b59e8 100644\n--- a/lib/ofp-print.c\n+++ b/lib/ofp-print.c\n@@ -3791,6 +3791,7 @@ ofp_to_string(const void *oh_, size_t len,\n error = ofpraw_decode(&raw, oh);\n if (!error) {\n ofp_to_string__(oh, port_map, raw, &string, verbosity);\n+ ds_chomp(&string, ' ');\n if (verbosity >= 5) {\n if (ds_last(&string) != '\\n') {\n ds_put_char(&string, '\\n');\ndiff --git a/tests/ofp-print.at b/tests/ofp-print.at\nindex a00e3f3fe74b..50083a34d556 100644\n--- a/tests/ofp-print.at\n+++ b/tests/ofp-print.at\n@@ -1355,7 +1355,7 @@ ff fe 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 00 00 00 ff 00 ff ff \\\n \"], [0], [dnl\n-OFPST_FLOW request (xid=0x4): @&t@\n+OFPST_FLOW request (xid=0x4):\n ])\n AT_CLEANUP\n \n@@ -1367,7 +1367,7 @@ ff 00 00 00 ff ff ff ff ff ff ff ff 00 00 00 00 \\\n 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 01 00 04 00 00 00 00 \\\n \"], [0], [dnl\n-OFPST_FLOW request (OF1.2) (xid=0x2): @&t@\n+OFPST_FLOW request (OF1.2) (xid=0x2):\n ])\n AT_CLEANUP\n \n@@ -1379,7 +1379,7 @@ ff 00 00 00 ff ff ff ff ff ff ff ff 00 00 00 00 \\\n 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 01 00 04 00 00 00 00 \\\n \"], [0], [dnl\n-OFPST_FLOW request (OF1.3) (xid=0x2): @&t@\n+OFPST_FLOW request (OF1.3) (xid=0x2):\n ])\n AT_CLEANUP\n \n@@ -1470,7 +1470,7 @@ ff fe 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 00 00 00 ff 00 ff ff \\\n \"], [0], [dnl\n-OFPST_AGGREGATE request (xid=0x4): @&t@\n+OFPST_AGGREGATE request (xid=0x4):\n ])\n AT_CLEANUP\n \n@@ -1482,7 +1482,7 @@ ff 00 00 00 ff ff ff ff ff ff ff ff 00 00 00 00 \\\n 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 01 00 04 00 00 00 00 \\\n \"], [0], [dnl\n-OFPST_AGGREGATE request (OF1.2) (xid=0x2): @&t@\n+OFPST_AGGREGATE request (OF1.2) (xid=0x2):\n ])\n AT_CLEANUP\n \n@@ -1494,7 +1494,7 @@ ff 00 00 00 ff ff ff ff ff ff ff ff 00 00 00 00 \\\n 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 \\\n 00 01 00 04 00 00 00 00 \\\n \"], [0], [dnl\n-OFPST_AGGREGATE request (OF1.3) (xid=0x2): @&t@\n+OFPST_AGGREGATE request (OF1.3) (xid=0x2):\n ])\n AT_CLEANUP\n \n@@ -3256,7 +3256,7 @@ AT_CHECK([ovs-ofctl ofp-print \"\\\n 01 10 00 20 00 00 00 04 ff ff 00 00 00 00 23 20 \\\n 00 00 00 00 00 00 00 00 ff ff 00 00 ff 00 00 00 \\\n \"], [0], [dnl\n-NXST_FLOW request (xid=0x4): @&t@\n+NXST_FLOW request (xid=0x4):\n ])\n AT_CLEANUP\n \n@@ -3420,7 +3420,7 @@ AT_CHECK([ovs-ofctl ofp-print \"\\\n 01 10 00 20 00 00 00 04 ff ff 00 00 00 00 23 20 \\\n 00 00 00 01 00 00 00 00 ff ff 00 00 ff 00 00 00 \\\n \"], [0], [dnl\n-NXST_AGGREGATE request (xid=0x4): @&t@\n+NXST_AGGREGATE request (xid=0x4):\n ])\n AT_CLEANUP\n \n", "prefixes": [ "ovs-dev", "RFC", "05/52" ] }