Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815796/?format=api
{ "id": 815796, "url": "http://patchwork.ozlabs.org/api/patches/815796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505849344-52387-5-git-send-email-bhanuprakash.bodireddy@intel.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505849344-52387-5-git-send-email-bhanuprakash.bodireddy@intel.com>", "list_archive_url": null, "date": "2017-09-19T19:28:58", "name": "[ovs-dev,04/10] netdev-dpdk: Minor cleanup of netdev_dpdk_send__.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e011bf13fb4f06825be150a0e8fb7f78f7bdf0f1", "submitter": { "id": 68557, "url": "http://patchwork.ozlabs.org/api/people/68557/?format=api", "name": "Bodireddy, Bhanuprakash", "email": "bhanuprakash.bodireddy@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505849344-52387-5-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/", "series": [ { "id": 3956, "url": "http://patchwork.ozlabs.org/api/series/3956/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=3956", "date": "2017-09-19T19:28:54", "name": "Use DP_PACKET_BATCH_FOR_EACH macro.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3956/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815796/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxYCH2G6qz9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 05:41:15 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 95C75BE5;\n\tTue, 19 Sep 2017 19:38:49 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id B29EFBD1\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 19:38:46 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7042246F\n\tfor <dev@openvswitch.org>; Tue, 19 Sep 2017 19:38:46 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 19 Sep 2017 12:38:46 -0700", "from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby orsmga001.jf.intel.com with ESMTP; 19 Sep 2017 12:38:43 -0700" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,418,1500966000\"; d=\"scan'208\";\n\ta=\"1173892321\"", "From": "Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>", "To": "dev@openvswitch.org", "Date": "Tue, 19 Sep 2017 20:28:58 +0100", "Message-Id": "<1505849344-52387-5-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1505849344-52387-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "References": "<1505849344-52387-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Spam-Status": "No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH 04/10] netdev-dpdk: Minor cleanup of\n\tnetdev_dpdk_send__.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "The variable 'cnt' is initialized and reused in multiple function calls\ninside netdev_dpdk_send__() and is confusing sometimes. Instead introduce\n'batch_cnt' to hold the original packet count and 'tx_cnt' to store\nthe final packet count resulting after filtering and qos operations.\n\nFinally 'tx_cnt' packets gets transmitted on the respective 'qid'.\n\nSigned-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>\n---\n lib/netdev-dpdk.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex 2078c94..4e75bf1 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -1938,17 +1938,17 @@ netdev_dpdk_send__(struct netdev_dpdk *dev, int qid,\n dpdk_do_tx_copy(netdev, qid, batch);\n dp_packet_delete_batch(batch, may_steal);\n } else {\n- int dropped;\n- int cnt = batch->count;\n+ int tx_cnt, dropped;\n+ int batch_cnt = dp_packet_batch_size(batch);\n struct rte_mbuf **pkts = (struct rte_mbuf **) batch->packets;\n \n dp_packet_batch_apply_cutlen(batch);\n \n- cnt = netdev_dpdk_filter_packet_len(dev, pkts, cnt);\n- cnt = netdev_dpdk_qos_run(dev, pkts, cnt, true);\n- dropped = batch->count - cnt;\n+ tx_cnt = netdev_dpdk_filter_packet_len(dev, pkts, batch_cnt);\n+ tx_cnt = netdev_dpdk_qos_run(dev, pkts, tx_cnt, true);\n+ dropped = batch_cnt - tx_cnt;\n \n- dropped += netdev_dpdk_eth_tx_burst(dev, qid, pkts, cnt);\n+ dropped += netdev_dpdk_eth_tx_burst(dev, qid, pkts, tx_cnt);\n \n if (OVS_UNLIKELY(dropped)) {\n rte_spinlock_lock(&dev->stats_lock);\n", "prefixes": [ "ovs-dev", "04/10" ] }