Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 815751,
    "url": "http://patchwork.ozlabs.org/api/patches/815751/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170919174654.2122-5-f.fainelli@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170919174654.2122-5-f.fainelli@gmail.com>",
    "list_archive_url": null,
    "date": "2017-09-19T17:46:46",
    "name": "[net-next,v3,04/12] net: dsa: bcm_sf2: Defer port enabling to calling port_enable",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6070678fd20f09d819f4d89cbc2b16875ed3a7a6",
    "submitter": {
        "id": 2800,
        "url": "http://patchwork.ozlabs.org/api/people/2800/?format=api",
        "name": "Florian Fainelli",
        "email": "f.fainelli@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170919174654.2122-5-f.fainelli@gmail.com/mbox/",
    "series": [
        {
            "id": 3941,
            "url": "http://patchwork.ozlabs.org/api/series/3941/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3941",
            "date": "2017-09-19T17:46:42",
            "name": "net: dsa: b53/bcm_sf2 cleanups",
            "version": 3,
            "mbox": "http://patchwork.ozlabs.org/series/3941/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/815751/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/815751/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GfLHOwiV\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVgr6z90z9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 03:47:20 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751811AbdISRrR (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 19 Sep 2017 13:47:17 -0400",
            "from mail-wm0-f68.google.com ([74.125.82.68]:37316 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751365AbdISRrO (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 19 Sep 2017 13:47:14 -0400",
            "by mail-wm0-f68.google.com with SMTP id f4so304246wmh.4\n\tfor <netdev@vger.kernel.org>; Tue, 19 Sep 2017 10:47:13 -0700 (PDT)",
            "from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tq19sm11543124wrb.17.2017.09.19.10.47.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 10:47:11 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=tvrISfpzigYJ0EjxY1DQzoyWhUBwOUa/uMGHPfEJwqw=;\n\tb=GfLHOwiV1aZn9VDhBvGyzTJ/CQObjuaz32KoZbS3076+fnGXjPgmyNdfQrWaEWw5Iy\n\tXymbnNeqiV60LfVDI9XbPhcKqcJyDgGsrqmJK4Uz+F1BAWKK9jjq5o54MnmSzyl98qxf\n\t1k6ADhXKEZ6pTKTMFcT1zouIE3IJ3cKWQmKvXsqUjGFvegrCTJMde3CRcU3eYmw+SwSq\n\tmclwUoe2G220o6+vZbipPJggpo5UlbmH9nnRqxCvMWwhU85SBV/E+MF2recCjCQ8cmFK\n\t5MPTT8KMGWZpE8pDw6OEkY6nq0/P2p1Yv16M10YvzYQX7pixi2ynSPDIveVnZObSC1vI\n\tf51Q==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=tvrISfpzigYJ0EjxY1DQzoyWhUBwOUa/uMGHPfEJwqw=;\n\tb=JXSjKsCKlvCdR01JR21m3emd/z6zB0G+8vPk7NvdW1g9EMRfmM+iZRAbEbsnVXj6nR\n\tsNMDx1ZC61F4xfV0n9c5BXHvZfChvGfZncaREEaT7esWOotD8MR+pHMTtG7Jv/cWEKei\n\t+Vhvo81oETigts3Tgdc0f6FPI196DFGNdRRT2ZB5aZ+/pfJlegfG1/wwmBlUk17K9pzH\n\tMqe7f3rRybEZrTcgPnqqxxexagWQQ2c5V62vAwgqvH4SB1tZZjntd8e1LKts7ImMiW6i\n\tFi2A2sanZTrmWoFGudPzOo5VsmjxtNLiWzvQVTmrLjoECGOql1BU4gC15cw67d0PbYsp\n\tUR7g==",
        "X-Gm-Message-State": "AHPjjUiCMxxrT/+RVilyYOesMF3DeOmyXKjNtWO+mJcGVIT4mRFJcfWt\n\tvakauzq9HE+qRUxcNkYIHpym1m7b",
        "X-Google-Smtp-Source": "AOwi7QAt9aiYiFCleutbbNDkQ9sSbpytUAF2sRH7CMGHNGC0NA0JlVz0CcOVezhEPICnJvcV/oYY1A==",
        "X-Received": "by 10.28.103.195 with SMTP id b186mr1884243wmc.86.1505843232796; \n\tTue, 19 Sep 2017 10:47:12 -0700 (PDT)",
        "From": "Florian Fainelli <f.fainelli@gmail.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tFlorian Fainelli <f.fainelli@gmail.com>",
        "Subject": "[PATCH net-next v3 04/12] net: dsa: bcm_sf2: Defer port enabling to\n\tcalling port_enable",
        "Date": "Tue, 19 Sep 2017 10:46:46 -0700",
        "Message-Id": "<20170919174654.2122-5-f.fainelli@gmail.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20170919174654.2122-1-f.fainelli@gmail.com>",
        "References": "<20170919174654.2122-1-f.fainelli@gmail.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "There is no need to configure the enabled ports once in bcm_sf2_sw_setup() and\nthen a second time around when dsa_switch_ops::port_enable is called, just do\nit when port_enable is called which is better in terms of power consumption and\ncorrectness.\n\nReviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\nSigned-off-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n drivers/net/dsa/bcm_sf2.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c\nindex d7b53d53c116..8acbd17bc1fd 100644\n--- a/drivers/net/dsa/bcm_sf2.c\n+++ b/drivers/net/dsa/bcm_sf2.c\n@@ -890,14 +890,11 @@ static int bcm_sf2_sw_setup(struct dsa_switch *ds)\n \tstruct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);\n \tunsigned int port;\n \n-\t/* Enable all valid ports and disable those unused */\n+\t/* Disable unused ports and configure IMP port */\n \tfor (port = 0; port < priv->hw_params.num_ports; port++) {\n-\t\t/* IMP port receives special treatment */\n-\t\tif ((1 << port) & ds->enabled_port_mask)\n-\t\t\tbcm_sf2_port_setup(ds, port, NULL);\n-\t\telse if (dsa_is_cpu_port(ds, port))\n+\t\tif (dsa_is_cpu_port(ds, port))\n \t\t\tbcm_sf2_imp_setup(ds, port);\n-\t\telse\n+\t\telse if (!((1 << port) & ds->enabled_port_mask))\n \t\t\tbcm_sf2_port_disable(ds, port, NULL);\n \t}\n \n",
    "prefixes": [
        "net-next",
        "v3",
        "04/12"
    ]
}