Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 815750,
    "url": "http://patchwork.ozlabs.org/api/patches/815750/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170919174654.2122-4-f.fainelli@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170919174654.2122-4-f.fainelli@gmail.com>",
    "list_archive_url": null,
    "date": "2017-09-19T17:46:45",
    "name": "[net-next,v3,03/12] net: dsa: b53: Defer port enabling to calling port_enable",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a6b88b967fa843251221aa9cd5bcb574e1904e1f",
    "submitter": {
        "id": 2800,
        "url": "http://patchwork.ozlabs.org/api/people/2800/?format=api",
        "name": "Florian Fainelli",
        "email": "f.fainelli@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170919174654.2122-4-f.fainelli@gmail.com/mbox/",
    "series": [
        {
            "id": 3941,
            "url": "http://patchwork.ozlabs.org/api/series/3941/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3941",
            "date": "2017-09-19T17:46:42",
            "name": "net: dsa: b53/bcm_sf2 cleanups",
            "version": 3,
            "mbox": "http://patchwork.ozlabs.org/series/3941/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/815750/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/815750/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mhYfEEte\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVgm3jQkz9sBZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 03:47:16 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751803AbdISRrN (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 19 Sep 2017 13:47:13 -0400",
            "from mail-wr0-f195.google.com ([209.85.128.195]:35492 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751365AbdISRrL (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 19 Sep 2017 13:47:11 -0400",
            "by mail-wr0-f195.google.com with SMTP id n64so184160wrb.2\n\tfor <netdev@vger.kernel.org>; Tue, 19 Sep 2017 10:47:11 -0700 (PDT)",
            "from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tq19sm11543124wrb.17.2017.09.19.10.47.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 10:47:09 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=LzQkd2eWrREQGByv9+TQrFIlf65/ypkN9GUzfC/nFP0=;\n\tb=mhYfEEteH/LQyrpQ/YeuIs4tFtXbPwshegIQFn5aAcpK9kSoHC9uDEh3mVdlRY+7iC\n\tpH67x/8A8ZyldI81vZjlxOivBuXQnsLtMgvHWfoBrUkX3kPL0vQ8vv96EjmyjwTQlxet\n\tPUIS44k9GGpqj5OVLRiSai9DNCCRSyZ4cAM7OlB50V0jI89W06XVUGXcno0MGHXsAwCI\n\teGjUHJEQaiUI7NlO9uB/fE2F3S+NGTRKTz78nuc24PE5LdaQ4DG/4GTGVof/3IPa6+m1\n\tz3mwUcUvMoCEutYgQu7cER+0gBD56xw8u9Fbq5bmT0I1ZID9HiJKAaGMQ59GlFMrkB99\n\tqPaA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=LzQkd2eWrREQGByv9+TQrFIlf65/ypkN9GUzfC/nFP0=;\n\tb=uQ8vE6PE6HuGcWK/2hPXwPxxl2zZ3xOJQ8/zkCQEpB1707FeyTG1VeM79P+OImf/NV\n\txMIYp7l+Sk4i+YIjfXBV+XuL5rHClUhYkL6svvpAIHTTfcJsUkFDipwL7j4bM9kazk/z\n\tCp8Fsgd0f7VbtJlGp/H3zCSeC4EF837Re9usXdJs+hz1demFHABU/dzhJ9L2Jw4cnO2V\n\tl7hy9fxmZKSJ8kTqeMT/JlvLhIi2EodL4RX+T2ZRlx9Txeh4y+btIw1q/Qwh4J09Q9hF\n\ttfzdho9bHFk4L1eY5U2Yp57Xmvp5SxAA56hn9ee9jYhxyvbSQ7Jdea9fqHEqMCUoaZRT\n\tdRlA==",
        "X-Gm-Message-State": "AHPjjUiuWTAdMC1ZRDMf3DKyXVcdf4BOpQY/12KnoNbxCav/BDzLBUF9\n\tevUQa+TOB6Km+SFDD7OA8u32mx1I",
        "X-Google-Smtp-Source": "AOwi7QAB0fV+xV4XX4WZYKFMY2fpYT5noX4VvTYiXkYEyDvShc2fgcusGTff0oy2MDoHFcyvHBbyKA==",
        "X-Received": "by 10.223.150.171 with SMTP id u40mr2232761wrb.201.1505843230080;\n\tTue, 19 Sep 2017 10:47:10 -0700 (PDT)",
        "From": "Florian Fainelli <f.fainelli@gmail.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tFlorian Fainelli <f.fainelli@gmail.com>",
        "Subject": "[PATCH net-next v3 03/12] net: dsa: b53: Defer port enabling to\n\tcalling port_enable",
        "Date": "Tue, 19 Sep 2017 10:46:45 -0700",
        "Message-Id": "<20170919174654.2122-4-f.fainelli@gmail.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20170919174654.2122-1-f.fainelli@gmail.com>",
        "References": "<20170919174654.2122-1-f.fainelli@gmail.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "There is no need to configure the enabled ports once in b53_setup() and then a\nsecond time around when dsa_switch_ops::port_enable is called, just do it when\nport_enable is called which is better in terms of power consumption and\ncorrectness.\n\nReviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\nSigned-off-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n drivers/net/dsa/b53/b53_common.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c\nindex d8bc54cfcfbe..3297af6aab8a 100644\n--- a/drivers/net/dsa/b53/b53_common.c\n+++ b/drivers/net/dsa/b53/b53_common.c\n@@ -815,12 +815,13 @@ static int b53_setup(struct dsa_switch *ds)\n \tif (ret)\n \t\tdev_err(ds->dev, \"failed to apply configuration\\n\");\n \n+\t/* Configure IMP/CPU port, disable unused ports. Enabled\n+\t * ports will be configured with .port_enable\n+\t */\n \tfor (port = 0; port < dev->num_ports; port++) {\n-\t\tif (BIT(port) & ds->enabled_port_mask)\n-\t\t\tb53_enable_port(ds, port, NULL);\n-\t\telse if (dsa_is_cpu_port(ds, port))\n+\t\tif (dsa_is_cpu_port(ds, port))\n \t\t\tb53_enable_cpu_port(dev, port);\n-\t\telse\n+\t\telse if (!(BIT(port) & ds->enabled_port_mask))\n \t\t\tb53_disable_port(ds, port, NULL);\n \t}\n \n",
    "prefixes": [
        "net-next",
        "v3",
        "03/12"
    ]
}