Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815710/?format=api
{ "id": 815710, "url": "http://patchwork.ozlabs.org/api/patches/815710/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919165226.23022-5-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919165226.23022-5-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2017-09-19T16:52:03", "name": "[v2,04/27] libvhost-user: drop dependency on glib", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6ea445a1ce76bdffeff094c74beeb955e85b111d", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919165226.23022-5-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 3931, "url": "http://patchwork.ozlabs.org/api/series/3931/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3931", "date": "2017-09-19T16:51:59", "name": "vhost-user-scsi: code clean-up", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/3931/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815710/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxVCw4sbMz9rvt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 03:26:36 +1000 (AEST)", "from localhost ([::1]:44271 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1duMI6-0000Z2-MB\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 13:26:34 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:45949)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1duLlU-0005DR-DG\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:52:53 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1duLlT-0001T2-FE\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:52:52 -0400", "from mx1.redhat.com ([209.132.183.28]:38268)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <marcandre.lureau@redhat.com>)\n\tid 1duLlT-0001Sg-8b\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:52:51 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 419F481236;\n\tTue, 19 Sep 2017 16:52:50 +0000 (UTC)", "from localhost (ovpn-112-56.ams2.redhat.com [10.36.112.56])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AFE3465E84;\n\tTue, 19 Sep 2017 16:52:47 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 419F481236", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 19 Sep 2017 18:52:03 +0200", "Message-Id": "<20170919165226.23022-5-marcandre.lureau@redhat.com>", "In-Reply-To": "<20170919165226.23022-1-marcandre.lureau@redhat.com>", "References": "<20170919165226.23022-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 19 Sep 2017 16:52:50 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v2 04/27] libvhost-user: drop dependency on glib", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "pbonzini@redhat.com, felipe@nutanix.com, changpeng.liu@intel.com,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\tf4bug@amsat.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "libvhost-user is meant to be free of glib dependency. Make sure it is\nby droping qemu/osdep.h (which included glib.h)\n\nThis fixes a bad malloc()/g_free() pair.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\n contrib/libvhost-user/libvhost-user.c | 29 ++++++++++++++++++++++++++---\n 1 file changed, 26 insertions(+), 3 deletions(-)", "diff": "diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c\nindex d27d6303db..50657c5afb 100644\n--- a/contrib/libvhost-user/libvhost-user.c\n+++ b/contrib/libvhost-user/libvhost-user.c\n@@ -13,14 +13,35 @@\n * later. See the COPYING file in the top-level directory.\n */\n \n-#include <qemu/osdep.h>\n+/* this code avoids GLib dependency */\n+#include <stdlib.h>\n+#include <stdio.h>\n+#include <unistd.h>\n+#include <stdarg.h>\n+#include <errno.h>\n+#include <string.h>\n+#include <assert.h>\n+#include <inttypes.h>\n+#include <sys/types.h>\n+#include <sys/socket.h>\n #include <sys/eventfd.h>\n+#include <sys/mman.h>\n #include <linux/vhost.h>\n \n #include \"qemu/atomic.h\"\n+#include \"qemu/compiler.h\"\n \n #include \"libvhost-user.h\"\n \n+/* usually provided by GLib */\n+#ifndef MIN\n+#define MIN(x, y) ({ \\\n+ typeof(x) _min1 = (x); \\\n+ typeof(y) _min2 = (y); \\\n+ (void) (&_min1 == &_min2); \\\n+ _min1 < _min2 ? _min1 : _min2; })\n+#endif\n+\n #define VHOST_USER_HDR_SIZE offsetof(VhostUserMsg, payload.u64)\n \n /* The version of the protocol we support */\n@@ -81,7 +102,9 @@ vu_panic(VuDev *dev, const char *msg, ...)\n va_list ap;\n \n va_start(ap, msg);\n- buf = g_strdup_vprintf(msg, ap);\n+ if (vasprintf(&buf, msg, ap) < 0) {\n+ buf = NULL;\n+ }\n va_end(ap);\n \n dev->broken = true;\n@@ -853,7 +876,7 @@ vu_dispatch(VuDev *dev)\n success = true;\n \n end:\n- g_free(vmsg.data);\n+ free(vmsg.data);\n return success;\n }\n \n", "prefixes": [ "v2", "04/27" ] }