Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815624/?format=api
{ "id": 815624, "url": "http://patchwork.ozlabs.org/api/patches/815624/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919150313.10833-4-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919150313.10833-4-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2017-09-19T15:03:08", "name": "[v2,3/8] disas: Remove unused flags arguments", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c1c742739ed3b81e573d301be34221efe16130ff", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919150313.10833-4-richard.henderson@linaro.org/mbox/", "series": [ { "id": 3911, "url": "http://patchwork.ozlabs.org/api/series/3911/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3911", "date": "2017-09-19T15:03:05", "name": "Support the Capstone disassembler", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/3911/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815624/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815624/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"a5B0zSkh\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxRnF5NFJz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 01:36:48 +1000 (AEST)", "from localhost ([::1]:43607 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1duKZq-000406-0g\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 11:36:46 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:49136)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1duK3g-00086i-DF\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:03:41 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1duK3Z-0003f5-Ko\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:03:32 -0400", "from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]:47578)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1duK3Z-0003ej-EW\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:03:25 -0400", "by mail-io0-x232.google.com with SMTP id e189so735220ioa.4\n\tfor <qemu-devel@nongnu.org>; Tue, 19 Sep 2017 08:03:25 -0700 (PDT)", "from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\th63sm360621otb.59.2017.09.19.08.03.22 for <qemu-devel@nongnu.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 08:03:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:subject:date:message-id:in-reply-to:references:mime-version\n\t:content-transfer-encoding;\n\tbh=XrnyScPEbrBlz1u74LOLQ8+c+ie30N0jQT3fwEiUGpw=;\n\tb=a5B0zSkhgW2ydCqB/wgaYJB7peik6trNncBBTqyiHsCz3I3SmaSAkaMccAV1bPYcVM\n\tVLBertn3MtIa6MbmVexJwaIEsaxtcUVVIr11OvL97bsE1sYVELNxBycnioUc+H4ZnYN3\n\ttdGwPwG1tdLcRoswZp4s92WEm2RsZoApdUwTc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XrnyScPEbrBlz1u74LOLQ8+c+ie30N0jQT3fwEiUGpw=;\n\tb=HQJ1uF4CacRImBZBjCWzoag1LEe+OQg6VtpOiioCwXTWvV0Vg+NfjBqOmaxdgR8HQb\n\t69KHRYNAbZA/bUr9oDmCRVXZGcBpOUAhOkpnoBIMOWDvFnxwOLOzUy3nr0HA1LM3c5OO\n\t/0Uk+phD5/dIHQUHJ0cxESXXSzTZOvJq6rUHilgiH+JrxFQ3GLOGv+iotlFnxBPfDa4n\n\t4wLCdec06fFqb0G/7yz/PxsB/QeuIA/8/nK8szAdGTbZcSICXXh2jm1VYXyFcD4sCWKy\n\ttlrlu6GJu6hOqJyAGMGXBvxp8MtO3cOpoCJqWMG6De+XyDjAGEsfBBW5Q7irrfTEex15\n\tsWBg==", "X-Gm-Message-State": "AHPjjUgiRmrmyTg7FNT/58q85MgXfYXgMj85ImPQOrLYcp8PTZ3sgtjZ\n\tj5xetZdRLrdwYUllGVng7ZkOK6ZCl7o=", "X-Google-Smtp-Source": "AOwi7QDg692y+HhGZ2RjlJuijgBLzUw4tZK30fgMQi8fZpHYo2CAJheFOHFb41Nftw0QWy3lS4ckyA==", "X-Received": "by 10.202.245.195 with SMTP id t186mr1883167oih.78.1505833404175;\n\tTue, 19 Sep 2017 08:03:24 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 19 Sep 2017 10:03:08 -0500", "Message-Id": "<20170919150313.10833-4-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170919150313.10833-1-richard.henderson@linaro.org>", "References": "<20170919150313.10833-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:4001:c06::232", "Subject": "[Qemu-devel] [PATCH v2 3/8] disas: Remove unused flags arguments", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Now that every target is using the disas_set_info hook,\nthe flags argument is unused. Remove it.\n\nReviewed-by: Alex Bennée <alex.bennee@linaro.org>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n include/disas/disas.h | 4 ++--\n include/exec/log.h | 4 ++--\n disas.c | 15 ++++-----------\n monitor.c | 3 +--\n target/alpha/translate.c | 2 +-\n target/arm/translate-a64.c | 3 +--\n target/arm/translate.c | 3 +--\n target/cris/translate.c | 3 +--\n target/hppa/translate.c | 2 +-\n target/i386/translate.c | 2 +-\n target/lm32/translate.c | 2 +-\n target/m68k/translate.c | 2 +-\n target/microblaze/translate.c | 2 +-\n target/mips/translate.c | 2 +-\n target/nios2/translate.c | 2 +-\n target/openrisc/translate.c | 2 +-\n target/ppc/translate.c | 2 +-\n target/s390x/translate.c | 2 +-\n target/sh4/translate.c | 2 +-\n target/sparc/translate.c | 2 +-\n target/tricore/translate.c | 2 +-\n target/unicore32/translate.c | 2 +-\n target/xtensa/translate.c | 2 +-\n 23 files changed, 28 insertions(+), 39 deletions(-)", "diff": "diff --git a/include/disas/disas.h b/include/disas/disas.h\nindex e549ca24a1..4d48c13c65 100644\n--- a/include/disas/disas.h\n+++ b/include/disas/disas.h\n@@ -9,10 +9,10 @@\n /* Disassemble this for me please... (debugging). */\n void disas(FILE *out, void *code, unsigned long size);\n void target_disas(FILE *out, CPUState *cpu, target_ulong code,\n- target_ulong size, int flags);\n+ target_ulong size);\n \n void monitor_disas(Monitor *mon, CPUState *cpu,\n- target_ulong pc, int nb_insn, int is_physical, int flags);\n+ target_ulong pc, int nb_insn, int is_physical);\n \n /* Look up symbol for debugging purpose. Returns \"\" if unknown. */\n const char *lookup_symbol(target_ulong orig_addr);\ndiff --git a/include/exec/log.h b/include/exec/log.h\nindex ba1c9b5682..c249307911 100644\n--- a/include/exec/log.h\n+++ b/include/exec/log.h\n@@ -38,9 +38,9 @@ static inline void log_cpu_state_mask(int mask, CPUState *cpu, int flags)\n #ifdef NEED_CPU_H\n /* disas() and target_disas() to qemu_logfile: */\n static inline void log_target_disas(CPUState *cpu, target_ulong start,\n- target_ulong len, int flags)\n+ target_ulong len)\n {\n- target_disas(qemu_logfile, cpu, start, len, flags);\n+ target_disas(qemu_logfile, cpu, start, len);\n }\n \n static inline void log_disas(void *code, unsigned long size)\ndiff --git a/disas.c b/disas.c\nindex 3a375a3b6c..ad675dc361 100644\n--- a/disas.c\n+++ b/disas.c\n@@ -171,15 +171,9 @@ static int print_insn_od_target(bfd_vma pc, disassemble_info *info)\n return print_insn_objdump(pc, info, \"OBJD-T\");\n }\n \n-/* Disassemble this for me please... (debugging). 'flags' has the following\n- values:\n- i386 - 1 means 16 bit code, 2 means 64 bit code\n- ppc - bits 0:15 specify (optionally) the machine instruction set;\n- bit 16 indicates little endian.\n- other targets - unused\n- */\n+/* Disassemble this for me please... (debugging). */\n void target_disas(FILE *out, CPUState *cpu, target_ulong code,\n- target_ulong size, int flags)\n+ target_ulong size)\n {\n CPUClass *cc = CPU_GET_CLASS(cpu);\n target_ulong pc;\n@@ -336,10 +330,9 @@ monitor_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length,\n return 0;\n }\n \n-/* Disassembler for the monitor.\n- See target_disas for a description of flags. */\n+/* Disassembler for the monitor. */\n void monitor_disas(Monitor *mon, CPUState *cpu,\n- target_ulong pc, int nb_insn, int is_physical, int flags)\n+ target_ulong pc, int nb_insn, int is_physical)\n {\n CPUClass *cc = CPU_GET_CLASS(cpu);\n int count, i;\ndiff --git a/monitor.c b/monitor.c\nindex 23fda1c0d2..cd831eaab4 100644\n--- a/monitor.c\n+++ b/monitor.c\n@@ -1309,8 +1309,7 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,\n }\n \n if (format == 'i') {\n- int flags = 0;\n- monitor_disas(mon, cs, addr, count, is_physical, flags);\n+ monitor_disas(mon, cs, addr, count, is_physical);\n return;\n }\n \ndiff --git a/target/alpha/translate.c b/target/alpha/translate.c\nindex 5a92c4accb..e9a245f9c5 100644\n--- a/target/alpha/translate.c\n+++ b/target/alpha/translate.c\n@@ -3048,7 +3048,7 @@ static void alpha_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)\n static void alpha_tr_disas_log(const DisasContextBase *dcbase, CPUState *cpu)\n {\n qemu_log(\"IN: %s\\n\", lookup_symbol(dcbase->pc_first));\n- log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size, 1);\n+ log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size);\n }\n \n static const TranslatorOps alpha_tr_ops = {\ndiff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c\nindex 083568c468..1440e85083 100644\n--- a/target/arm/translate-a64.c\n+++ b/target/arm/translate-a64.c\n@@ -11402,8 +11402,7 @@ static void aarch64_tr_disas_log(const DisasContextBase *dcbase,\n DisasContext *dc = container_of(dcbase, DisasContext, base);\n \n qemu_log(\"IN: %s\\n\", lookup_symbol(dc->base.pc_first));\n- log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size,\n- 4 | (bswap_code(dc->sctlr_b) ? 2 : 0));\n+ log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size);\n }\n \n const TranslatorOps aarch64_translator_ops = {\ndiff --git a/target/arm/translate.c b/target/arm/translate.c\nindex ab1a12a1b8..93e9dbe33d 100644\n--- a/target/arm/translate.c\n+++ b/target/arm/translate.c\n@@ -12258,8 +12258,7 @@ static void arm_tr_disas_log(const DisasContextBase *dcbase, CPUState *cpu)\n DisasContext *dc = container_of(dcbase, DisasContext, base);\n \n qemu_log(\"IN: %s\\n\", lookup_symbol(dc->base.pc_first));\n- log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size,\n- dc->thumb | (dc->sctlr_b << 1));\n+ log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size);\n }\n \n static const TranslatorOps arm_translator_ops = {\ndiff --git a/target/cris/translate.c b/target/cris/translate.c\nindex 38a999e6f1..b1fda57c74 100644\n--- a/target/cris/translate.c\n+++ b/target/cris/translate.c\n@@ -3297,8 +3297,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n qemu_log_lock();\n qemu_log(\"--------------\\n\");\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, dc->pc - pc_start,\n- env->pregs[PR_VR]);\n+ log_target_disas(cs, pc_start, dc->pc - pc_start);\n qemu_log(\"\\nisize=%d osize=%d\\n\",\n dc->pc - pc_start, tcg_op_buf_count());\n qemu_log_unlock();\ndiff --git a/target/hppa/translate.c b/target/hppa/translate.c\nindex b6e2652341..fc2a9f5896 100644\n--- a/target/hppa/translate.c\n+++ b/target/hppa/translate.c\n@@ -3904,7 +3904,7 @@ static void hppa_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs)\n break;\n default:\n qemu_log(\"IN: %s\\n\", lookup_symbol(tb->pc));\n- log_target_disas(cs, tb->pc, tb->size, 1);\n+ log_target_disas(cs, tb->pc, tb->size);\n break;\n }\n }\ndiff --git a/target/i386/translate.c b/target/i386/translate.c\nindex 06c2cb9e64..23d9e05426 100644\n--- a/target/i386/translate.c\n+++ b/target/i386/translate.c\n@@ -8528,7 +8528,7 @@ static void i386_tr_disas_log(const DisasContextBase *dcbase,\n DisasContext *dc = container_of(dcbase, DisasContext, base);\n \n qemu_log(\"IN: %s\\n\", lookup_symbol(dc->base.pc_first));\n- log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size, 0);\n+ log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size);\n }\n \n static const TranslatorOps i386_tr_ops = {\ndiff --git a/target/lm32/translate.c b/target/lm32/translate.c\nindex 65bc9c0bf6..a83cbdf729 100644\n--- a/target/lm32/translate.c\n+++ b/target/lm32/translate.c\n@@ -1156,7 +1156,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n && qemu_log_in_addr_range(pc_start)) {\n qemu_log_lock();\n qemu_log(\"\\n\");\n- log_target_disas(cs, pc_start, dc->pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, dc->pc - pc_start);\n qemu_log(\"\\nisize=%d osize=%d\\n\",\n dc->pc - pc_start, tcg_op_buf_count());\n qemu_log_unlock();\ndiff --git a/target/m68k/translate.c b/target/m68k/translate.c\nindex d738f32f9c..e1e31f622c 100644\n--- a/target/m68k/translate.c\n+++ b/target/m68k/translate.c\n@@ -5620,7 +5620,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)\n qemu_log_lock();\n qemu_log(\"----------------\\n\");\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, dc->pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, dc->pc - pc_start);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/microblaze/translate.c b/target/microblaze/translate.c\nindex 067b0878d6..fecc61a1ec 100644\n--- a/target/microblaze/translate.c\n+++ b/target/microblaze/translate.c\n@@ -1810,7 +1810,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n qemu_log_lock();\n qemu_log(\"--------------\\n\");\n #if DISAS_GNU\n- log_target_disas(cs, pc_start, dc->pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, dc->pc - pc_start);\n #endif\n qemu_log(\"\\nisize=%d osize=%d\\n\",\n dc->pc - pc_start, tcg_op_buf_count());\ndiff --git a/target/mips/translate.c b/target/mips/translate.c\nindex c78d27294c..3b9cf9a236 100644\n--- a/target/mips/translate.c\n+++ b/target/mips/translate.c\n@@ -20369,7 +20369,7 @@ done_generating:\n && qemu_log_in_addr_range(pc_start)) {\n qemu_log_lock();\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, ctx.pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, ctx.pc - pc_start);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/nios2/translate.c b/target/nios2/translate.c\nindex 6b0961837d..7a0fa860da 100644\n--- a/target/nios2/translate.c\n+++ b/target/nios2/translate.c\n@@ -907,7 +907,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)\n && qemu_log_in_addr_range(tb->pc)) {\n qemu_log_lock();\n qemu_log(\"IN: %s\\n\", lookup_symbol(tb->pc));\n- log_target_disas(cs, tb->pc, dc->pc - tb->pc, 0);\n+ log_target_disas(cs, tb->pc, dc->pc - tb->pc);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/openrisc/translate.c b/target/openrisc/translate.c\nindex 112db1ad0f..99f2b463ce 100644\n--- a/target/openrisc/translate.c\n+++ b/target/openrisc/translate.c\n@@ -1653,7 +1653,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n \n if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)\n && qemu_log_in_addr_range(pc_start)) {\n- log_target_disas(cs, pc_start, tb->size, 0);\n+ log_target_disas(cs, pc_start, tb->size);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/ppc/translate.c b/target/ppc/translate.c\nindex bc155f1036..8e92e4579c 100644\n--- a/target/ppc/translate.c\n+++ b/target/ppc/translate.c\n@@ -7397,7 +7397,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n && qemu_log_in_addr_range(pc_start)) {\n qemu_log_lock();\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, ctx.nip - pc_start, 0);\n+ log_target_disas(cs, pc_start, ctx.nip - pc_start);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/s390x/translate.c b/target/s390x/translate.c\nindex 909b12818d..28bd02ceb3 100644\n--- a/target/s390x/translate.c\n+++ b/target/s390x/translate.c\n@@ -5910,7 +5910,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n qemu_log(\"IN: EXECUTE %016\" PRIx64 \"\\n\", dc.ex_value);\n } else {\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, dc.pc - pc_start, 1);\n+ log_target_disas(cs, pc_start, dc.pc - pc_start);\n qemu_log(\"\\n\");\n }\n qemu_log_unlock();\ndiff --git a/target/sh4/translate.c b/target/sh4/translate.c\nindex 10191073b2..7532bf74c1 100644\n--- a/target/sh4/translate.c\n+++ b/target/sh4/translate.c\n@@ -2347,7 +2347,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n && qemu_log_in_addr_range(pc_start)) {\n qemu_log_lock();\n \tqemu_log(\"IN:\\n\");\t/* , lookup_symbol(pc_start)); */\n- log_target_disas(cs, pc_start, ctx.pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, ctx.pc - pc_start);\n \tqemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/sparc/translate.c b/target/sparc/translate.c\nindex 6290705b11..e89b6227f2 100644\n--- a/target/sparc/translate.c\n+++ b/target/sparc/translate.c\n@@ -5855,7 +5855,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock * tb)\n qemu_log_lock();\n qemu_log(\"--------------\\n\");\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, last_pc + 4 - pc_start, 0);\n+ log_target_disas(cs, pc_start, last_pc + 4 - pc_start);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/tricore/translate.c b/target/tricore/translate.c\nindex 4e4198e887..e807500e26 100644\n--- a/target/tricore/translate.c\n+++ b/target/tricore/translate.c\n@@ -8839,7 +8839,7 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n && qemu_log_in_addr_range(pc_start)) {\n qemu_log_lock();\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, ctx.pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, ctx.pc - pc_start);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/unicore32/translate.c b/target/unicore32/translate.c\nindex 6c094d59d7..f9aa248a80 100644\n--- a/target/unicore32/translate.c\n+++ b/target/unicore32/translate.c\n@@ -2031,7 +2031,7 @@ done_generating:\n qemu_log_lock();\n qemu_log(\"----------------\\n\");\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, dc->pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, dc->pc - pc_start);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\ndiff --git a/target/xtensa/translate.c b/target/xtensa/translate.c\nindex d7bf07e8e6..03719ce12b 100644\n--- a/target/xtensa/translate.c\n+++ b/target/xtensa/translate.c\n@@ -3250,7 +3250,7 @@ done:\n qemu_log_lock();\n qemu_log(\"----------------\\n\");\n qemu_log(\"IN: %s\\n\", lookup_symbol(pc_start));\n- log_target_disas(cs, pc_start, dc.pc - pc_start, 0);\n+ log_target_disas(cs, pc_start, dc.pc - pc_start);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\n", "prefixes": [ "v2", "3/8" ] }