Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815468/?format=api
{ "id": 815468, "url": "http://patchwork.ozlabs.org/api/patches/815468/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919112645.8574-3-clg@kaod.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919112645.8574-3-clg@kaod.org>", "list_archive_url": null, "date": "2017-09-19T11:26:42", "name": "[2/5] aspeed: add an I2C RTC device to all machines", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "92e3350ae903b942f2fff3b0f4231e3db300cf8e", "submitter": { "id": 68548, "url": "http://patchwork.ozlabs.org/api/people/68548/?format=api", "name": "Cédric Le Goater", "email": "clg@kaod.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919112645.8574-3-clg@kaod.org/mbox/", "series": [ { "id": 3851, "url": "http://patchwork.ozlabs.org/api/series/3851/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3851", "date": "2017-09-19T11:26:40", "name": "aspeed: add a witherspoon-bmc machine", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3851/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815468/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815468/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxLG86NKhz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 21:28:00 +1000 (AEST)", "from localhost ([::1]:41680 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1duGh4-0002AR-EZ\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 07:27:58 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:49191)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <clg@kaod.org>) id 1duGgM-00025g-8D\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 07:27:18 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <clg@kaod.org>) id 1duGgJ-0006I5-4m\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 07:27:14 -0400", "from 3.mo179.mail-out.ovh.net ([178.33.251.175]:34368)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <clg@kaod.org>) id 1duGgI-0006Hc-UK\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 07:27:11 -0400", "from player716.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo179.mail-out.ovh.net (Postfix) with ESMTP id ED69D5B1BC\n\tfor <qemu-devel@nongnu.org>; Tue, 19 Sep 2017 13:27:09 +0200 (CEST)", "from zorba.kaod.org.com (deibp9eh1--blueice1n2.emea.ibm.com\n\t[195.212.29.164]) (Authenticated sender: clg@kaod.org)\n\tby player716.ha.ovh.net (Postfix) with ESMTPSA id 8115A56007E;\n\tTue, 19 Sep 2017 13:27:03 +0200 (CEST)" ], "From": "=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>", "To": "Peter Maydell <peter.maydell@linaro.org>", "Date": "Tue, 19 Sep 2017 13:26:42 +0200", "Message-Id": "<20170919112645.8574-3-clg@kaod.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170919112645.8574-1-clg@kaod.org>", "References": "<20170919112645.8574-1-clg@kaod.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Ovh-Tracer-Id": "18378345655579020049", "X-VR-SPAMSTATE": "OK", "X-VR-SPAMSCORE": "-100", "X-VR-SPAMCAUSE": "gggruggvucftvghtrhhoucdtuddrfeelledrheejgdegudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "178.33.251.175", "Subject": "[Qemu-devel] [PATCH 2/5] aspeed: add an I2C RTC device to all\n\tmachines", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Andrew Jeffery <andrew@aj.id.au>, =?utf-8?q?C=C3=A9dric_Le_Goater?=\n\t<clg@kaod.org>, qemu-arm@nongnu.org, qemu-devel@nongnu.org,\n\tJoel Stanley <joel@jms.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The AST2500 EVB does not have an RTC but we can pretend that one is\nplugged on the I2C bus header.\n\nThe romulus and witherspoon boards expects an Epson RX8900 I2C RTC but\na ds1338 is good enough for the basic features we need.\n\nSigned-off-by: Cédric Le Goater <clg@kaod.org>\n---\n hw/arm/aspeed.c | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)", "diff": "diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\nindex 81f522f711ae..362b683e9021 100644\n--- a/hw/arm/aspeed.c\n+++ b/hw/arm/aspeed.c\n@@ -89,6 +89,7 @@ enum {\n \n static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n+static void romulus_bmc_i2c_init(AspeedBoardState *bmc);\n static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n \n static const AspeedBoardConfig aspeed_boards[] = {\n@@ -114,6 +115,7 @@ static const AspeedBoardConfig aspeed_boards[] = {\n .fmc_model = \"n25q256a\",\n .spi_model = \"mx66l1g45g\",\n .num_cs = 2,\n+ .i2c_init = romulus_bmc_i2c_init,\n },\n [WITHERSPOON_BMC] = {\n .soc_name = \"ast2500-a1\",\n@@ -298,6 +300,10 @@ static void ast2500_evb_i2c_init(AspeedBoardState *bmc)\n \n /* The AST2500 EVB expects a LM75 but a TMP105 is compatible */\n i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 7), \"tmp105\", 0x4d);\n+\n+ /* The AST2500 EVB does not have an RTC. Let's pretend that one is\n+ * plugged on the I2C bus header */\n+ i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 11), \"ds1338\", 0x32);\n }\n \n static void ast2500_evb_init(MachineState *machine)\n@@ -325,6 +331,15 @@ static const TypeInfo ast2500_evb_type = {\n .class_init = ast2500_evb_class_init,\n };\n \n+static void romulus_bmc_i2c_init(AspeedBoardState *bmc)\n+{\n+ AspeedSoCState *soc = &bmc->soc;\n+\n+ /* The romulus board expects Epson RX8900 I2C RTC but a ds1338 is\n+ * good enough */\n+ i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 11), \"ds1338\", 0x32);\n+}\n+\n static void romulus_bmc_init(MachineState *machine)\n {\n aspeed_board_init(machine, &aspeed_boards[ROMULUS_BMC]);\n@@ -358,6 +373,10 @@ static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n \n i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n+\n+ /* The witherspoon board expects Epson RX8900 I2C RTC but a ds1338 is\n+ * good enough */\n+ i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 11), \"ds1338\", 0x32);\n }\n \n static void witherspoon_bmc_init(MachineState *machine)\n", "prefixes": [ "2/5" ] }