Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 815251,
    "url": "http://patchwork.ozlabs.org/api/patches/815251/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170919021947.8971-4-f.fainelli@gmail.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170919021947.8971-4-f.fainelli@gmail.com>",
    "list_archive_url": null,
    "date": "2017-09-19T02:19:38",
    "name": "[net-next,v2,03/12] net: dsa: b53: Defer port enabling to calling port_enable",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a6b88b967fa843251221aa9cd5bcb574e1904e1f",
    "submitter": {
        "id": 2800,
        "url": "http://patchwork.ozlabs.org/api/people/2800/?format=api",
        "name": "Florian Fainelli",
        "email": "f.fainelli@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170919021947.8971-4-f.fainelli@gmail.com/mbox/",
    "series": [
        {
            "id": 3767,
            "url": "http://patchwork.ozlabs.org/api/series/3767/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3767",
            "date": "2017-09-19T02:19:35",
            "name": "net: dsa: b53/bcm_sf2 cleanups",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/3767/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/815251/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/815251/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FJr51kEF\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx68C3CFTz9s78\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 12:22:03 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751074AbdISCVq (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 22:21:46 -0400",
            "from mail-wr0-f195.google.com ([209.85.128.195]:35584 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750974AbdISCUE (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 22:20:04 -0400",
            "by mail-wr0-f195.google.com with SMTP id n64so1367963wrb.2\n\tfor <netdev@vger.kernel.org>; Mon, 18 Sep 2017 19:20:03 -0700 (PDT)",
            "from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tq19sm9332458wrb.17.2017.09.18.19.20.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 19:20:01 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=LzQkd2eWrREQGByv9+TQrFIlf65/ypkN9GUzfC/nFP0=;\n\tb=FJr51kEFn6XBCFjuWnBXtg6bS1zyTo/q3RsUFV73GCnjy3eO3cu3xQq8ua3WJ14ZEs\n\tC7fAHIoEec0rmYEMPx72HQo+cX5qeM7EaOXxjAb+gCss1Fm4yPbIi/EqPcVQw5D+Virm\n\t1EXEeVauH+aZ44LVXsJf+WSgP+AveCkVv62KI+hTVnR6PR8Gtm0jMwgVmUah9FmFTcuv\n\tmJvpTFwKtfWUVuX8Di2GX5BAf+9ScE/PiT/8EcPJv6GS97VhgA1x7YY8kDrc713kYUml\n\tCM2v6cBpZDagYByPN+uh9IxuPAZ10ztFLZO3A02+VlnGxkWxut3QY1xye1+61XBJ+y8P\n\tX+wg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=LzQkd2eWrREQGByv9+TQrFIlf65/ypkN9GUzfC/nFP0=;\n\tb=QUNaGaT/r4NQTyAJVyBh8oUPyTNWrGUr9+mAlBgvzlvbcusNoQXvbIUevGikyus9vV\n\twfUQJUUkFvZE62cifrkV1kmal4PqX69VQqzvdhttbXFBhATnnZKGh2EK3+hAVdKF3kQ1\n\tFE38nEuuiWCMTbR/ZtuBTtgKihg6SGivnazP6qhr0MEfLFHdl49DNIrBHQMqG1pbbTYr\n\tD0nHbWXFTW36K7IIZpH0x9O+gprIrlPOMOQw5xpvFUXTwnHuulBA2yCC6bL8yDaA+CdP\n\tl3OjeTTKlzBPskNQqzUzzX1AgMXo7mNb8ZTDUCLWkA2Uebq6I49NA6rquaF74GN/WuNU\n\tGi/g==",
        "X-Gm-Message-State": "AHPjjUglDmLyj7MKzR+CsQT5AdxzI0qcs+P6KMy1LE0KWtDFPCiLg6hd\n\tH0Xc6tIyOYfIsIH16jQ=",
        "X-Google-Smtp-Source": "ADKCNb6EjOMEy2InhNqu2Y1+8V2sfNwVOKwgI0Tvl1Zukr6njrm4y4NeCQ0llRqqJLQCYGk0vJRuGA==",
        "X-Received": "by 10.223.154.120 with SMTP id\n\tz111mr29156409wrb.260.1505787602573; \n\tMon, 18 Sep 2017 19:20:02 -0700 (PDT)",
        "From": "Florian Fainelli <f.fainelli@gmail.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tdavem@davemloft.net, Florian Fainelli <f.fainelli@gmail.com>",
        "Subject": "[PATCH net-next v2 03/12] net: dsa: b53: Defer port enabling to\n\tcalling port_enable",
        "Date": "Mon, 18 Sep 2017 19:19:38 -0700",
        "Message-Id": "<20170919021947.8971-4-f.fainelli@gmail.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20170919021947.8971-1-f.fainelli@gmail.com>",
        "References": "<20170919021947.8971-1-f.fainelli@gmail.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "There is no need to configure the enabled ports once in b53_setup() and then a\nsecond time around when dsa_switch_ops::port_enable is called, just do it when\nport_enable is called which is better in terms of power consumption and\ncorrectness.\n\nReviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\nSigned-off-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n drivers/net/dsa/b53/b53_common.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c\nindex d8bc54cfcfbe..3297af6aab8a 100644\n--- a/drivers/net/dsa/b53/b53_common.c\n+++ b/drivers/net/dsa/b53/b53_common.c\n@@ -815,12 +815,13 @@ static int b53_setup(struct dsa_switch *ds)\n \tif (ret)\n \t\tdev_err(ds->dev, \"failed to apply configuration\\n\");\n \n+\t/* Configure IMP/CPU port, disable unused ports. Enabled\n+\t * ports will be configured with .port_enable\n+\t */\n \tfor (port = 0; port < dev->num_ports; port++) {\n-\t\tif (BIT(port) & ds->enabled_port_mask)\n-\t\t\tb53_enable_port(ds, port, NULL);\n-\t\telse if (dsa_is_cpu_port(ds, port))\n+\t\tif (dsa_is_cpu_port(ds, port))\n \t\t\tb53_enable_cpu_port(dev, port);\n-\t\telse\n+\t\telse if (!(BIT(port) & ds->enabled_port_mask))\n \t\t\tb53_disable_port(ds, port, NULL);\n \t}\n \n",
    "prefixes": [
        "net-next",
        "v2",
        "03/12"
    ]
}