Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815241/?format=api
{ "id": 815241, "url": "http://patchwork.ozlabs.org/api/patches/815241/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170919010628.175732-5-salil.mehta@huawei.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919010628.175732-5-salil.mehta@huawei.com>", "list_archive_url": null, "date": "2017-09-19T01:06:25", "name": "[net,4/7] net: hns3: fix a bug of set mac address", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5aa196cf2b3822296382bd572e9e5b4f8a5a1610", "submitter": { "id": 67454, "url": "http://patchwork.ozlabs.org/api/people/67454/?format=api", "name": "Salil Mehta", "email": "salil.mehta@huawei.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170919010628.175732-5-salil.mehta@huawei.com/mbox/", "series": [ { "id": 3764, "url": "http://patchwork.ozlabs.org/api/series/3764/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3764", "date": "2017-09-19T01:06:27", "name": "Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3764/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815241/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx4XT1dH4z9s78\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 11:09:29 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751524AbdISBHi (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 21:07:38 -0400", "from szxga05-in.huawei.com ([45.249.212.191]:6069 \"EHLO\n\tszxga05-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751416AbdISBHd (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 21:07:33 -0400", "from 172.30.72.60 (EHLO DGGEMS411-HUB.china.huawei.com)\n\t([172.30.72.60])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DHO21287; Tue, 19 Sep 2017 09:07:31 +0800 (CST)", "from S00293818-DELL1.china.huawei.com (10.47.92.71) by\n\tDGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP\n\tServer id 14.3.301.0; Tue, 19 Sep 2017 09:07:20 +0800" ], "From": "Salil Mehta <salil.mehta@huawei.com>", "To": "<davem@davemloft.net>", "CC": "<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,\n\t<lipeng321@huawei.com>, <mehta.salil.lnk@gmail.com>,\n\t<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,\n\t<linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>", "Subject": "[PATCH net 4/7] net: hns3: fix a bug of set mac address", "Date": "Tue, 19 Sep 2017 02:06:25 +0100", "Message-ID": "<20170919010628.175732-5-salil.mehta@huawei.com>", "X-Mailer": "git-send-email 2.8.3", "In-Reply-To": "<20170919010628.175732-1-salil.mehta@huawei.com>", "References": "<20170919010628.175732-1-salil.mehta@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.47.92.71]", "X-CFilter-Loop": "Reflected", "X-Mirapoint-Virus-RAPID-Raw": "score=unknown(0),\n\trefid=str=0001.0A020201.59C06DD3.0133, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32", "X-Mirapoint-Loop-Id": "a2efa8880ab61e8574fc0bdad7b666d8", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Lipeng <lipeng321@huawei.com>\n\nHNS3 driver get mac address from NCL_config file and set the mac address\nto HW. If the mac address in NCL_config is invalid, driver will set a\nrandom mac address, and use this address.\n\nThe current code will set random mac address to HW, but will not set the\nvalid mac address from NCL_config file to HW. This patch fix the bug.\n\nSigned-off-by: Lipeng <lipeng321@huawei.com>\nSigned-off-by: Salil Mehta <salil.mehta@huawei.com>\n---\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c\nindex 1c3e29447891..4d68d6ea5143 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c\n@@ -2705,10 +2705,11 @@ static void hns3_init_mac_addr(struct net_device *netdev)\n \t\teth_hw_addr_random(netdev);\n \t\tdev_warn(priv->dev, \"using random MAC address %pM\\n\",\n \t\t\t netdev->dev_addr);\n-\t\t/* Also copy this new MAC address into hdev */\n-\t\tif (h->ae_algo->ops->set_mac_addr)\n-\t\t\th->ae_algo->ops->set_mac_addr(h, netdev->dev_addr);\n \t}\n+\n+\tif (h->ae_algo->ops->set_mac_addr)\n+\t\th->ae_algo->ops->set_mac_addr(h, netdev->dev_addr);\n+\n }\n \n static void hns3_nic_set_priv_ops(struct net_device *netdev)\n", "prefixes": [ "net", "4/7" ] }