Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815219/?format=api
{ "id": 815219, "url": "http://patchwork.ozlabs.org/api/patches/815219/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170919003904.5124-6-tom@quantonium.net/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170919003904.5124-6-tom@quantonium.net>", "list_archive_url": null, "date": "2017-09-19T00:38:55", "name": "[net-next,05/14] gtp: Remove special mtu handling", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1300de02c858cede0aaabaf31629e37d96e868d0", "submitter": { "id": 72064, "url": "http://patchwork.ozlabs.org/api/people/72064/?format=api", "name": "Tom Herbert", "email": "tom@quantonium.net" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170919003904.5124-6-tom@quantonium.net/mbox/", "series": [ { "id": 3758, "url": "http://patchwork.ozlabs.org/api/series/3758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3758", "date": "2017-09-19T00:38:50", "name": "gtp: Additional feature support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3758/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815219/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815219/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=quantonium-net.20150623.gappssmtp.com\n\theader.i=@quantonium-net.20150623.gappssmtp.com\n\theader.b=\"SGte6+bP\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx3tN4S5wz9s78\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 10:39:56 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751450AbdISAjr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 20:39:47 -0400", "from mail-pg0-f43.google.com ([74.125.83.43]:44863 \"EHLO\n\tmail-pg0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751377AbdISAjo (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 20:39:44 -0400", "by mail-pg0-f43.google.com with SMTP id j16so1094024pga.1\n\tfor <netdev@vger.kernel.org>; Mon, 18 Sep 2017 17:39:44 -0700 (PDT)", "from localhost.localdomain (c-73-162-13-107.hsd1.ca.comcast.net.\n\t[73.162.13.107]) by smtp.gmail.com with ESMTPSA id\n\tk78sm662018pfb.157.2017.09.18.17.39.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 17:39:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=quantonium-net.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=vqzZUqff18NcNFh3+wi3bAvTQXk8vwMBp39XFhprHUU=;\n\tb=SGte6+bPUy8+CmpkzwoG4qH26AmM8yOFVwGvlVQHf3uegou2227OTZ3g1D0Z1yMSGD\n\taNROTD/1tPSgNqwZt6dEA8jnYppm0dLKdV0EGX/O8x5BzWa4+Z0MonR+PKorCYtshH7G\n\t/OdzKoj815eVwM83LnoI8PcT7RzXXNZx2O9OfMcgt0h6D0Dbxn3/DVLNpGrl0Honkiwr\n\tIlpvBdxv8VqOdgc23dxT7bj1mW+yhpnJCGala7TPZMFz4RqBjS2LJ+/hJYbqoZ9fWEqC\n\tHrOJQLl3GsObU4ldcupRC+xbUz6HqvQr2OxVoZCnmqYNIo7a+ZxYkerwNIAzFLK99HkB\n\tevjg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vqzZUqff18NcNFh3+wi3bAvTQXk8vwMBp39XFhprHUU=;\n\tb=ratSEZMWyQ++Sn9yiLR/7irisuTbFV0c8gZ4h/ut2/IJMihCnHmqLbM9uTRtUQzfvQ\n\tuTwGnv7/uyQN1usaCwdr1HAcPdchbRyTUPlMMqrtnmZFXjU5gg5rL7BLCs+T0lnoAQz0\n\tHy0KkfRl2/i5CV7k9JYdKZJDgYMtsHfmT6KFuPJVst+jx58NBB5PVKalXF4QbQIoBKue\n\t0QaS0oLJbgUZU/oqXwINDnIDXAi62H9Zm5GAOmPg21QXiHccFzKpSpPgVNeSeIJ15Yg4\n\tc+DA0wXtDDGPbtgtKf0XxnmOKE7AoeIKQNgXuKYifbqTCx6t+Whf1P6n5cHvsmTIMeWT\n\trOUw==", "X-Gm-Message-State": "AHPjjUhz7Az5C0yC0dtRKuXW6TgIuzchrMkFp4stREcqVmtxVnVPkPUu\n\t4xg7QG44il4nSSVF", "X-Google-Smtp-Source": "AOwi7QDRLfBsLgFb5fyYBvqfT8Q5zUdeU0yDLJCc/yUaLue9fjLsX5HUxrHJif6LtRJ4//1btcXEmQ==", "X-Received": "by 10.99.180.7 with SMTP id s7mr336148pgf.171.1505781584390;\n\tMon, 18 Sep 2017 17:39:44 -0700 (PDT)", "From": "Tom Herbert <tom@quantonium.net>", "To": "davem@davemloft.net", "Cc": "netdev@vger.kernel.org, pablo@netfilter.org, laforge@gnumonks.org,\n\trohit@quantonium.net, Tom Herbert <tom@quantonium.net>", "Subject": "[PATCH net-next 05/14] gtp: Remove special mtu handling", "Date": "Mon, 18 Sep 2017 17:38:55 -0700", "Message-Id": "<20170919003904.5124-6-tom@quantonium.net>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170919003904.5124-1-tom@quantonium.net>", "References": "<20170919003904.5124-1-tom@quantonium.net>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Removes MTU handling in gtp_build_skb_ip4. This is non standard relative\nto how other tunneling protocols handle MTU. The model espoused is that\nthe inner interface should set it's MTU to be less than the expected\npath MTU on the overlay network. Path MTU discovery is not typically\nused for modifying tunnel MTUs.\n\nSigned-off-by: Tom Herbert <tom@quantonium.net>\n---\n drivers/net/gtp.c | 30 ------------------------------\n 1 file changed, 30 deletions(-)", "diff": "diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c\nindex 1de2ea6217ea..f2089fa4f004 100644\n--- a/drivers/net/gtp.c\n+++ b/drivers/net/gtp.c\n@@ -466,8 +466,6 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev,\n \tstruct iphdr *iph;\n \tstruct sock *sk;\n \t__be32 saddr;\n-\t__be16 df;\n-\tint mtu;\n \n \t/* Read the IP destination address and resolve the PDP context.\n \t * Prepend PDP header with TEI/TID from PDP ctx.\n@@ -510,34 +508,6 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev,\n \n \tskb_dst_drop(skb);\n \n-\t/* This is similar to tnl_update_pmtu(). */\n-\tdf = iph->frag_off;\n-\tif (df) {\n-\t\tmtu = dst_mtu(&rt->dst) - dev->hard_header_len -\n-\t\t\tsizeof(struct iphdr) - sizeof(struct udphdr);\n-\t\tswitch (pctx->gtp_version) {\n-\t\tcase GTP_V0:\n-\t\t\tmtu -= sizeof(struct gtp0_header);\n-\t\t\tbreak;\n-\t\tcase GTP_V1:\n-\t\t\tmtu -= sizeof(struct gtp1_header);\n-\t\t\tbreak;\n-\t\t}\n-\t} else {\n-\t\tmtu = dst_mtu(&rt->dst);\n-\t}\n-\n-\trt->dst.ops->update_pmtu(&rt->dst, NULL, skb, mtu);\n-\n-\tif (!skb_is_gso(skb) && (iph->frag_off & htons(IP_DF)) &&\n-\t mtu < ntohs(iph->tot_len)) {\n-\t\tnetdev_dbg(dev, \"packet too big, fragmentation needed\\n\");\n-\t\tmemset(IPCB(skb), 0, sizeof(*IPCB(skb)));\n-\t\ticmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,\n-\t\t\t htonl(mtu));\n-\t\tgoto err_rt;\n-\t}\n-\n \tgtp_set_pktinfo_ipv4(pktinfo, sk, iph, pctx, rt, &fl4, dev);\n \tgtp_push_header(skb, pktinfo);\n \n", "prefixes": [ "net-next", "05/14" ] }