Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/815014/?format=api
{ "id": 815014, "url": "http://patchwork.ozlabs.org/api/patches/815014/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-15-david@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170918160012.4317-15-david@redhat.com>", "list_archive_url": null, "date": "2017-09-18T15:59:59", "name": "[v1,14/27] s390x/kvm: factor out storing of adtl CPU status", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "22db3ef51464697d32e09b2bf5160aed8938288b", "submitter": { "id": 70402, "url": "http://patchwork.ozlabs.org/api/people/70402/?format=api", "name": "David Hildenbrand", "email": "david@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170918160012.4317-15-david@redhat.com/mbox/", "series": [ { "id": 3672, "url": "http://patchwork.ozlabs.org/api/series/3672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3672", "date": "2017-09-18T15:59:45", "name": "s390x: SMP for TCG (+ cleanups)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3672/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/815014/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/815014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwrgf5VGGz9s7G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 02:14:54 +1000 (AEST)", "from localhost ([::1]:37635 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dtyhA-0001ZG-Mj\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 12:14:52 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:37652)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dtyUJ-0007LV-Ta\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:41 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dtyUI-00085r-SV\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:35 -0400", "from mx1.redhat.com ([209.132.183.28]:35826)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dtyUI-00085L-Kx\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:01:34 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8C3FEC070E2D;\n\tMon, 18 Sep 2017 16:01:33 +0000 (UTC)", "from t460s.redhat.com (unknown [10.36.118.72])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2970C5D6A8;\n\tMon, 18 Sep 2017 16:01:30 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 8C3FEC070E2D", "From": "David Hildenbrand <david@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 18 Sep 2017 17:59:59 +0200", "Message-Id": "<20170918160012.4317-15-david@redhat.com>", "In-Reply-To": "<20170918160012.4317-1-david@redhat.com>", "References": "<20170918160012.4317-1-david@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tMon, 18 Sep 2017 16:01:33 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v1 14/27] s390x/kvm: factor out storing of adtl\n\tCPU status", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tdavid@redhat.com, cohuck@redhat.com, Richard Henderson\n\t<richard.henderson@linaro.org>, Alexander Graf <agraf@suse.de>,\n\tborntraeger@de.ibm.com, \tIgor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n\tAurelien Jarno <aurelien@aurel32.net>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Called from SIGP code to be factored out, so let's move it. Add a\nFIXME for TCG code in the future.\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/helper.c | 29 +++++++++++++++++++++++++++++\n target/s390x/internal.h | 1 +\n target/s390x/kvm.c | 30 +-----------------------------\n 3 files changed, 31 insertions(+), 29 deletions(-)", "diff": "diff --git a/target/s390x/helper.c b/target/s390x/helper.c\nindex e44d54b932..4d5a92c2ca 100644\n--- a/target/s390x/helper.c\n+++ b/target/s390x/helper.c\n@@ -290,6 +290,35 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool store_arch)\n \n return 0;\n }\n+\n+#define ADTL_GS_OFFSET 1024 /* offset of GS data in adtl save area */\n+#define ADTL_GS_MIN_SIZE 2048 /* minimal size of adtl save area for GS */\n+int s390_store_adtl_status(S390CPU *cpu, hwaddr addr, hwaddr len)\n+{\n+ hwaddr save = len;\n+ void *mem;\n+\n+ mem = cpu_physical_memory_map(addr, &save, 1);\n+ if (!mem) {\n+ return -EFAULT;\n+ }\n+ if (save != len) {\n+ cpu_physical_memory_unmap(mem, len, 1, 0);\n+ return -EFAULT;\n+ }\n+\n+ /* FIXME: as soon as TCG supports these features, convert cpu->be */\n+ if (s390_has_feat(S390_FEAT_VECTOR)) {\n+ memcpy(mem, &cpu->env.vregs, 512);\n+ }\n+ if (s390_has_feat(S390_FEAT_GUARDED_STORAGE) && len >= ADTL_GS_MIN_SIZE) {\n+ memcpy(mem + ADTL_GS_OFFSET, &cpu->env.gscb, 32);\n+ }\n+\n+ cpu_physical_memory_unmap(mem, len, 1, len);\n+\n+ return 0;\n+}\n #endif /* CONFIG_USER_ONLY */\n \n void s390_cpu_dump_state(CPUState *cs, FILE *f, fprintf_function cpu_fprintf,\ndiff --git a/target/s390x/internal.h b/target/s390x/internal.h\nindex 30bcd7b662..1d86f48990 100644\n--- a/target/s390x/internal.h\n+++ b/target/s390x/internal.h\n@@ -341,6 +341,7 @@ void s390x_cpu_timer(void *opaque);\n void do_restart_interrupt(CPUS390XState *env);\n #define S390_STORE_STATUS_DEF_ADDR offsetof(LowCore, floating_pt_save_area)\n int s390_store_status(S390CPU *cpu, hwaddr addr, bool store_arch);\n+int s390_store_adtl_status(S390CPU *cpu, hwaddr addr, hwaddr len);\n #ifndef CONFIG_USER_ONLY\n LowCore *cpu_map_lowcore(CPUS390XState *env);\n void cpu_unmap_lowcore(LowCore *lowcore);\ndiff --git a/target/s390x/kvm.c b/target/s390x/kvm.c\nindex a6bc27eb28..01c4125d21 100644\n--- a/target/s390x/kvm.c\n+++ b/target/s390x/kvm.c\n@@ -1517,34 +1517,6 @@ static void sigp_stop(CPUState *cs, run_on_cpu_data arg)\n si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;\n }\n \n-#define ADTL_GS_OFFSET 1024 /* offset of GS data in adtl save area */\n-#define ADTL_GS_MIN_SIZE 2048 /* minimal size of adtl save area for GS */\n-static int do_store_adtl_status(S390CPU *cpu, hwaddr addr, hwaddr len)\n-{\n- hwaddr save = len;\n- void *mem;\n-\n- mem = cpu_physical_memory_map(addr, &save, 1);\n- if (!mem) {\n- return -EFAULT;\n- }\n- if (save != len) {\n- cpu_physical_memory_unmap(mem, len, 1, 0);\n- return -EFAULT;\n- }\n-\n- if (s390_has_feat(S390_FEAT_VECTOR)) {\n- memcpy(mem, &cpu->env.vregs, 512);\n- }\n- if (s390_has_feat(S390_FEAT_GUARDED_STORAGE) && len >= ADTL_GS_MIN_SIZE) {\n- memcpy(mem + ADTL_GS_OFFSET, &cpu->env.gscb, 32);\n- }\n-\n- cpu_physical_memory_unmap(mem, len, 1, len);\n-\n- return 0;\n-}\n-\n static void sigp_stop_and_store_status(CPUState *cs, run_on_cpu_data arg)\n {\n S390CPU *cpu = S390_CPU(cs);\n@@ -1637,7 +1609,7 @@ static void sigp_store_adtl_status(CPUState *cs, run_on_cpu_data arg)\n \n cpu_synchronize_state(cs);\n \n- if (do_store_adtl_status(cpu, addr, len)) {\n+ if (s390_store_adtl_status(cpu, addr, len)) {\n set_sigp_status(si, SIGP_STAT_INVALID_PARAMETER);\n return;\n }\n", "prefixes": [ "v1", "14/27" ] }